Re: Review Request 43546: Added common compression utilities.

2016-02-13 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/#review119146 --- Should we link this review request to

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-13 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119147 --- I think this review request should be linked to

Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-02-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-4663

Re: Review Request 43546: Added common compression utilities.

2016-02-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43546/ --- (Updated Feb. 13, 2016, 4:30 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-13 Thread Jojy Varghese
> On Feb. 13, 2016, 1:58 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp, line 89 > > > > > > No need for 'doFetchImage' since only this function is using it. Can > > you just

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-02-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43558/#review119149 --- Patch looks great! Reviews applied: [43558] Passed command:

Re: Review Request 41854: Added module initialization to Master main().

2016-02-13 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/ --- (Updated Feb. 13, 2016, 5:32 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-13 Thread Anindya Sinha
> On Feb. 13, 2016, 12:57 a.m., Greg Mann wrote: > > include/mesos/resources.hpp, line 222 > > > > > > I might recommend renaming this method, due to the ubiquitous `get()` > > method of the `Future` and `Option`

Re: Review Request 41854: Added module initialization to Master main().

2016-02-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review119158 --- Patch looks great! Reviews applied: [41760, 41854] Passed

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41854/#review119143 --- Bad patch! Reviews applied: [41760, 41854] Failed command:

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-13 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/ --- (Updated Feb. 14, 2016, 2:58 a.m.) Review request for mesos and Adam B.

Re: Review Request 43562: Updated protobuf Resources to include ShareInfo.

2016-02-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43562/ --- (Updated Feb. 14, 2016, 6:29 a.m.) Review request for mesos. Bugs:

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/#review119167 --- Patch looks great! Reviews applied: [42705] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-02-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated Feb. 14, 2016, 2:38 p.m.) Review request for mesos and Ben Mahler.

Review Request 43562: Updated protobuf Resources to include ShareInfo.

2016-02-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43562/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 42993: Support for multiple frameworks sharing the same resource.

2016-02-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42993/ --- (Updated Feb. 14, 2016, 6:25 a.m.) Review request for mesos and Adam B.

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- (Updated Feb. 14, 2016, 6:24 a.m.) Review request for mesos and Adam B.

Re: Review Request 43491: Added note about implicit default filter to javadoc.

2016-02-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43491/#review119166 --- Ship it! Ship It! - Alexander Rojas On Feb. 14, 2016, 3:38

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-02-13 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/ --- (Updated Feb. 14, 2016, 3:01 a.m.) Review request for mesos and Adam B.

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43284/ --- (Updated Feb. 14, 2016, 7:59 a.m.) Review request for mesos, Ian Downes, Jan

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-13 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43283/ --- (Updated Feb. 14, 2016, 7:59 a.m.) Review request for mesos, Ian Downes, Jan