Re: Review Request 43855: Added Appc fetcher support to store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43855/ --- (Updated Feb. 26, 2016, 8:36 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review120848 --- Patch looks great! Reviews applied: [43613, 43614, 43629, 43630,

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120849 --- Bad patch! Reviews applied: [44058] Failed command: ./support/ap

Review Request 44063: Waited for status update to happen before proceeding in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/ --- Review request for mesos. Bugs: MESOS-4784 https://issues.apache.org/jira/b

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

> On 二月 26, 2016, 9:34 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [44058] > > > > Failed command: ./support/apply-review.sh -n -r 44058 > > > > Error: > > 2016-02-26 09:34:14 URL:https://reviews.apache.org/r/44058/diff/raw/ > > [4122/4122] -> "44058.patch" [1] > > To

Re: Review Request 43999: Use relative path to create libraries symbolic link.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review120856 --- Patch looks great! Reviews applied: [43999] Passed command: expo

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review120859 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44058/#review120860 --- Ship it! Ship It! - haosdent huang On Feb. 26, 2016, 7:19 a.

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review120685 --- src/tests/cluster.hpp (line 111)

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44029/#review120864 --- Ship it! There is a more elaborate solution to this problem (h

Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/ --- Review request for mesos. Bugs: MESOS-4776 https://issues.apache.org/jira/b

Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/ --- Review request for mesos. Bugs: MESOS-4776 https://issues.apache.org/jira/b

Re: Review Request 44044: CMake: src CMakeLists-Added source to build master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/ --- (Updated Feb. 26, 2016, 3:10 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/ --- (Updated Feb. 26, 2016, 3:16 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/#review120871 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/ --- Review request for mesos. Bugs: MESOS-4783 https://issues.apache.org/jira/b

Re: Review Request 44044: CMake: src CMakeLists-Added source to build master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44044/#review120874 --- Bad patch! Reviews applied: [44044, 44008, 44007, 44005, 44003, 4

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/ --- (Updated Feb. 26, 2016, 4:53 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

> On Feb. 26, 2016, 5:44 a.m., Neil Conway wrote: > > src/master/master.cpp, line 2859 > > > > > > Is there a reason to prefer `std::set` over `hashset`? I would > > typically use `hashset` unless we care about ord

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/ --- (Updated Feb. 26, 2016, 4:54 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/ --- (Updated Feb. 26, 2016, 4:58 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/#review120883 --- docs/configuration.md (line 1690)

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/#review120882 --- 3rdparty/libprocess/src/metrics/metrics.cpp (line 50)

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

> On Feb. 24, 2016, 8:03 p.m., Jojy Varghese wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 361 > > > > > > Would it add value if we assert that the store does not currently have > > the image

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 26, 2016, 6 p.m.) Review request for mesos, Alexander Rukletsov a

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 26, 2016, 6:01 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 26, 2016, 6:01 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 26, 2016, 6:02 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/ --- (Updated Feb. 26, 2016, 6:03 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 25, 2016, 5:30 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed framework

Re: Review Request 43879: Added allocator metrics for number of allocations made.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/ --- (Updated Feb. 26, 2016, 6:03 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/ --- (Updated Feb. 26, 2016, 4:56 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

> On Feb. 26, 2016, 5:42 a.m., Neil Conway wrote: > > src/tests/reservation_endpoints_tests.cpp, line 1273 > > > > > > The analogous test for volumes names these variables differently > > (`volume1`, `volume2`, and

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120888 --- Fix it, then Ship it! include/mesos/authorizer/authorizer.prot

Re: Review Request 43777: Removed unnecessary parameter from validation function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43777/#review120891 --- Ship it! Ship It! - Jie Yu On Feb. 24, 2016, 6:41 p.m., Greg

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/ --- (Updated Feb. 26, 2016, 5:29 p.m.) Review request for mesos, Gilbert Song, Jojy

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/ --- (Updated Feb. 26, 2016, 5:33 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

> On Feb. 26, 2016, 5:26 p.m., Jie Yu wrote: > > include/mesos/authorizer/authorizer.proto, line 88 > > > > > > Can you callout this change in upgrads.md? I think it's binary > > compatible, but now source compatible

Re: Review Request 43999: Use relative path to create libraries symbolic link.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review120894 --- Fix it, then Ship it! I'll fix it for you and commit it shortly

Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS to get time and date.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43995/#review120898 --- Patch looks great! Reviews applied: [43995] Passed command: expo

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

> On Feb. 26, 2016, 5:36 a.m., Neil Conway wrote: > > This needs a prominent note in `upgrades.md` about the change to the ACL > > format. Thinking about it, the ACL isn't stored anywhere, so there's no > > issue with incompatibility of stored state. Similarly, rolling upgrades > > should be o

Re: Review Request 43777: Removed unnecessary parameter from validation function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43777/ --- (Updated Feb. 26, 2016, 5:44 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43997: CMake: Move FindApr and FindSvn to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43997/#review120900 --- Hmm, I think I might have missed the rationale for moving this. Le

Re: Review Request 44005: CMake: StoutTestsConfigure-removed FindApr & FindSvn, moved to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44005/#review120901 --- As I mentioned in the other review, my suspicion is that not might

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review120902 --- Bad patch! Reviews applied: [44078, 44077, 44076, 44075, 44046, 4

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- (Updated Feb. 26, 2016, 6:30 p.m.) Review request for mesos, Jie Yu, Michael Pa

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- (Updated Feb. 26, 2016, 6:31 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review120909 --- Bad review! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Review Request 44096: Fixed assignment line wrapping in style guide example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44096/ --- Review request for mesos. Bugs: MESOS-4786 https://issues.apache.org/jira/b

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

> On Feb. 26, 2016, 5:26 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2863 > > > > > > You can use '!roles.contains' here. Awesome, thanks! - Greg

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/ --- (Updated Feb. 26, 2016, 6:52 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/ --- (Updated Feb. 26, 2016, 6:53 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43776: Changed object of `ReserveResources` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43776/#review120916 --- Ship it! Ship It! - Neil Conway On Feb. 26, 2016, 6:52 p.m.,

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120918 --- Fix it, then Ship it! docs/upgrades.md (line 11)

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120919 --- Ship it! Ship It! - Neil Conway On Feb. 26, 2016, 4:58 p.m.,

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/#review120920 --- Ship it! Ship It! - Neil Conway On Feb. 26, 2016, 4:56 p.m.,

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/#review120923 --- Fix it, then Ship it! src/master/master.cpp (line 2930)

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review120924 --- Ship it! Basic impression: this isn't ideal, but I'm not sure w

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/ --- (Updated Feb. 26, 2016, 7:07 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/#review120908 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (line 74)

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/ --- (Updated Feb. 26, 2016, 7:08 p.m.) Review request for mesos, Adam B, Jie Yu, Mi

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

> On Feb. 26, 2016, 6:58 p.m., Neil Conway wrote: > > src/master/master.cpp, line 2930 > > > > > > Should talk about persistent volumes, not reservations. Whoops, sorry. Fixed! - Greg --

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44047/ --- (Updated Feb. 26, 2016, 7:10 p.m.) Review request for mesos, Michael Park and V

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review120930 --- Ship it! We should really add an effort to get this kind of fix

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43760/#review120928 --- src/exec/exec.cpp (line 693)

Re: Review Request 44071: Allowed disabling metrics endpoint rate limiting via the environment.

> On Feb. 26, 2016, 6 p.m., Benjamin Bannier wrote: > > docs/configuration.md, line 1690 > > > > > > Rename to `LIBPROCESS_METRICS_RATE_LIMIT` and document changed > > semantics (comment in previous patch). Does t

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/#review120938 --- src/tests/main.cpp (line 75)

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43782/#review120895 --- Fix it, then Ship it! src/master/master.cpp (line 2934)

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/#review120932 --- 3rdparty/libprocess/src/libevent_poll.cpp (line 50)

Re: Review Request 43778: Added '/create-volumes' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43778/#review120939 --- Ship it! Ship It! - Jie Yu On Feb. 26, 2016, 4:56 p.m., Greg

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/#review120940 --- Patch looks great! Reviews applied: [43958, 43959, 43960] Passed

Re: Review Request 43779: Added '/reserve' tests with multiple roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43779/#review120942 --- Ship it! Ship It! - Jie Yu On Feb. 26, 2016, 4:58 p.m., Greg

Re: Review Request 43798: Added overview section to upgrades.md.

> On Feb. 26, 2016, 7:02 p.m., Neil Conway wrote: > > Basic impression: this isn't ideal, but I'm not sure we can do better given > > the formatting constraints of Markdown. So, ship it I guess? :) As discussed earlier I agree with you in both aspects - Joerg ---

Re: Review Request 43782: Changed object of `CreateVolume` ACL to `roles`.

> On Feb. 26, 2016, 7:33 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2934 > > > > > > Ditto on using 'contains' I think I probably pushed an update while you were reviewing, this should be in the latest di

Re: Review Request 43800: Updated docs for reservation, volumes, and authZ.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43800/#review120945 --- Ship it! Ship It! - Jie Yu On Feb. 26, 2016, 7:07 p.m., Greg

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

> On Feb. 26, 2016, 1:40 p.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated Feb. 26, 2016, 11:50 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On Feb. 26, 2016, 4:19 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 260 > > > > > > All this is nice to know, but ho does it connect to the variable > > "isShutdown" and why is it named this way? Wh

Re: Review Request 43960: Added an end-to-end test for docker registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43960/#review120948 --- Ship it! Ship It! - Gilbert Song On Feb. 26, 2016, 9:29 a.m.

Re: Review Request 43662: Added support for pipelining calls to the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43662/#review120947 --- src/scheduler/scheduler.cpp (lines 203 - 206)

Re: Review Request 43796: Added documentation for `cgroups/net_cls` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43796/#review120950 --- Ship it! Ship It! - Neil Conway On Feb. 22, 2016, 6:26 p.m.,

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/ --- (Updated Feb. 26, 2016, 9:21 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review120954 --- Patch looks great! Reviews applied: [42733] Passed command: expo

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/ --- (Updated Feb. 26, 2016, 9:23 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

> On Feb. 25, 2016, 12:22 a.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 52 > > > > > > Why is the cast to `size_t` needed here? > > Alex Clemmer wrote: > It is req

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review120956 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:13 p.m.,

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review120957 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17 p.m.,

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review120958 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17 p.m.,

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43799/ --- (Updated Feb. 26, 2016, 10:29 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 38074: Calculate schedule latency with trace events

> On Nov. 18, 2015, 12:51 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/cgroups/perf_event.hpp, line 97 > > > > > > linux/cgroups has an internal {{Result cgroup(pid_t pid, const > > string& subsystem

Review Request 44101: Added links to the operator endpoint doc pages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44101/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 43938: Required jsonifying of generic protobuf to be explicit opt-in [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43938/#review120963 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/inclu

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review120964 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:41 p.m.,

  1   2   >