Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 1, 2016, 7:53 a.m.) Review request for mesos and Adam B. Chang

Re: Review Request 42719: Add doc for weights.

> On Feb. 28, 2016, 8:21 a.m., Adam B wrote: > > Thanks! Couple of tweaks as I review it again. > > - How did you test that this renders correctly? Did you try > > `support/site-docker` to see if the markdown translates properly to html? > > Just because it looks good in github doesn't mean our

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review121402 --- Patch looks great! Reviews applied: [43824] Passed command: expo

Re: Review Request 44004: Add 'name' field into NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- (Updated March 1, 2016, 3:28 p.m.) Review request for mesos, Avinash sridharan,

Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44200/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: ME

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 1, 2016, 6:42 a.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 41672: Test case(s) for weights + allocation behaviour.

> On Feb. 19, 2016, 9:31 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2373 > > > > > > You can put framework id's into a `std::set` instead. Given there are > > two allocat

Re: Review Request 43824: Addressed comments of 41672.

> On Feb. 28, 2016, 9:39 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2658-2661 > > > > > > Can you say 100% and 0% instead of 1 and 0? And how is framework1's > > "share" '6'? Is that

Re: Review Request 44191: Avoided external linkage for master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/#review121391 --- Patch looks great! Reviews applied: [44190, 44191] Passed comman

Re: Review Request 44179: Reintroduce deleted anchor in configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44179/#review121385 --- Patch looks great! Reviews applied: [44179] Passed command: expo

Re: Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/#review121384 --- docs/mesos-containerizer.md (line 115)

Re: Review Request 44191: Avoided external linkage for master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/ --- (Updated March 1, 2016, 2:26 a.m.) Review request for mesos and Ben Mahler. B

Review Request 44190: Made `Bytes` usable in `constexpr` expressions [stout].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44190/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4790 https://issues.ap

Review Request 44191: Avoided external linkage for master constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44191/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4790 https://issues.ap

Re: Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/#review121382 --- Patch looks great! Reviews applied: [44189] Passed command: expo

Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44185/#review121369 --- Patch looks great! Reviews applied: [44185] Passed command: expo

Re: Review Request 44179: Reintroduce deleted anchor in configuration.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44179/ --- (Updated March 1, 2016, 12:36 a.m.) Review request for mesos, Greg Mann and Nei

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121366 --- src/master/allocator/mesos/hierarchical.hpp (line 302)

Review Request 44189: Document docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44189/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Neil Conway, and Timothy Ch

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/#review121363 --- src/master/allocator/mesos/hierarchical.cpp (lines 276 - 282)

Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44185/ --- (Updated Feb. 29, 2016, 11:34 p.m.) Review request for mesos and Vinod Kone.

Review Request 44185: Clarified docs for `--offer_timeout` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44185/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121360 --- src/master/allocator/mesos/hierarchical.cpp (lines 268 - 271)

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

> On Feb. 28, 2016, 4:49 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 384 > > > > > > Should we remove this `Gauge` when remove framework? I think given this comment in the patch: > /

Re: Review Request 43882: Added allocation metrics for allocation time.

> On Feb. 27, 2016, 2:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 360 > > > > > > There is a second parameter in the `Timer` object which allows you to > > specify a window,

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121343 --- src/tests/hierarchical_allocator_tests.cpp (line 2481)

Re: Review Request 43914: Modified `NetClsHandleManager` to take a range of secondary handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43914/#review121339 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43880/#review121330 --- src/master/allocator/mesos/hierarchical.hpp (line 478)

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43915/ --- (Updated Feb. 29, 2016, 10:16 p.m.) Review request for mesos and Jie Yu. Chan

Review Request 44182: Added the flag --cgroups_net_cls_secondary_handles to documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44182/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4700 https://issues.apache

Re: Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43916/ --- (Updated Feb. 29, 2016, 10:16 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 44004: Add 'name' field into NetworkInfo.

> On Feb. 29, 2016, 8:19 p.m., Avinash sridharan wrote: > > include/mesos/mesos.proto, line 1585 > > > > > > s/, E.g., for MesosContainerizer/. For ,e.g., in case of the > > `MesosContainerizer`/ Actually, made a

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated Feb. 29, 2016, 1:55 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated Feb. 29, 2016, 1:32 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated Feb. 29, 2016, 1:32 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 44004: Add 'name' field into NetworkInfo.

> On Feb. 29, 2016, 8:16 p.m., Avinash sridharan wrote: > > Ship It! Fix it, then ship it !! - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121313

Re: Review Request 44004: Add 'name' field into NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121315 --- include/mesos/mesos.proto (line 1585)

Re: Review Request 44004: Add 'name' field into NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121313 --- Ship it! Ship It! - Avinash sridharan On Feb. 29, 2016, 2:04

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121310 --- Bad review! Reviews applied: [43884, 43883, 43882, 43881, 43880,

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 29, 2016, 6:08 p.m., Alexander Rojas wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2498-2502 > > > > > > This is my fault, I don't know how I missed this, but here you can even > > reused t

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43883/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44110: Updated flag examples to refer to /metrics/snapshot instead of stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/ --- (Updated Feb. 29, 2016, 7:43 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 44153: Obtained uid/gids before changing filesystem root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44153/#review121289 --- 1. Looks like after this patch all os::su() callers are gone, can

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/ --- (Updated Feb. 29, 2016, 6:42 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 44151: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44151/#review121280 --- 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp (li

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/ --- (Updated Feb. 29, 2016, 6:17 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/ --- (Updated Feb. 29, 2016, 6:15 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

> On Feb. 18, 2016, 6:35 p.m., Yi Sun wrote: > > 3rdparty/libprocess/cmake/ProcessConfigure.cmake, line 54 > > > > > > Does STOUT_DEPENDENCIES already contain PICOJSON_TARGET? GOod catch, thanks Yi. :) - Alex ---

Re: Review Request 43999: Use relative path to create libraries symbolic link.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review121264 --- Ship it! This looks fine to me. I think it would help future ge

Re: Review Request 43882: Added allocation metrics for allocation time.

> On Feb. 27, 2016, 2:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1220 > > > > > > Add a `CHECK_NOT_NULL` > > Benjamin Bannier wrote: > `timer` is initialized from a re

Re: Review Request 44164: Improved debug ability for docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44164/#review121257 --- Patch looks great! Reviews applied: [44164] Passed command: expo

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43881/#review121254 --- src/tests/hierarchical_allocator_tests.cpp (lines 2498 - 2502)

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 25, 2016, 5:30 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > > > > > We also need to remove counter in `removeFramework`; or we'll see > > metrics of removed framework

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/#review121252 --- Ship it! Ship It! - Alexander Rojas On Feb. 28, 2016, 10:28

Review Request 44164: Improved debug ability for docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44164/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-4796 https:/

Re: Review Request 44004: Add 'name' field into NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/#review121247 --- Patch looks great! Reviews applied: [44004] Passed command: expo

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/#review121241 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 28, 2016, 9:

Re: Review Request 44004: Add 'name' field into NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- (Updated Feb. 29, 2016, 10:04 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 44004: Add 'name' field into NetworkInfo.

> On Feb. 26, 2016, 9 a.m., Avinash sridharan wrote: > > include/mesos/mesos.proto, line 1577 > > > > > > In order to expose this field in state.json, I think you need to add > > the filed to the corresponding `mod

Re: Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/#review121237 --- Patch looks great! Reviews applied: [44163] Passed command: expo

Re: Review Request 44004: Add 'name' field into NetworkInfo.

> On Feb. 25, 2016, 11:32 p.m., Avinash sridharan wrote: > > include/mesos/v1/mesos.proto, line 1573 > > > > > > Ditto. Agree. - Qian --- This is an autom

Re: Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/#review121231 --- Ship it! Ship It! - Jan Schlicht On Feb. 29, 2016, 12:37 p.m

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review121229 --- Patch looks great! Reviews applied: [43561] Passed command: expo

Re: Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/ --- (Updated Feb. 29, 2016, 12:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/#review121224 --- src/tests/state_tests.cpp (line 404)

Re: Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/ --- (Updated Feb. 29, 2016, 11:53 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review121222 --- Ship it! Ship It! - Michael Park On Feb. 18, 2016, 2:24 a.m.

Re: Review Request 42590: Removed reserved() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review121220 --- Patch looks great! Reviews applied: [42590] Passed command: expo

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated Feb. 29, 2016, 5:57 p.m.) Review request for mesos and Ben Mahler. C

Review Request 44163: Used temporary directory for fixture creating output files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44163/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Bugs: MESOS-4806

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review121219 --- 3rdparty/CMakeLists.txt (line 36)

Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 29, 2016, 1:42 a.m., Shuai Lin wrote: > > src/launcher/http_executor.cpp, line 82 > > > > > > Maybe we should also add some tests that launches tasks with this new > > http cmd executor? Yes, agree! - Qi

Re: Review Request 43701: Added a command executor based on the new V1 API.

> On Feb. 29, 2016, 10:24 a.m., Vinod Kone wrote: > > Thanks for working on this Qian! > > > > It's really hard to tell what changes were made to the http command > > executor that are different from the command executor. I would suggest you > > to split this into multiple reviews to make revi

Re: Review Request 42590: Removed reserved() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- (Updated 二月 29, 2016, 9:11 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 44096: Fixed assignment line wrapping in style guide example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44096/#review121216 --- Ship it! Ship It! - Till Toenshoff On Feb. 26, 2016, 6:49 p.

Re: Review Request 42590: Removed reserved() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/#review121213 --- Bad patch! Reviews applied: [42590] Failed command: ./support/ap

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review121211 --- Sorry about the premature `ShipIt`. Upon inspection of the local g

Re: Review Request 43634: Consistent markdown code style in persistent-volumes.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43634/#review121210 --- docs/persistent-volume.md (lines 82 - 106)