Review Request 44513: Added missing flag to authentication docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44513/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Review Request 44512: Support to get weights info by /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- Review request for mesos and Adam B. Bugs: MESOS-4316

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 8, 2016, 10:42 p.m.) Review request for mesos, Avinash

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122520 --- Patch looks great! Reviews applied: [43824] Passed command:

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/ --- (Updated March 8, 2016, 2:22 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 2:08 p.m.) Review request for mesos, Michael Park,

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 2:05 p.m.) Review request for mesos, Michael Park,

Review Request 44511: Add registry tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- Review request for mesos and Adam B. Bugs: MESOS-4797

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:33 p.m.) Review request for mesos, Michael Park,

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:24 p.m.) Review request for mesos, Michael Park,

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:29 p.m.) Review request for mesos, Michael Park,

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:19 p.m.) Review request for mesos, Michael Park,

Re: Review Request 42719: Add doc for weights.

> On March 8, 2016, 9:19 a.m., Adam B wrote: > > docs/weights.md, lines 22-23 > > > > > > This will have to be updated when we add GET I will update this doc for GET request after addressing #MESOS-4316. -

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/ --- (Updated March 8, 2016, 1:05 p.m.) Review request for mesos, Adam B and

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122507 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated March 8, 2016, 12:47 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On March 8, 2016, 8:07 a.m., Adam B wrote: > > src/master/master.hpp, lines 1040-1042 > > > > > > So if I try to update N roles in one request, but I am not authorized > > to update 1, then I would get back a

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 12:29 p.m.) Review request for mesos, Michael Park,

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 8, 2016, 12:10 p.m.) Review request for mesos, Adam B and

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review122504 --- Ship it! Ship It! - Bernd Mathiske On March 4, 2016, 3:55

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122502 --- Fix it, then Ship it!

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

> On March 4, 2016, 6:55 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 61 > > > > > > Add a `+` at the end. While not necessary, makes it more readable. > > Qian

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 8, 2016, 11:27 a.m.) Review request for mesos and Adam B.

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

> On March 4, 2016, 6:45 a.m., Bernd Mathiske wrote: > > > > Joseph Wu wrote: > I also noticed a couple of these: > ``` > MesosSchedulerDriver driver( > , DEFAULT_FRAMEWORK_INFO, master.get()->pid, > DEFAULT_CREDENTIAL); > ``` > Now fixed (there were two spaces

Re: Review Request 43824: Addressed comments of 41672.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122494 --- Fix it, then Ship it! Just a bunch a grammar fixes. Otherwise

Re: Review Request 43824: Addressed comments of 41672.

> On March 3, 2016, 1:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2607-2609 > > > > > > I'm an ESL, but having both "per weight" and "by weight" sounds a bit > >

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review122493 --- Fix it, then Ship it! src/master/weights.hpp (line 35)

Re: Review Request 43863: Move the implementation of updateWeights out of header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review122490 --- Ship it! Ship It! - Adam B On Feb. 27, 2016, 4:43 a.m.,

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122488 --- Fix it, then Ship it! docs/weights.md (lines 51 - 53)

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122487 --- Patch looks great! Reviews applied: [1] Passed command:

Re: Review Request 43798: Added overview section to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 8:13 a.m.) Review request for mesos, Michael Park,

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review122479 --- Fix it, then Ship it! Would love to commit this asap, but we

<    1   2