Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- Review request for mesos and haosdent huang. Repository: mesos Description --

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 15, 2016, 6:18 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 15, 2016, 6:16 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/#review123604 --- include/mesos/mesos.proto (line 626)

Review Request 44834: Documented task, executor, and volume IDs reuse is discouraged.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44834/ --- Review request for mesos and Jie Yu. Bugs: MESOS-2198 https://issues.apache

Re: Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44828/#review123603 --- Patch looks great! Reviews applied: [44798, 44822, 44823, 44824,

Review Request 44832: Validate string when convert `Flags` to `hashmap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44832/ --- Review request for mesos, Adam B, Ben Mahler, and Kevin Klues. Bugs: MESOS-2023

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/#review123593 --- Patch looks great! Reviews applied: [44380] Passed command: expo

Re: Review Request 44652: Omitted names of unused parameters in command executor.

> On March 10, 2016, 5:56 p.m., Joerg Schad wrote: > > src/launcher/executor.cpp, line 124 > > > > > > Not sure whether we have a real style for that, but the example I seen > > (and used myself) are to comment the

Re: Review Request 44651: Fixed formatting in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44651/#review123588 --- src/exec/exec.cpp (line 364)

Re: Review Request 44650: Omitted names of unused parameters in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44650/#review123587 --- src/exec/exec.cpp (line 206)

Re: Review Request 43763: Passed `Duration` as const reference in the executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43763/#review123586 --- Ship it! s/library/driver/ - Ben Mahler On March 14, 2016, 5

Re: Review Request 44635: Corrected the log message and variable name in executor library.

> On March 15, 2016, 3:13 a.m., Ben Mahler wrote: > > Just a minor tweak that I'll apply. We refer to this as the executor driver rather than the executor library, I'll use the following commit message: Minor environment variable parsing cleanup in executor driver. - Ben --

Re: Review Request 44635: Corrected the log message and variable name in executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44635/#review123584 --- Fix it, then Ship it! Just a minor tweak that I'll apply. src

Re: Review Request 44777: Added a flags parser for vector to src/common/parse.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/ --- (Updated March 15, 2016, 3:11 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44634: Updated the log message in the HTTP API executor library.

> On March 15, 2016, 3:08 a.m., Ben Mahler wrote: > > Ship It! I'll update the description to mention that this is consistent with the executor driver's log format. - Ben --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

> On March 11, 2016, 11:43 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/spec.proto, line 46 > > > > > > Can we list the required field before the optional fields? We can keep > >

Re: Review Request 44634: Updated the log message in the HTTP API executor library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44634/#review123582 --- Ship it! Ship It! - Ben Mahler On March 14, 2016, 5:45 p.m.,

Re: Review Request 44631: Cleaned up the comment around executor shutdown event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44631/#review123581 --- Ship it! Thanks, also two thoughts for later: (1) I assume you

Re: Review Request 44777: Added a flags parser for vector to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/#review123573 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp

Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44630/#review123574 --- Ship it! Would be great to include some description in these re

Re: Review Request 44777: Added a flags parser for vector to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44777/ --- (Updated March 15, 2016, 2:23 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44628: Fixed a comment and ordering in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44628/#review123570 --- Ship it! Ship It! - Ben Mahler On March 14, 2016, 5:44 p.m.,

Re: Review Request 44629: Fixed ordering and inconsistencies in slave constants.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44629/#review123571 --- Ship it! Ship It! - Ben Mahler On March 14, 2016, 5:44 p.m.,

Re: Review Request 44627: Removed a stale comment in the 1.0 mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44627/#review123569 --- Ship it! Ship It! - Ben Mahler On March 14, 2016, 5:44 p.m.,

Re: Review Request 44626: Fixed whitespaces in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44626/#review123568 --- Ship it! Ship It! - Ben Mahler On March 14, 2016, 5:44 p.m.,

Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44828/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44826/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Review Request 44825: Remove `SlaveState` in `ExternalContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44825/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Review Request 44824: Remove `SlaveState` in `ComposingContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44824/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --

Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44822/ --- Review request for mesos. Repository: mesos Description --- Remove `Slav

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated March 15, 2016, 2:02 a.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

> On March 14, 2016, 8:53 a.m., Benjamin Bannier wrote: > > Looks mostly good to me. I left some comments, but if you want to make any > > progress here you'll still need to find a shepherd (see > > http://mesos.apache.org/documentation/latest/submitting-a-patch/). > > Yong Tang wrote: > T

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44380/ --- (Updated March 15, 2016, 1:38 a.m.) Review request for mesos and Benjamin Banni

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 12, 2016, 4:02 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/#review123561 --- src/tests/containerizer/runtime_isolator_tests.cpp (lines 93 - 95

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

> On 三月 15, 2016, 12:58 a.m., Guangya Liu wrote: > > @Gilbert, can you please show some detail in commit messsage to descrbe how > > does the fix resolve the out of disk issue? Thanks. I saw that you just filed a JIRA and show some explantaion there, thanks! - Guangya --

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/#review123553 --- @Gilbert, can you please show some detail in commit messsage to de

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 12, 2016, 3:28 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44753: Fixed runtime isolator tests out of disk issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44753/ --- (Updated March 14, 2016, 5:22 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 44545: Separated standalone and zookeeper classes.

> On March 11, 2016, 9:42 p.m., Joseph Wu wrote: > > src/master/detectors/standalone.cpp, lines 58-60 > > > > > > I don't see where these helpers are deleted in your later reviews. This may have happened during one o

Re: Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/#review123541 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:10 p.m., Ale

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 14, 2016, 11:49 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44670: Added master_detector and master_contender flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44670/ --- (Updated March 14, 2016, 11:53 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 14, 2016, 11:52 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- (Updated March 14, 2016, 11:52 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 14, 2016, 11:52 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 14, 2016, 11:51 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/#review123540 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:12 p.m., Ale

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 14, 2016, 11:51 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44544: Moved contender and detector definitions into separate directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- (Updated March 14, 2016, 11:50 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 14, 2016, 11:50 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review123538 --- src/common/resources.cpp (line 187)

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 14, 2016, 11:48 p.m.) Review request for mesos and Benjamin Hind

Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review123536 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:06 p.m., Ale

Re: Review Request 44808: Fixup POSIX build by removing headers from load.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/#review123535 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 9:06 p.m., Ale

Re: Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/#review123537 --- Ship it! Ship It! - Yi Sun On March 14, 2016, 8:48 p.m., Ale

Re: Review Request 44708: Fixed signed / unsigned comparison in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44708/#review123534 --- Ship it! Ship It! - Timothy Chen On March 14, 2016, 5:50 p.m

Re: Review Request 44439: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44439/#review123529 --- As mentioned in https://reviews.apache.org/r/44476/ this patch sho

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44661/#review123533 --- src/slave/flags.cpp (line 531)

Re: Review Request 44797: Updated libprocess makefile to include device_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44797/#review123486 --- The order of reviewboard dependencies is wrong in this patch. Thi

Re: Review Request 44796: Added helper classes for cgroups device entry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44796/#review123505 --- This commit and https://reviews.apache.org/r/44439/ should probabl

Re: Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44710/#review123532 --- Ship it! LGTM. - Anand Mazumdar On March 14, 2016, 1:35 p.m.

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

> On March 14, 2016, 8:28 a.m., Adam B wrote: > > 3rdparty/libprocess/src/help.cpp, line 43 > > > > > > What if this was a bool instead of a string? How many values do you > > expect? I agree that we should be able

Re: Review Request 44767: Added authentication information to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44767/#review123522 --- docs/endpoints/master/create-volumes.md (line 24)

Re: Review Request 44734: Marked a few internal functions `static`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44734/#review123521 --- Ship it! Ship It! - Michael Park On March 12, 2016, 12:29 a.

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/#review123515 --- Ship it! src/master/http.cpp (line 1950)

Re: Review Request 44439: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44439/#review123519 --- Bad patch! Reviews applied: [44439, 44796, 44797] Failed command

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review123517 --- Qian, any updates on this? - Anand Mazumdar On March 6, 2016, 9

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 8:02 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.hpp, line 85 > > > > > > I would suggest we have a `Info` for each container. > > > > ``` > > struct I

Re: Review Request 44733: Added fault tolerance tests for the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44733/ --- (Updated March 14, 2016, 10:14 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 10 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 9:58 p.m.) Review request for mesos, Adam B, Alexander

Review Request 44810: Documentation change for the update quota feature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44810/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Michael

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 14, 2016, 2:33 p.m.) Review request for mesos, Bernd Mathiske an

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 14, 2016, 2:32 p.m.) Review request for mesos, Bernd Mathiske an

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 14, 2016, 2:32 p.m.) Review request for mesos, Bernd Mathiske an

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/ --- (Updated March 14, 2016, 2:31 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44081: Stout: Moved `os::libraries::` namespace back to `stout/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44081/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Review Request 44808: Fixup POSIX build by removing headers from load.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44808/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 44798: [WIP]Remove SlaveState in containerizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/#review123509 --- Bad patch! Reviews applied: [44798] Failed command: ./support/ap

Review Request 44080: Windows:[1/2] Implemented `os::gmtime_r`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44080/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 11, 2016, 6:19 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > > t

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

> On March 11, 2016, 7:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, lines 73-77 > > > > > > I think the CNI plugin should also support the case where the user does > > not speci

Re: Review Request 44439: Added device support in cgroups abstraction.

> On March 9, 2016, 1:58 a.m., Ben Mahler wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 1278-1309 > > > > > > Does this test pass? Did you make sure this test ran? Note that you > > have to run the te

Re: Review Request 44709: Allowed unknown flags in command and docker executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44709/#review123495 --- Patch looks great! Reviews applied: [44626, 44627, 44628, 44629,

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44583/#review123478 --- The generated documentation is now wrong. It almost loooks like n

  1   2   3   >