Re: Review Request 45932: Adds task information to container resource usage information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/#review128340 --- Patch looks great! Reviews applied: [45572, 45932] Passed

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/ --- (Updated 四月 12, 2016, 5:20 a.m.) Review request for mesos, Guangya Liu, Neil

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

> On 四月 7, 2016, 10:13 p.m., Neil Conway wrote: > > docs/persistent-volume.md, line 296 > > > > > > Replace "Returns `202 ACCEPTED` which" with "This endpoint returns the > > `202 ACCEPTED` HTTP status code, which

Re: Review Request 45932: Adds task information to container resource usage information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/ --- (Updated April 12, 2016, 5:03 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45932: Adds task information to container resource usage information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/ --- (Updated April 12, 2016, 5:03 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45932: Add stripped TaskInfo's to ResourceUsage.Executor message.

> On April 9, 2016, 12:27 a.m., Ben Mahler wrote: > > include/mesos/mesos.proto, line 1032 > > > > > > Can we omit this? Why did you include it? I'll drop this as I don't have a good reason to use it for now. The

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

> On April 9, 2016, 9:02 a.m., Guangya Liu wrote: > > You may want to rebase this patch for dynamic_reservation_framework.cpp as > > well. Yes, done. - Anindya --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated April 12, 2016, 5 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45932: Add stripped TaskInfo's to ResourceUsage.Executor message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45932/ --- (Updated April 12, 2016, 5 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45572/ --- (Updated April 12, 2016, 4:59 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/#review128319 --- Ship it! Ship It! - Ben Mahler On April 11, 2016, 2:36

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 12, 2016, 2:13 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

> On April 11, 2016, 7 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 198 > > > > > > Please stick to our style guide by moving '{' to the next line. Removed this

Re: Review Request 45955: Added CNI helper subcommand to `mesos-containerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/ --- (Updated April 12, 2016, 2:10 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45954/ --- (Updated April 12, 2016, 2:09 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

> On April 11, 2016, 2:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46003: Removed the default value for agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/#review128278 --- src/local/local.cpp (line 353)

Re: Review Request 46053: Added logic to validate for non-fractional GPU requests in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46053/#review128310 --- Ship it! Ship It! - Ben Mahler On April 11, 2016, 10:11

Re: Review Request 45969: Fixed indent in Nvidia GPU test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45969/#review128309 --- Ship it! Ship It! - Ben Mahler On April 11, 2016, 10:19

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45970/#review128307 --- Ship it!

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

> On April 11, 2016, 9:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

> On April 11, 2016, 2:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > > > > > I like the idea of simplifying the ctor. I am not too excited about the > > idea of moving everything to 'flag'. A

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45927/#review128305 --- Ship it! LGTM, modulo the patch-applying issue ReviewBot has.

Re: Review Request 46027: Documented `libprocess` helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/ --- (Updated April 12, 2016, 12:23 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46027: Documented `libprocess` helper function.

> On April 11, 2016, 9:55 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 559-562 > > > > > > Hm.. this may be a bit confusing for those without context. A > > libprocess message can be sent

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

> On April 11, 2016, 10:44 p.m., Ben Mahler wrote: > > Mind doing a sweep for this? I noticed a few more candidates in `futures_test.cpp` and added them to the RR; I didn't try to look beyond the libprocess tests. - Neil --- This is

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46029/ --- (Updated April 12, 2016, 12:13 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45970/#review128298 --- Patch looks great! Reviews applied: [45969, 46053, 45970]

Re: Review Request 46028: Improved comments in SocketManager::next().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/ --- (Updated April 11, 2016, 11:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46028: Improved comments in SocketManager::next().

> On April 11, 2016, 10:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 1947-1954 > > > > > > The implication of this comment (regardless of your changes) seems to > > be that the socket

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

> On April 8, 2016, 6:10 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > > > > > Might be nice to note that this is ignored if `flags.shell` is false. > > Alexander Rukletsov wrote: > It's true

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

> On April 8, 2016, 11:10 a.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > > > > > Might be nice to note that this is ignored if `flags.shell` is false. > > Alexander Rukletsov wrote: > It's true

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

> On April 9, 2016, 2:32 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 157 > > > > > > I can see many people ask the format of `time` in user list, it would > > be great if we can list all supported unit

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

> On April 9, 2016, 2:24 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 100 > > > > > > I think we cannot sepcify the entrypoint for container here, the > > entrypoint was runtime configuration and was get

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/ --- (Updated April 11, 2016, 10:57 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 46053: Added logic to validate for non-fractional GPU requests in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46053/#review128277 --- Patch looks great! Reviews applied: [45969, 46053] Passed

Re: Review Request 45731: Introduced '--networks' flag to mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45731/#review128276 --- src/cli/execute.cpp (line 488)

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46029/#review128274 --- Mind doing a sweep for this?

Re: Review Request 46028: Improved comments in SocketManager::next().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46028/#review128267 --- 3rdparty/libprocess/src/process.cpp (lines 1813 - 1816)

Re: Review Request 45956: Added the `_isolate` method.

> On April 11, 2016, 7:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 762 > > > > > > I don't think 'realpath' is necessary here. Will remove `realpath`. What should

Re: Review Request 45969: Fixed indent in Nvidia GPU test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45969/ --- (Updated April 11, 2016, 10:19 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45970: Added Nvidia GPU test to verify error when requesting fractional GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45970/ --- (Updated April 11, 2016, 10:18 p.m.) Review request for mesos, Ben Mahler, Rob

Review Request 46053: Added logic to validate for non-fractional GPU requests in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46053/ --- Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya. Bugs:

Re: Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/#review128271 --- Mind adding joris and/or benh as reviewers? I'm happy to review

Re: Review Request 46027: Documented `libprocess` helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/#review128266 --- 3rdparty/libprocess/src/process.cpp (lines 559 - 562)

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/#review128265 --- src/cli/execute.cpp

Re: Review Request 46026: Documented `Socket::shutdown()` member function in libprocess.

> On April 11, 2016, 9:46 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/socket.hpp, lines 176-187 > > > > > > Why don't we instead take the "`int how`" as an argument and make the > > SHUT_RD

Re: Review Request 46026: Documented `Socket::shutdown()` member function in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46026/#review128261 --- 3rdparty/libprocess/include/process/socket.hpp (lines 176 - 187)

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/#review128259 --- Looks good, just some food for thought and a question related to

Re: Review Request 46030: Used initializer_list for collections in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46030/#review128255 --- Fix it, then Ship it! Hm.. ideally there should not have been

Re: Review Request 46005: Updated agent work_dir references to Option type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46005/ --- (Updated April 11, 2016, 9:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46003: Removed the default value for agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated April 11, 2016, 9:06 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/ --- (Updated April 11, 2016, 9:10 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 45562: Edited `--work_dir` configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated April 11, 2016, 9:09 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 46004: Updated master '--work_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- (Updated April 11, 2016, 9:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/ --- (Updated April 11, 2016, 9:05 p.m.) Review request for mesos, Jie Yu and Neil

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/#review128246 --- Bad patch! Reviews applied: [46044, 45927, 45926, 45925] Failed

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46029/ --- (Updated April 11, 2016, 9:01 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46030: Used initializer_list for collections in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46030/ --- (Updated April 11, 2016, 9:01 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45563: Added recommended config for production to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45563/ --- (Updated April 11, 2016, 8:39 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review128232 --- docs/endpoints/index.md

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/#review128238 --- Bad patch! Reviews applied: [46038, 45562, 46004, 46005, 46003]

Re: Review Request 46024: Avoided misleading locking in the libprocess SocketManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46024/#review128220 --- Patch looks great! Reviews applied: [46025, 46026, 46027, 46028,

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review128216 --- src/cli/execute.cpp (line 306)

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 11, 2016, 7:19 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45985: Fixed the commit message hook to use `echo -n` instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45985/#review128213 --- Ship it! Ship It! - Kevin Klues On April 10, 2016, 6:43

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128211 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Review Request 46044: Cleaned up c-tor signature in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46044/ --- Review request for mesos, Anand Mazumdar and Joseph Wu. Repository: mesos

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

> On April 8, 2016, 6:14 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 639-651 > > > > > > Given how these flags are pretty much all passed into the > > `CommandScheduler`, can you add another patch that

Re: Review Request 45954: Added `subcommand` to `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45954/#review128168 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45926/ --- (Updated April 11, 2016, 7 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 45925: Extended logging for task status updates in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45925/ --- (Updated April 11, 2016, 6:59 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45572: Add labels to ExecutorInfo and deprecate source.

> On April 9, 2016, 12:16 a.m., Ben Mahler wrote: > > Looks pretty good, thanks! > > > > Could you also add tests that mirror the task label tests? > > > > ``` > > $ grep -R TEST src/tests | grep TaskLabels > > src/tests/master_tests.cpp:TEST_F(MasterTest, TaskLabels) > >

Re: Review Request 46023: Cleaned up dynamic reservation example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46023/#review128192 --- Ship it! Ship It! - Michael Park On April 11, 2016, 2 p.m.,

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45085/ --- (Updated April 11, 2016, 6:27 p.m.) Review request for mesos, Gilbert Song,

Review Request 46043: Completed default implementation of `Subsystem` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46043/ --- Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/ --- (Updated April 11, 2016, 6:26 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45905: Added metrics to the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated April 11, 2016, 11:24 a.m.) Review request for mesos, Greg Mann,

Re: Review Request 45604: Updated the balloon framework and executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/ --- (Updated April 11, 2016, 11:24 a.m.) Review request for mesos, Greg Mann,

Re: Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/#review128181 --- Providing recommended values without justifying why they are

Re: Review Request 46042: Fixed line commit message length check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46042/#review128189 --- Ship it! Ship It! - Michael Park On April 11, 2016, 6:06

Review Request 46042: Fixed line commit message length check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46042/ --- Review request for mesos, Artem Harutyunyan and Michael Park. Repository:

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

> On April 11, 2016, 4:48 p.m., Benjamin Bannier wrote: > > support/hooks/commit-msg, lines 26-27 > > > > > > Not part of this patch, but since we `wc` here we manually need to > > correct for it counting the

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

> On April 11, 2016, 3:19 p.m., Alexander Rukletsov wrote: > > Could you please briefly explain the problem with the globbing in the > > description? > > > > Btw, I was unaware of that patch and filed > > https://reviews.apache.org/r/46034/ . I'll discard it in favour of your > > patch. I

Re: Review Request 45984: Fixed the commit message hook to wrap the variables in quotes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45984/ --- (Updated April 11, 2016, 5:45 p.m.) Review request for mesos, Joerg Schad,

Re: Review Request 45955: Added CNI helper binary `mesos-cni-helper`.

> On April 11, 2016, 5:02 p.m., Jie Yu wrote: > > Instead of creating a new helper binary, can we use the mesos-containerizer > > binary? > > > > We need to namespace the subcommand properly to avoid conflicts. We can use > > 'network-cni-setup' as the name of the subcommand. > > Avinash

Review Request 46038: Added recommended production config to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46038/ --- Review request for mesos, Jie Yu and Neil Conway. Bugs: MESOS-5064

Re: Review Request 45955: Added CNI helper binary `mesos-cni-helper`.

> On April 11, 2016, 5:02 p.m., Jie Yu wrote: > > Instead of creating a new helper binary, can we use the mesos-containerizer > > binary? > > > > We need to namespace the subcommand properly to avoid conflicts. We can use > > 'network-cni-setup' as the name of the subcommand. So just add a

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45927/ --- (Updated April 11, 2016, 4:54 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45955: Added CNI helper binary `mesos-cni-helper`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/#review128161 --- Instead of creating a new helper binary, can we use the

Re: Review Request 45562: Edited `--work_dir` configuration docs.

> On March 31, 2016, 10:16 p.m., Joerg Schad wrote: > > docs/configuration.md, line 354 > > > > > > Not yours but why isn't that flag in the common master/agent section > > above? I decided to put the work_dir

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45927/ --- (Updated April 11, 2016, 4:55 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 45927: Introduced kill task delay in mesos-execute.

> On April 9, 2016, 2:32 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 157 > > > > > > I can see many people ask the format of `time` in user list, it would > > be great if we can list all supported unit

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

> On April 8, 2016, 6:10 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 97-100 > > > > > > Might be nice to note that this is ignored if `flags.shell` is false. It's true for the _current_ code in

Re: Review Request 45926: Cleaned up flag descriptions in mesos-execute.

> On April 9, 2016, 2:24 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 100 > > > > > > I think we cannot sepcify the entrypoint for container here, the > > entrypoint was runtime configuration and was get

Re: Review Request 46015: Stout:[2/2] Moved process tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46015/#review128152 --- Bad patch! Reviews applied: [46015, 46014, 46013, 46012, 43985]

Re: Review Request 45562: Edited `--work_dir` configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated April 11, 2016, 4:38 p.m.) Review request for mesos, Jie Yu and Neil

Review Request 46004: Updated master '--work_dir' help string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5064

Review Request 46005: Updated agent work_dir references to Option type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46005/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5064

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 4:28 p.m.) Review request for mesos and Jie Yu.

  1   2   >