Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/#review132124 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review132122 --- Patch looks great! Reviews applied: [47082] Passed command: expo

Re: Review Request 47080: Agent should backoff when establishing a socket.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47080/#review132119 --- Patch looks great! Reviews applied: [47080] Passed command: expo

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/ --- (Updated 五月 7, 2016, 2:59 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/ --- (Updated 五月 7, 2016, 2:44 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-05-06 Thread Qian Zhang
> On May 7, 2016, 1:34 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 42 > > > > > > Instead of using a script here, can we use code to get ip network and > > name server information? >

Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

2016-05-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5143 https://issues.

Re: Review Request 45562: Edited `--work_dir` configuration docs.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45562/ --- (Updated May 7, 2016, 1:29 a.m.) Review request for mesos and Michael Park. B

Re: Review Request 46004: Updated master '--work_dir' help string.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46004/ --- (Updated May 7, 2016, 1:29 a.m.) Review request for mesos and Michael Park. B

Re: Review Request 46005: Updated references to agent work_dir to Option type.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46005/ --- (Updated May 7, 2016, 1:29 a.m.) Review request for mesos and Jie Yu. Bugs: M

Re: Review Request 46003: Removed the default value for agent work_dir.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46003/ --- (Updated May 7, 2016, 1:28 a.m.) Review request for mesos, Michael Park and Vin

Re: Review Request 47078: Added checking for required flags to FlagsBase.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/ --- (Updated May 7, 2016, 1:27 a.m.) Review request for mesos and Michael Park. C

Re: Review Request 46882: Added a LoggingTest with authorization.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/#review132117 --- Patch looks great! Reviews applied: [46866, 46867, 46883, 46869,

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/#review132114 --- Bad patch! Reviews applied: [47062, 47061] Failed command: ./sup

Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/#review132113 --- Patch looks great! Reviews applied: [46613, 47068, 47069, 47070,

Re: Review Request 47080: Agent should backoff when establishing a socket.

2016-05-06 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47080/#review132111 --- Ship it! Ship It! - Cong Wang On May 6, 2016, 10:51 p.m., Da

Re: Review Request 47080: Agent should backoff when establishing a socket.

2016-05-06 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47080/ --- (Updated May 6, 2016, 10:51 p.m.) Review request for mesos, Ben Mahler, Ian Dow

Review Request 47080: Agent should backoff when establishing a socket.

2016-05-06 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47080/ --- Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang. Bugs: MESOS-53

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/#review132106 --- Bad patch! Reviews applied: [46799, 46798, 46371, 46370, 46369]

Re: Review Request 47078: Added checking for required flags to FlagsBase.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/ --- (Updated May 6, 2016, 9:48 p.m.) Review request for mesos and Michael Park. B

Review Request 47078: Added checking for required flags to FlagsBase.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/ --- Review request for mesos and Michael Park. Bugs: MESOS-5064 https://issues.

Re: Review Request 46990: Removed authorization from libprocess endpoint handlers.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46990/ --- (Updated May 6, 2016, 9:21 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/ --- (Updated May 6, 2016, 9:20 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-06 Thread Greg Mann
> On May 6, 2016, 6:01 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/src/process.cpp, lines 3346-3355 > > > > > > Can we simplify the logic a bit here and add some explanation? This review was merged into https:/

Re: Review Request 46882: Added a LoggingTest with authorization.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/ --- (Updated May 6, 2016, 9:18 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46881/ --- (Updated May 6, 2016, 9:17 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46880: Added authorization to '/logging/toggle'.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46880/ --- (Updated May 6, 2016, 9:17 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46870: Added MetricsTests with authorization.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46870/ --- (Updated May 6, 2016, 9:16 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/ --- (Updated May 6, 2016, 9:16 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/ --- (Updated May 6, 2016, 9:17 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/ --- (Updated May 6, 2016, 9:16 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

2016-05-06 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/ --- (Updated May 6, 2016, 9:16 p.m.) Review request for mesos, Adam B, Greg Mann, a

Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46868/ --- (Updated May 6, 2016, 9:15 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/ --- (Updated May 6, 2016, 9:14 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

2016-05-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/ --- (Updated May 6, 2016, 9:13 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/#review132100 --- Patch looks great! Reviews applied: [46096, 46097, 46435, 46436,

Re: Review Request 46730: Cleanup syscalls logic.

2016-05-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review132098 --- Ship it! Ship It! - Ben Mahler On April 29, 2016, 1:03 p.m.,

Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.

2016-05-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/ --- Review request for mesos, Adam B, Alexander Rojas, and Michael Park. Repository

Review Request 47070: Added framework filtering to /state-summary endoint.

2016-05-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47070/ --- Review request for mesos, Adam B, Alexander Rojas, and Michael Park. Repository

Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/ --- Review request for mesos, Adam B, Alexander Rojas, and Michael Park. Repository

Review Request 47068: Added fine-grained filtering master flag.

2016-05-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47068/ --- Review request for mesos, Adam B, Alexander Rojas, and Michael Park. Repository

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 6, 2016, 8:28 p.m.) Review request for mesos, Adam B, Alexander Ro

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/#review132096 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46369/#review132086 --- include/mesos/mesos.proto (line 1737)

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132092 --- Patch looks great! Reviews applied: [46923] Passed command: expo

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-06 Thread Kapil Arya
> On May 6, 2016, 3:37 a.m., Adam B wrote: > > Please create a JIRA with motivation for this hook. I don't want a new hook > > to slip into a release without a JIRA in the changelog to document it. Good point. I meant to add it to the RR, but it slipped :-). - Kapil

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

2016-05-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/#review132085 --- 3rdparty/libprocess/src/process.cpp (lines 3299 - 3308)

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-05-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review132084 --- src/tests/containerizer/cni_isolator_tests.cpp (line 42)

Re: Review Request 39474: Added test "ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes".

2016-05-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/#review132075 --- Fix it, then Ship it! src/tests/containerizer/docker_volume_is

Re: Review Request 47062: Modified testcase for testing authentication on '/containers' endpoint.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/#review132074 --- Bad patch! Reviews applied: [47062, 47061] Failed command: ./sup

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-06 Thread Jojy Varghese
> On April 29, 2016, 12:19 a.m., Qian Zhang wrote: > > src/cli/execute.cpp, lines 172-175 > > > > > > Can we only add this flag in Linux? Then user will not see this flag at > > all when running `mesos-execute` in o

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46799/ --- (Updated May 6, 2016, 5:06 p.m.) Review request for mesos and Jie Yu. Reposit

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46798/ --- (Updated May 6, 2016, 5:05 p.m.) Review request for mesos and Jie Yu. Reposit

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 6, 2016, 5:03 p.m.) Review request for mesos, Jie Yu and Kevin Klu

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46369/ --- (Updated May 6, 2016, 5:02 p.m.) Review request for mesos and Jie Yu. Bugs: M

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46874/#review132069 --- Patch looks great! Reviews applied: [46874] Passed command: expo

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review132065 --- Ship it! Ship It! - haosdent huang On May 6, 2016, 3:18 a.m.

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47056/#review132064 --- Ship it! Ship It! - haosdent huang On May 6, 2016, 6:26 a.m.

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

2016-05-06 Thread haosdent huang
> On May 6, 2016, 4:29 p.m., haosdent huang wrote: > > support/docker_build.sh, line 60 > > > > > > I think need update the `docs/getting-started.md`. Oh, you have already updated it in https://reviews.apache.org/r/4

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47056/#review132061 --- support/docker_build.sh (line 60)

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47058/#review132055 --- Do you forgot to update `src/webui/master/static/browse.html` in t

Re: Review Request 46975: Add title and heading in Mesos Log Page.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46975/#review132051 --- Fix it, then Ship it! Ship It! src/webui/master/static/pailer

Re: Review Request 46966: Added associated labels to form in webui

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/#review132050 --- Fix it, then Ship it! Ship It! src/webui/master/static/direct

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-06 Thread haosdent huang
> On May 6, 2016, 3:24 p.m., haosdent huang wrote: > > src/webui/master/static/index.html, line 22 > > > > > > +1 For use `banner` :-) Use `banner` is more boostrap style. - haosdent -

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-06 Thread haosdent huang
> On May 6, 2016, 3:24 p.m., haosdent huang wrote: > > I think also need 1. Update the bug field to jira ticket 2. Description should be limited in 72 characters. - haosdent --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46965/#review132041 --- src/webui/master/static/css/mesos.css (line 5)

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review132042 --- Patch looks great! Reviews applied: [46373] Passed command: expo

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/#review132032 --- Hi, @lichenn. Thanks a lot for your patch! Here are some my commen

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-05-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/ --- (Updated May 6, 2016, 10:09 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46436/ --- (Updated May 6, 2016, 10:08 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

2016-05-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/ --- (Updated May 6, 2016, 10:07 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-05-06 Thread Qian Zhang
> On May 6, 2016, 5:29 a.m., Jie Yu wrote: > > This test failed on my machine: > > > > ``` > > E0505 14:28:48.309273 42478 slave.cpp:3995] Container > > '33dc5d83-125f-4da2-8c69-cba76d95955b' for executor > > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework > > 9ecf5fd8-ad54-4973-9688-bcc6

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-05-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated May 6, 2016, 10:06 p.m.) Review request for mesos, Avinash sridharan a

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46761/#review132024 --- Patch looks great! Reviews applied: [46761] Passed command: expo

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/#review132022 --- Ship it! Ship It! - Neil Conway On May 6, 2016, 8:57 a.m., C

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/ --- (Updated 五月 6, 2016, 12:40 p.m.) Review request for mesos, Gilbert Song and Jie

Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/ --- Review request for mesos, Gilbert Song and Jie Yu. Summary (updated) --

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 6, 2016, 12:09 p.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132017 --- src/master/master.cpp (line 1387)

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 6, 2016, 12:03 p.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 39474: Added test "ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes".

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/#review132011 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

2016-05-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review132008 --- include/mesos/authorizer/acls.proto (line 168)

Review Request 47062: Modified testcase for testing authentication on '/containers' endpoint.

2016-05-06 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47062/ --- Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. Bugs: MESOS-53

Review Request 47061: Authenticated the agent's '/containers' endpoint.

2016-05-06 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47061/ --- Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. Bugs: MESOS-53

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47054/#review132007 --- Patch looks great! Reviews applied: [47052, 47053, 47054] Passed

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47055/ --- (Updated 五月 6, 2016, 8:58 a.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/ --- (Updated 五月 6, 2016, 8:57 a.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47058/ --- (Updated 五月 6, 2016, 8:57 a.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/ --- (Updated 五月 6, 2016, 8:56 a.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 46964: Using the summary attribute of the table element.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/ --- (Updated 五月 6, 2016, 8:52 a.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132003 --- Fix it, then Ship it! src/master/master.cpp (line 1386)

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47058/ --- (Updated 五月 6, 2016, 8:12 a.m.) Review request for mesos, Zhiwei Chen and haosd

Re: Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47058/ --- (Updated 五月 6, 2016, 8:07 a.m.) Review request for mesos, Zhiwei Chen and haosd

Review Request 47058: Fix accessibility of table in web GUI.

2016-05-06 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47058/ --- Review request for mesos. Repository: mesos Description --- Fix accessib

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 五月 6, 2016, 8:04 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/#review132000 --- Patch looks great! Reviews applied: [42386] Passed command: expo

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131997 --- Please create a JIRA with motivation for this hook. I don't want a