Re: Review Request 47324: Update leveldb to 1.18.

2016-05-15 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133327 --- Ship it! I tested on ppc64le with ssl and libevent enabled, it

Review Request 44209: Closed the input ifstream before return error.

2016-05-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44209/ --- Review request for mesos, Gilbert Song, Jie Yu, and Timothy Chen. Repository:

Re: Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47404/#review133324 --- Patch looks great! Reviews applied: [47052, 47053, 47221, 47054,

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47055/#review133321 --- Patch looks great! Reviews applied: [47055] Passed command:

Review Request 47404: Stout: Implemented `HANDLE` versions of file descriptor functions.

2016-05-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47404/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

2016-05-15 Thread Chen Nan Li
> On 五月 13, 2016, 2:58 p.m., haosdent huang wrote: > > src/webui/master/static/directives/tableHeader.html, line 3 > > > > > > Seems `id` here is unnecessary, I think could remove it. > > > > ``` > >

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

2016-05-15 Thread Chen Nan Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47055/ --- (Updated 五月 16, 2016, 2:47 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 47208: Fixed mesos test installation build.

2016-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/#review133315 --- Ship it! Ship It! - Vinod Kone On May 15, 2016, 6:20 p.m.,

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-15 Thread Qian Zhang
> On May 14, 2016, 10:01 a.m., Qian Zhang wrote: > > src/slave/slave.cpp, line 1020 > > > > > > If we do the link here, that means we still establish TCP connection > > with master right after a new master is

Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/#review133311 --- Patch looks great! Reviews applied: [47052, 47053, 47221, 47054,

Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

2016-05-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van

Re: Review Request 47401: Corrected using order in authorizer.cpp.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47401/#review133307 --- Patch looks great! Reviews applied: [47401] Passed command:

Re: Review Request 47401: Corrected using order in authorizer.cpp.

2016-05-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47401/ --- (Updated May 15, 2016, 9:25 p.m.) Review request for mesos and Alexander

Re: Review Request 47402: Fixed agent to properly handle killTask during agent restart.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47402/#review133306 --- Patch looks great! Reviews applied: [47402] Passed command:

Re: Review Request 47401: Corrected include order in authorizer.cpp.

2016-05-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47401/ --- (Updated May 15, 2016, 8:07 p.m.) Review request for mesos and Alexander

Re: Review Request 47208: Fixed mesos test installation build.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/#review133304 --- Patch looks great! Reviews applied: [47208] Passed command:

Re: Review Request 47400: Documentation quota authorization changes in 0.29.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/#review133303 --- Patch looks great! Reviews applied: [47274, 47399, 47400]

Re: Review Request 47208: Fixed mesos test installation build.

2016-05-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/ --- (Updated May 15, 2016, 6:20 p.m.) Review request for mesos, James Peach and

Review Request 47400: Documentation quota authorization changes in 0.29.

2016-05-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47400/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-5155 and

Re: Review Request 47399: New update_quotas ACL for both set and remove cases.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47399/#review133301 --- Patch looks great! Reviews applied: [47274, 47399] Passed

Review Request 47399: New update_quotas ACL for both set and remove cases.

2016-05-15 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47399/ --- Review request for mesos, Adam B and Alexander Rukletsov. Bugs: MESOS-5155

Re: Review Request 47396: Added aufs provisioning backend.

2016-05-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/#review133299 --- src/slave/containerizer/mesos/provisioner/backends/aufs.cpp

Re: Review Request 45200: Add deprecated flag names.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/#review133298 --- Patch looks great! Reviews applied: [45200] Passed command:

Re: Review Request 47396: Added aufs provisioning backend.

2016-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/#review133297 --- Patch looks great! Reviews applied: [47396] Passed command:

Re: Review Request 45200: Add deprecated flag names.

2016-05-15 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45200/ --- (Updated May 15, 2016, 11:27 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 47396: Added aufs provisioning backend.

2016-05-15 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/ --- (Updated May 15, 2016, 10:52 a.m.) Review request for mesos, Gilbert Song,

Review Request 47396: Added aufs provisioning backend.

2016-05-15 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/ --- Review request for mesos, Gilbert Song, Guangya Liu, and Jie Yu. Bugs: