Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

2016-06-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review135384 --- See the comment I had on the tests: I think we should revisit the

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-06-05 Thread Qian Zhang
> On June 5, 2016, 12:43 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 101 > > > > > > Would reach here if don't meet `Error`. Sorry, my bad, you are right :-)

Re: Review Request 48255: Replaced `NULL` with `nullptr` in libprocess.

2016-06-05 Thread Michael Park
> On June 5, 2016, 5:49 a.m., Tomasz Janiszewski wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 66 > > > > > > This could be left as is. > > Tomasz Janiszewski wrote: > On the other

Re: Review Request 48256: Replaced `NULL` with `nullptr` in mesos `/docs`.

2016-06-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48256/#review136212 --- Ship it! Ship It! - Michael Park On June 5, 2016, 8:25

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

2016-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/#review136211 --- Patch looks great! Reviews applied: [48115, 48116, 48257, 48084,

Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5503

Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5504

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 5, 2016, 6:01 p.m.) Review request for mesos and Vinod Kone.

Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5505

Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5504

Review Request 48115: Added maintenance V1 header.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5505

Re: Review Request 48244: Removed support for parsing the filesystem table (fstab).

2016-06-05 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48244/ --- (Updated June 5, 2016, 1:02 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 48256: Replaced `NULL` with `nullptr` in mesos `/docs`.

2016-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48256/#review136208 --- Patch looks great! Reviews applied: [48256] Passed command:

Re: Review Request 46686: Allowed to pass lambda in `dispatch`.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46686/ --- (Updated June 5, 2016, 8:34 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46687: Added test cases for passing lambda to `dispatch`.

2016-06-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46687/ --- (Updated June 5, 2016, 8:34 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 48255: Replaced `NULL` with `nullptr` in libprocess.

2016-06-05 Thread Tomasz Janiszewski
> On June 5, 2016, 5:49 a.m., Tomasz Janiszewski wrote: > > 3rdparty/libprocess/include/process/windows/subprocess.hpp, line 66 > > > > > > This could be left as is. On the other hand `git grep -w NULL` will show

Review Request 48256: Replaced `NULL` with `nullptr` in mesos `/docs`.

2016-06-05 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48256/ --- Review request for mesos, Michael Park and Neil Conway. Bugs: MESOS-3243

Re: Review Request 48254: Replaced `NULL` with `nullptr` in stout.

2016-06-05 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48254/#review136205 --- Ship it! Ship It! - Tomasz Janiszewski On June 5, 2016,