Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

> On June 20, 2016, 10:20 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1495 > > > > > > You don't need `endl` for LOG Thanks. I will address it. > On June 2

Re: Review Request 49001: Fixed minor styling issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49001/#review138790 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 5:05 a.

Re: Review Request 49000: Reordered function definitions in master actor HTTP handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49000/#review138788 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 5:05 a.

Re: Review Request 49008: Used a temp file for stdin in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/#review138787 --- The code looks good to me to replace stdin in subprocess by a temp

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45086/#review138784 --- src/slave/containerizer/mesos/containerizer.cpp (line 167)

Re: Review Request 49008: Used a temp file for stdin in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/#review138786 --- Ship it! Ship It! - Avinash sridharan On June 21, 2016, 6:13

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 10:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > sp

Re: Review Request 49008: Used a temp file for stdin in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/#review138782 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Review Request 49008: Used a temp file for stdin in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/ --- Review request for mesos and Avinash sridharan. Repository: mesos Description

Re: Review Request 49008: Used a temp file for stdin in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/ --- (Updated June 21, 2016, 6:13 a.m.) Review request for mesos and Avinash sridhar

Re: Review Request 48980: Removed the deprecated fields in NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/#review138781 --- Ship it! Ship It! - Kapil Arya On June 21, 2016, 12:17 a.m.,

Re: Review Request 49001: Fixed minor styling issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49001/#review138778 --- Ship it! Ship It! - Jay Guo On June 21, 2016, 5:05 a.m., Ana

Re: Review Request 49000: Reordered function definitions in master actor HTTP handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49000/#review138777 --- Ship it! Ship It! - Vinod Kone On June 21, 2016, 5:05 a.m.,

Re: Review Request 49001: Fixed minor styling issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49001/#review138776 --- Ship it! Ship It! - Vinod Kone On June 21, 2016, 5:05 a.m.,

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

> On June 21, 2016, 5:21 a.m., Avinash sridharan wrote: > > Ship It! Sorry, meant Fix it then Ship it !! The events got serialized instead !! - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apac

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/#review138772 --- Ship it! Ship It! - Avinash sridharan On June 21, 2016, 2:46

Re: Review Request 48991: Added exception for etc hostname mount in cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/#review138760 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138771 --- src/tests/api_tests.cpp (line 932)

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review138770 --- Bad patch! Reviews applied: [48751] Failed command: ./support/ap

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/ --- (Updated June 21, 2016, 5:09 a.m.) Review request for mesos, Anand Mazumdar and

Review Request 49001: Fixed minor styling issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49001/ --- Review request for mesos, Jay Guo and Vinod Kone. Repository: mesos Descripti

Review Request 49000: Reordered function definitions in master actor HTTP handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49000/ --- Review request for mesos, Abhishek Dasgupta, zhou xing, Jay Guo, haosdent huang,

Re: Review Request 48977: Updated upgrades.md about isoaltor 'ContainerConfig' fields deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48977/ --- (Updated June 20, 2016, 10:01 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 49004: Copied network info if specified in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49004/#review138769 --- Fix it, then Ship it! Ship It! src/docker/executor.cpp (line

Re: Review Request 48980: Removed the deprecated fields in NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/#review138768 --- Ship it! Ship It! - Avinash sridharan On June 21, 2016, 4:17

Review Request 49004: Copied network info if specified in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49004/ --- Review request for mesos, Avinash sridharan and Kapil Arya. Repository: mesos

Re: Review Request 48980: Removed the deprecated fields in NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/#review138767 --- Fix it, then Ship it! LGTM! Please drop that issue if not neces

Review Request 49003: [WIP] Added a Contributing to Mesos blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49003/ --- Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. Repositor

Re: Review Request 48978: Updated CHANGELOG for isolator 'ContainerConfig' fields deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48978/#review138766 --- Ship it! Ship It! - Jie Yu On June 20, 2016, 11:33 p.m., Gil

Re: Review Request 48977: Updated upgrades.md about isoaltor 'ContainerConfig' fields deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48977/#review138765 --- docs/upgrades.md (line 73)

Re: Review Request 48969: Deprecated 'taskInfo' and 'executorInfo' in isolator 'ContainerConfig'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48969/#review138764 --- Ship it! Ship It! - Jie Yu On June 20, 2016, 11:32 p.m., Gil

Review Request 48980: Removed the deprecated fields in NetworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Kapil Arya. Repo

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review138762 --- Patch looks great! Reviews applied: [48313, 48314, 48315] Passed

Re: Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48994/#review138761 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 2:46 a.

Re: Review Request 48976: Remove default values for the `Roles` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48976/#review138759 --- Ship it! Ship It! - Abhishek Dasgupta On June 20, 2016, 11:3

Re: Review Request 48987: Removed rootfs modules exclusion on appc provisioner test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48987/#review138757 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 2:45 a.

Re: Review Request 48995: Fixed portmapping isolator symlink existed failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48995/#review138756 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 2:46 a.

Re: Review Request 48990: Added CGROUP namespace to ns helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48990/#review138754 --- Ship it! Ship It! - haosdent huang On June 21, 2016, 2:46 a.

Re: Review Request 48988: Reduced test linux rootfs size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48988/#review138753 --- src/tests/containerizer/rootfs.hpp (line 109)

Re: Review Request 48915: Added an example framework for consuming GPUs.

> On June 21, 2016, 2:29 a.m., Qian Zhang wrote: > > Thanks for the comments. I've responded to them, but the framework was rejected by the reviewers and won't be landing in the code base. > On June 21, 2016, 2:29 a.m., Qian Zhang wrote: > > src/examples/gpu_framework.cpp, line 203 > >

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On 六月 21, 2016, 1:23 a.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto, lines 278-281 > > > > > > How about the following? > > > > ``` > > // Indicates whether the framework is aware of

Review Request 48995: Fixed portmapping isolator symlink existed failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48995/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, and Cong Wa

Review Request 48991: Added exception for etc hostname mount in cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/ --- Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, Jie

Review Request 48994: Fixed portmapping isolator bind mount root non-existed case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48994/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, and Cong Wa

Review Request 48993: Fixed memory pressure test cgroup slave recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48993/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Artem Harutyunyan

Review Request 48992: Fixed memory pressure test cgroup statistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48992/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Artem Harutyunyan

Review Request 48996: Added space for ROOT_NC_HostToContainerUDP shell commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48996/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Review Request 48989: Fixed broken cni isolator test on centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48989/ --- Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, Jie

Review Request 48990: Added CGROUP namespace to ns helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48990/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Jie Yu, Qian Zhang,

Review Request 48988: Reduced test linux rootfs size.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48988/ --- Review request for mesos, Zhiwei Chen, haosdent huang, Artem Harutyunyan, Jie Yu

Review Request 48987: Removed rootfs modules exclusion on appc provisioner test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48987/ --- Review request for mesos, Zhiwei Chen, haosdent huang, Artem Harutyunyan, Jie Yu

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On June 21, 2016, 1:23 a.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto, lines 278-281 > > > > > > How about the following? > > > > ``` > > // Indicates whether the framework is aware o

Re: Review Request 48915: Added an example framework for consuming GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48915/#review138743 --- src/examples/gpu_framework.cpp (line 98)

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On 六月 21, 2016, 1:23 a.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto, lines 278-281 > > > > > > How about the following? > > > > ``` > > // Indicates whether the framework is aware of

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 2:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > spe

Re: Review Request 48978: Updated CHANGELOG for isolator 'ContainerConfig' fields deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48978/#review138738 --- Patch looks great! Reviews applied: [48969, 48977, 48978] Passed

Re: Review Request 46299: Ignore eventfd caused by hierarchy destruction.

> On June 20, 2016, 4:09 p.m., Qian Zhang wrote: > > @haosdent, I tried in my env, it seems when cgroup is destroyed, eventfd > > will not be triggered. What I did is, use `mesos-execute` to launch a > > container to do a simple task (sleep 5 seconds), and after 5 seconds, the > > task finishe

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 12, 2016, 10:51 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 351-363 > > > > > > Why do we prepare hierarchy here? I think preparing hierarchy for a > > sp

Re: Review Request 48979: Added check for `--isolation=gpu/nvidia` in order to autodiscover GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48979/#review138734 --- Ship it! - Benjamin Mahler On June 21, 2016, 1:36 a.m., Kevin

Re: Review Request 48925: Implement GET_WEIGHTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138732 --- Fix it, then Ship it! src/master/master.hpp (line 1065)

Re: Review Request 48879: Added logic for subscribing to task added/updated events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/ --- (Updated June 21, 2016, 1:38 a.m.) Review request for mesos, Vinod Kone and Zhi

Review Request 48979: Added check for `--isolation=gpu/nvidia` in order to autodiscover GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48979/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5257 https://issu

Re: Review Request 48924: Extract public logic of collecting weights info into _getWeights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48924/#review138730 --- Ship it! Ship It! - Vinod Kone On June 20, 2016, 3:33 a.m.,

Re: Review Request 48751: Implement GetState response for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48751/#review138723 --- include/mesos/v1/master.proto (lines 181 - 193)

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On June 20, 2016, 5:50 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 278 > > > > > > I think that this comment should be updated, as even a framework with > > `GPU_RESOURCES`, it can still get resou

Re: Review Request 48056: Windows: Added build and run instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/#review138724 --- Fix it, then Ship it! Managed to build on Windows 8, but we can

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On June 19, 2016, 2:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1274 > > > > > > s/slaves/agents > > Kevin Klues wrote: > I thought about this as I was writing it, but I

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48914/#review138698 --- Ship it! include/mesos/mesos.proto (lines 278 - 281)

Re: Review Request 48976: Remove default values for the `Roles` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48976/#review138722 --- Ship it! Ship It! - Vinod Kone On June 20, 2016, 11:34 p.m.,

Re: Review Request 48879: Added logic for subscribing to task added/updated events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/#review138721 --- Fix it, then Ship it! src/master/master.hpp (line 396)

Re: Review Request 48974: Moved `addTask()` definition to cpp from header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48974/#review138720 --- Ship it! Ship It! - Vinod Kone On June 20, 2016, 11:09 p.m.,

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

> On June 20, 2016, 8:06 a.m., Alexander Rukletsov wrote: > > To avoid confusion, we should actually change the namespace allocator code > > lives is as well. I've once started that effort > > (https://reviews.apache.org/r/29930/) but decided to discard because > > allocator is the master-only

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138709 --- src/CMakeLists.txt (line 24)

Re: Review Request 48880: Added test for task added/update event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48880/ --- (Updated June 21, 2016, 12:27 a.m.) Review request for mesos, Vinod Kone and Zh

Re: Review Request 48915: Added an example framework for consuming GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48915/#review138716 --- Hm.. we've tried to generalize the command framework (clumsily cal

Re: Review Request 48875: Fixed a couple of minor style typos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48875/ --- (Updated June 21, 2016, 12:23 a.m.) Review request for mesos, Vinod Kone and Zh

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

> On June 20, 2016, 5:16 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 2513 > > > > > > The first argument is already a member variable and doesn't need to be > > passed around right? > > > > It'

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 20, 2016, 11:41 p.m.) Review request for mesos, Neil Conway and J

Re: Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated June 20, 2016, 11:41 p.m.) Review request for mesos, Neil Conway and J

Re: Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/ --- (Updated June 20, 2016, 11:41 p.m.) Review request for mesos, Neil Conway and J

Re: Review Request 48912: Changed all global variable declarations in nvml.cpp to static.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48912/#review138710 --- Ship it! Ship It! - Benjamin Mahler On June 18, 2016, 10:05

Review Request 48976: Remove default values for the `Roles` protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48976/ --- Review request for mesos, Abhishek Dasgupta and Vinod Kone. Bugs: MESOS-5494

Re: Review Request 48948: Fix getTasks() to use unversioned protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48948/ --- (Updated June 20, 2016, 11:34 p.m.) Review request for mesos and Vinod Kone.

Review Request 48978: Updated CHANGELOG for isolator 'ContainerConfig' fields deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48978/ --- Review request for mesos, Alexander Rukletsov, Artem Harutyunyan, and Jie Yu. B

Review Request 48977: Updated upgrades.md about isoaltor 'ContainerConfig' fields deprecation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48977/ --- Review request for mesos, Alexander Rukletsov, Artem Harutyunyan, and Jie Yu. B

Re: Review Request 48056: Windows: Added build and run instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/#review138708 --- Bad review! Reviews applied: [48056] Error: No reviewers specifi

Re: Review Request 48969: Deprecated 'taskInfo' and 'executorInfo' in isolator 'ContainerConfig'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48969/ --- (Updated June 20, 2016, 4:32 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 48938: Added test case `MasterAPITest.CreateAndDetroyVolumes`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48938/#review138705 --- src/internal/evolve.cpp (line 163)

Re: Review Request 48879: Added logic for subscribing to task added/updated events.

> On June 18, 2016, 3:58 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 7487 > > > > > > i'm guessing this is the only new part in this function? +1, I split this into a separate review. > On June 18, 20

Re: Review Request 48879: Added logic for subscribing to task added/updated events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/ --- (Updated June 20, 2016, 11:09 p.m.) Review request for mesos, Vinod Kone and Zh

Review Request 48974: Moved `addTask()` definition to cpp from header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48974/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5609 https://issues.ap

Re: Review Request 48876: Added `TASK_ADDED`/`TASK_UPDATED` events to master.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48876/ --- (Updated June 20, 2016, 11:09 p.m.) Review request for mesos, Vinod Kone and Zh

Re: Review Request 48879: Added logic for subscribing to task added/updated events.

> On June 18, 2016, 1:47 p.m., haosdent huang wrote: > > src/master/http.cpp, line 689 > > > > > > I saw we do this check in scheduler::Call > > ``` > > if (request.headers.contains("Mesos-Stream-Id")) {

Re: Review Request 48880: Added test for task added/update event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48880/ --- (Updated June 20, 2016, 11:09 p.m.) Review request for mesos, Vinod Kone and Zh

Re: Review Request 48927: Implemented DESTROY_VOLUMES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48927/#review138704 --- LGTM modulo haosdent's comment. - Vinod Kone On June 20, 2016,

Re: Review Request 48926: Implemented CREATE_VOLUMES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48926/#review138701 --- Ship it! Ship It! - Vinod Kone On June 20, 2016, 1:59 a.m.,

Re: Review Request 48905: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48905/#review138700 --- Ship it! Ship It! - Vinod Kone On June 18, 2016, 11:53 a.m.,

Re: Review Request 48969: Deprecated 'taskInfo' and 'executorInfo' in isolator 'ContainerConfig'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48969/#review138695 --- Patch looks great! Reviews applied: [48969] Passed command: expo

Re: Review Request 48056: Windows: Added build and run instructions.

> On June 18, 2016, 2:18 a.m., Joseph Wu wrote: > > docs/getting-started.md, lines 175-176 > > > > > > Are there links to more general download pages? > > > > It seems odd to have very specific versions here

Re: Review Request 48056: Windows: Added build and run instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/ --- (Updated June 20, 2016, 10:25 p.m.) Review request for mesos, Alex Naparu, Arte

  1   2   >