Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On 七月 27, 2016, 7:55 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 1550-1561 > > > > > > Why release the gpu resources here? The `update` will also be called > > when the executor is laun

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review144289 --- src/slave/containerizer/docker.hpp (lines 28 - 32)

Re: Review Request 50643: Implemented `CgroupsIsolatorProcess::finalize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50643/#review144304 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50642/#review144298 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review144297 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (li

Re: Review Request 50644: Added check for root permissions to 'NvidiaVolume::create()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50644/ --- (Updated July 31, 2016, 6:56 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 50592: Updated NvidiaVolume to mount as 'tmpfs' if parent fs is 'noexec'.

> On July 31, 2016, 12:25 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/gpu/volume.cpp, lines 238-243 > > > > > > What if `/` is mounted with `noexec` and `/run` is mounted without > > `noexec`? Do

Re: Review Request 50592: Updated NvidiaVolume to mount as 'tmpfs' if parent fs is 'noexec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50592/ --- (Updated July 31, 2016, 6:55 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 50644: Added check for root permissions to 'NvidiaVolume::create()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50644/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5945 http

Re: Review Request 50301: Reduced logging verbosity for replicated log operations.

> On July 29, 2016, 6:48 p.m., Anand Mazumdar wrote: > > src/log/recover.cpp, line 466 > > > > > > hmm, why did you reduce the verbosity here? > > Neil Conway wrote: > Do you think that is important to log? Note

Re: Review Request 50516: Fixed quoting for executor and task IDs in log messages.

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote: > > hmm, why can't the TaskID's have spaces? > > > > They are generated by the framework and are free to contain spaces. > > Neil Conway wrote: > Yeah, I was wondering that myself :) We don't quote them almost all the > time, however. I

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/#review144282 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (li

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated July 31, 2016, 5:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated July 31, 2016, 5:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Added `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated July 31, 2016, 5:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated July 31, 2016, 5:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated July 31, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated July 31, 2016, 5:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated July 31, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 31, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 31, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50643: Implemented `CgroupsIsolatorProcess::finalize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50643/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. Bu

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 31, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50642/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. Bu

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 31, 2016, 5:47 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/ --- (Updated July 31, 2016, 5:47 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50640: Improved HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50640/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description --

Review Request 50641: Fixed typo in comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50641/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description --

Re: Review Request 50518: Clarified log messages during master startup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50518/ --- (Updated July 31, 2016, 2:42 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 50520: Tweaked agent logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50520/ --- (Updated July 31, 2016, 2:41 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 50520: Tweaked agent logging.

> On July 29, 2016, 7:30 p.m., Anand Mazumdar wrote: > > src/slave/slave.cpp, line 198 > > > > > > hmm, why this change? Well, there has been an obvious typo in the output for a long time: ``` Agent started on 1)@1

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/#review144279 --- Ship it! Ship It! - Qian Zhang On July 31, 2016, 2:05 a.m.,

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/#review144278 --- Ship it! Ship It! - Qian Zhang On July 31, 2016, 12:24 a.m.,

Re: Review Request 50563: Made HierarchicalAllocatorProcess specify a process ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50563/ --- (Updated July 31, 2016, 11:31 a.m.) Review request for mesos and Alexander Rukl

Re: Review Request 50521: Added "zookeeper" prefix to ZK process IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50521/ --- (Updated July 31, 2016, 11:29 a.m.) Review request for mesos and Alexander Rukl

Review Request 50639: Made all Actor IDs outside of libprocess follow the same schema.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50639/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-5917 https://

Re: Review Request 50519: Changed AuthenticatorManagerProcess's Actor ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50519/ --- (Updated July 31, 2016, 11:24 a.m.) Review request for mesos and Alexander Rukl

Re: Review Request 50515: Added missing process IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50515/ --- (Updated July 31, 2016, 11:15 a.m.) Review request for mesos and Alexander Rukl

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50637/ --- (Updated July 31, 2016, 11:13 a.m.) Review request for mesos and Alexander Rukl

Re: Review Request 50513: Added missing process IDs in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50513/ --- (Updated July 31, 2016, 11:12 a.m.) Review request for mesos and Alexander Rukl