Re: Review Request 49924: Added libprocess as a shared library.

2016-08-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review145062 --- Patch looks great! Reviews applied: [49688, 49862, 49863, 49870,

Re: Review Request 50853: Resolved C++11-related TODO in master/master.cpp.

2016-08-07 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50853/#review145061 --- Which compilers did you test with? - Benjamin Mahler On Aug. 5,

Re: Review Request 50125: Added mesos-docker-executor support for device control.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review145060 --- src/docker/executor.hpp (lines 78 - 79)

Re: Review Request 50599: Passed allocated GPUs to 'device' entry of 'docker::Flags'.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review145059 --- src/slave/containerizer/docker.cpp (lines 1344 - 1383)

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review145058 --- src/docker/docker.hpp (line 20)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review145056 --- src/slave/containerizer/docker.cpp (lines 1360 - 1428)

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49924: Added libprocess as a shared library.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/ --- (Updated Aug. 8, 2016, 5:25 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49870: Added test executables required to run tests.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated Aug. 8, 2016, 5:24 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Aug. 8, 2016, 5:23 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49862: Changed libraies to shared on OSX and UNIX.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Aug. 8, 2016, 5:23 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49851: Implemented `MemorySubsystem`.

2016-08-07 Thread Qian Zhang
> On July 27, 2016, 10:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > > recovery

Re: Review Request 49360: Supported TCP check in health check.

2016-08-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 7, 2016, 6:21 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 7, 2016, 6:21 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 49351: Updated 'HealthCheck' protobuf validation.

2016-08-07 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49351/ --- (Updated Aug. 7, 2016, 6:20 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 50878: Avoid subtract resource when check contains for non persistent volume.

2016-08-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50878/#review145050 --- Patch looks great! Reviews applied: [50877, 50878] Passed comman

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review145049 --- src/slave/containerizer/docker.hpp (line 283)

Re: Review Request 50878: Avoid subtract resource when check contains for non persistent volume.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50878/#review145047 --- Just FYI, https://reviews.apache.org/r/30430/ introduced the logic

Review Request 50878: Avoid subtract resource when check contains for non persistent volume.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50878/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 49870: Added test executables required to run tests.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Aug. 7, 2016, 3:14 p.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 49849: Implemented `CpuSubsystem`.

2016-08-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review145039 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (li

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

2016-08-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review145046 --- Fix it, then Ship it! src/slave/containerizer/mesos/containeri

Re: Review Request 49854: Implemented `DevicesSubsystem`.

2016-08-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/#review145041 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (li

Re: Review Request 50877: Added more cases for sorter benchmark test.

2016-08-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50877/#review145045 --- Patch looks great! Reviews applied: [50877] Passed command: expo

Review Request 50877: Added more cases for sorter benchmark test.

2016-08-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50877/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -