Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

> On Aug. 17, 2016, 4:06 p.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > Here can we change it to the following? > > ``` > > if (matches(test, "ROOT_CGROUPS_Isolate") || > >

Re: Review Request 51195: Refactored the test helper to use a single binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51195/#review146068 --- Patch looks great! Reviews applied: [51195] Passed command: expo

Re: Review Request 51101: Fixed XFS isolator's handling of old containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51101/#review146066 --- Ship it! Ship It! - Silas Snider On Aug. 16, 2016, 4:43 p.m.

Review Request 51195: Refactored the test helper to use a single binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51195/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-6053 https://iss

Re: Review Request 50269: Added basic tests for capabilities API.

> On Aug. 17, 2016, 6:29 p.m., Jie Yu wrote: > > FYI: > > https://issues.apache.org/jira/browse/MESOS-6053 https://reviews.apache.org/r/51195 - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: Review Request 51170: Removed 'recover()' in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51170/#review146062 --- This seems duplicate with https://reviews.apache.org/r/49234/diff/

Re: Review Request 49617: Add benchmark for failover of many frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review146059 --- src/tests/hierarchical_allocator_tests.cpp (lines 4003 - 4004)

Re: Review Request 51160: Use http instead of https for localhost registry on non 443 port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51160/ --- (Updated Aug. 18, 2016, 12:42 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146058 --- Can you please also clarify some difference with https://reviews.

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146040 --- src/master/allocator/mesos/hierarchical.hpp (lines 381 - 382)

Re: Review Request 51185: Updated to non-recursive version `cgroups::get` in CgroupsIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/#review146057 --- Ship it! Ship It! - Qian Zhang On Aug. 18, 2016, 1:40 a.m.,

Re: Review Request 50836: Made add/subtract resource object as private method.

> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword wouldn't

Re: Review Request 51185: Updated to non-recursive version `cgroups::get` in CgroupsIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/#review146053 --- Ship it! Ship It! - Jie Yu On Aug. 17, 2016, 5:40 p.m., haos

Re: Review Request 51160: Use http instead of https for localhost registry on non 443 port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51160/#review146052 --- Fix it, then Ship it! src/docker/spec.cpp (lines 129 - 136)

Re: Review Request 50836: Made add/subtract resource object as private method.

> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword wouldn'

Re: Review Request 51068: Prevent memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review146037 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review146028 --- Mind adding a test? We already have `CgroupsAnyHierarchyTest.ROOT_

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review146035 --- Patch looks great! Reviews applied: [51091, 51031, 51185, 49828,

Re: Review Request 51068: Prevent memory leaks

> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote: > > src/zookeeper/zookeeper.cpp, lines 196-220 > > > > > > Promise is now on the stack here, but the asynchronous callbacks > > (voidCompletion, stringCompletio

Re: Review Request 50269: Added basic tests for capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50269/#review146027 --- FYI: https://issues.apache.org/jira/browse/MESOS-6053 - Jie Yu

Re: Review Request 51068: Prevent memory leaks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/ --- (Updated Aug. 17, 2016, 6:21 p.m.) Review request for mesos. Repository: meso

Re: Review Request 51043: Added support for reading out the bounding capability set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51043/#review146024 --- src/linux/capabilities.cpp (lines 229 - 231)

Re: Review Request 50992: Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_NUM macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50992/#review146022 --- Ship it! include/mesos/version.hpp.in (lines 24 - 25)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 17, 2016, 6:12 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 51042: Added high-level function to set capabilties on process exec'd next.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/#review146021 --- I still don't get why this is needed. - Jie Yu On Aug. 12, 2016

Re: Review Request 49360: Supported TCP in health check.

> On Aug. 17, 2016, 12:05 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, lines 489-503 > > > > > > Again, we probably want to do it in a subprocess hook. For this, we > > need to provide

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.hpp, line 330 > > > > > > Why do you need to discard original future here? > > haosdent huang wrote: > I saw we disc

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

> On Aug. 15, 2016, 12:43 a.m., Alexander Rukletsov wrote: > > src/health-check/health_checker.cpp, lines 363-367 > > > > > > Why do you think this won't affect ibprocess communication? Actors' > > callbacks are ex

Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51167/#review146016 --- src/slave/containerizer/mesos/launcher.hpp (lines 87 - 89)

Re: Review Request 51084: Allowed a process with multiple threads call `net::setns`.

> On Aug. 16, 2016, 11:56 p.m., Alexander Rukletsov wrote: > > I'm not sure we need this change. See my comment in the next review. Yep, I think it is not necessary now. - haosdent --- This is an automatically generated e-mail. To reply

Re: Review Request 51068: Prevent memory leaks

> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote: > > src/zookeeper/zookeeper.cpp, lines 196-220 > > > > > > Promise is now on the stack here, but the asynchronous callbacks > > (voidCompletion, stringCompletio

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

> On Aug. 17, 2016, 8:06 a.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > Here can we change it to the following? > > ``` > > if (matches(test, "ROOT_CGROUPS_Isolate") || > >

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 17, 2016, 5:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 17, 2016, 5:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Aug. 17, 2016, 5:44 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50758/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 17, 2016, 5:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Aug. 17, 2016, 5:40 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 51185: Updated to non-recursive version `cgroups::get` in CgroupsIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, Zhengju Sha, and Jia

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Aug. 17, 2016, 5:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51091: Disallowed unknown cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51091/ --- (Updated Aug. 17, 2016, 5:38 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 17, 2016, 5:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51167/#review146005 --- Patch looks great! Reviews applied: [51155, 51167] Passed comman

Re: Review Request 51155: Added an agent flag for 'runtime_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51155/#review146004 --- Ship it! Ship It! - Jie Yu On Aug. 16, 2016, 10:42 p.m., Kev

Re: Review Request 51173: [WIP] Plugged in the volume/image isolator to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/#review145987 --- Patch looks great! Reviews applied: [51141, 51170, 51171, 51172,

Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51167/ --- (Updated Aug. 17, 2016, 2:30 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51167/ --- (Updated Aug. 17, 2016, 2:26 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review145980 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 51167: Added extra functions to the 'Launcher' abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51167/#review145979 --- Patch looks great! Reviews applied: [51155, 51167] Passed comman

Re: Review Request 49617: Add benchmark for failover of many frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49617/#review145976 --- Patch looks great! Reviews applied: [49617] Passed command: expo

Review Request 51171: Supported image provisioner singleton methods for global pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51171/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem Harutyunyan,

Review Request 51173: [WIP] Plugged in the volume/image isolator to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem Harutyunyan,

Review Request 51172: Implemented the volume/image isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem Harutyunyan,

Review Request 51170: Removed 'recover()' in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51170/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem Harutyunyan,

Re: Review Request 50992: Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_NUM macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50992/#review145971 --- Patch looks great! Reviews applied: [50992] Passed command: expo

Re: Review Request 47324: Update leveldb to 1.18.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review145970 --- Closing in favor of [51053](https://reviews.apache.org/r/51053/)

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/#review145965 --- src/tests/containerizer/isolator_tests.cpp (line 1018)

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review145966 --- src/tests/containerizer/isolator_tests.cpp (line 1235)

Re: Review Request 51160: Use http instead of https for localhost registry on non 443 port.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51160/#review145964 --- Patch looks great! Reviews applied: [51160] Passed command: expo