Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review146301 --- src/slave/containerizer/docker.hpp (line 505)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review146300 --- Fix it, then Ship it! src/tests/mesos.cpp (line 65)

Re: Review Request 50127: Added DockerContainerizerTest.ROOT_NVIDIA_GPU_DOCKER_Launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/#review146263 --- src/tests/containerizer/docker_containerizer_tests.cpp (line 3822

Re: Review Request 51172: Implemented the volume/image isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146298 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 49851: Implemented `MemorySubsystem`.

> On Aug. 22, 2016, 3:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to add

Re: Review Request 49851: Implemented `MemorySubsystem`.

> On Aug. 22, 2016, 11:09 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp, > > lines 166-169 > > > > > > Realized an issue. What if the operator changes the flags to ad

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146295 --- Patch looks great! Reviews applied: [51095, 51096, 51097] Passed

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 22, 2016, 5:35 a.m.) Review request for mesos, Jie Yu and Qian Zh

Review Request 51273: Cleaned up a comment that was not accurate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51273/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Repository: mesos

Review Request 51277: Added an 'ns::enter' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Review Request 51275: Factored out a cgroups::isolate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51275/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- C

Review Request 51278: Refactored LinuxLauncher to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- N

Review Request 51274: Refactored Launcher helpers to be used in LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51274/ --- Review request for mesos, Jie Yu and Kevin Klues. Repository: mesos Descripti

Review Request 51276: Added 'cgroups::traverse' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51276/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer.

> On Aug. 21, 2016, 9:28 p.m., Jie Yu wrote: > > We should always enable `volume/image` on linux to ensure backwards > > compatibility. Yeah, will do. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://re

Review Request 51272: Refactored the agent 'launcher' flag to always have a value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51272/ --- Review request for mesos, Jie Yu and Kevin Klues. Repository: mesos Descripti

Re: Review Request 51262: Changed the order so user specified env variables take precedence.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51262/ --- (Updated Aug. 22, 2016, 4:40 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 51261: Fixed container ID related logging in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51261/ --- (Updated Aug. 22, 2016, 4:40 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 51263: Renamed containerizer::Termination to ContainerTermination.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51263/ --- (Updated Aug. 22, 2016, 4:40 a.m.) Review request for mesos and Gilbert Song.

Re: Review Request 51163: Refactored MesosContainerizer to prepare for nested container support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51163/ --- (Updated Aug. 22, 2016, 4:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51161: Removed DestroyWhileProvisioningVolumeImage test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51161/ --- (Updated Aug. 22, 2016, 4:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51162: Kept a single provisioning future in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51162/ --- (Updated Aug. 22, 2016, 4:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51271: Fixed potential flakiness in ROOT_RecoverOrphanedPersistentVolume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51271/#review146291 --- Ship it! Ship It! - Jie Yu On Aug. 22, 2016, 2:15 a.m., Gilb

Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/#review146290 --- We should always enable `volume/image` on linux to ensure backward

Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/#review146289 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 51172: Implemented the volume/image isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146285 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 51141: Simplified the mesos containerizer launch logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51141/#review146286 --- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 22, 2016, 3:53 a.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 51171: Changed the provisioner recover/provision/destroy to be const methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51171/#review146284 --- Ship it! Ship It! - Jie Yu On Aug. 22, 2016, 2:11 a.m., Gilb

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146267 --- Fix it, then Ship it! I made some adjustments while committing.

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146283 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review146281 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (li

Re: Review Request 51271: Fixed potential flakiness in ROOT_RecoverOrphanedPersistentVolume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51271/#review146282 --- Bad patch! Reviews applied: [51271, 51173, 51172, 51171, 51263, 5

Re: Review Request 51053: Update leveldb to 1.19.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/#review146280 --- Have you also done compatibility tests mentioned in the ticket? -

Review Request 51271: Fixed potential flakiness in ROOT_RecoverOrphanedPersistentVolume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51271/ --- Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem Harutyunyan,

Re: Review Request 51173: Plugged in the volume/image isolator to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51173/ --- (Updated Aug. 21, 2016, 7:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51172: Implemented the volume/image isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/ --- (Updated Aug. 21, 2016, 7:13 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51172: Implemented the volume/image isolator.

> On Aug. 18, 2016, 4:37 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/volume/image.cpp, line 94 > > > > > > s/int/size_t Please see mesos.pb.h > On Aug. 18, 2016, 4:37 p.m., Guangya Liu wrot

Re: Review Request 51171: Changed the provisioner recover/provision/destroy to be const methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51171/ --- (Updated Aug. 21, 2016, 7:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51141: Simplified the mesos containerizer launch logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51141/ --- (Updated Aug. 21, 2016, 7:10 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51170: Removed 'recover()' in docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51170/ --- (Updated Aug. 21, 2016, 6:36 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51170: Removed 'recover()' in docker runtime isolator.

> On Aug. 17, 2016, 7:41 p.m., Guangya Liu wrote: > > This seems duplicate with > > https://reviews.apache.org/r/49234/diff/1#index_header Thanks for reminding. I will discard this one. - Gilbert --- This is an automatically generated

Re: Review Request 51270: Added master validations for TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51270/#review146275 --- Patch looks great! Reviews applied: [51247, 51248, 51270] Passed

Re: Review Request 51247: Fixed indentation in master/validation.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51247/ --- (Updated Aug. 21, 2016, 11:30 p.m.) Review request for mesos and Benjamin Mahle

Review Request 51270: Added master validations for TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51270/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6042 https://issu

Review Request 51248: Refactored task validations in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51248/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6042 https://issu

Review Request 51247: Fixed indentation in master/validation.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51247/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 51162: Kept a single provisioning future in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51162/#review146271 --- Ship it! Ship It! - Gilbert Song On Aug. 16, 2016, 5:03 p.m.

Re: Review Request 51161: Removed DestroyWhileProvisioningVolumeImage test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51161/#review146270 --- Ship it! Ship It! - Gilbert Song On Aug. 16, 2016, 5:02 p.m.

Re: Review Request 51268: Added mesos-health-check-helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51268/ --- (Updated Aug. 21, 2016, 6:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51269: Switched to use mesos-health-check-helper perform health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51269/ --- (Updated Aug. 21, 2016, 6:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 21, 2016, 6:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 21, 2016, 6:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51267: Defined mesos-health-check-helper in cmake configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51267/ --- (Updated Aug. 21, 2016, 6:42 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 21, 2016, 6:42 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 21, 2016, 6:42 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 21, 2016, 6:23 p.m.) Review request for mesos, Alexander Rukletso

Review Request 51269: Switched to use mesos-health-check-helper perform health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51269/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman,

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 21, 2016, 6:22 p.m.) Review request for mesos, Alexander Rukletso

Review Request 51268: Added mesos-health-check-helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51268/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman,

Review Request 51267: Defined mesos-health-check-helper in cmake configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51267/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman,

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 21, 2016, 6:21 p.m.) Review request for mesos, Alexander Rukletso

Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman,

Re: Review Request 51171: Supported image provisioner singleton methods for global pointer.

> On Aug. 18, 2016, 2:33 p.m., Jie Yu wrote: > > It was my bad. After looking at the code closely, I realized that we should > > probably use dependency injection for the new isolator. In other words, > > > > `ImageVolumeIsolator::create` will take a flags as well as a > > `Shared`. Take a loo

Re: Review Request 51265: Allowed clean up unknown containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51265/#review146265 --- Fix it, then Ship it! I did some editing on the comments. src

Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50524/#review146264 --- Bad patch! Reviews applied: [50524, 50523, 50127, 50947, 50125, 5

Re: Review Request 50524: Updated docker recovery to use abstraction provided by docker inspect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50524/#review146262 --- Why not merge this with https://reviews.apache.org/r/50523 ? - Gu

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/#review146261 --- Some early comments. src/slave/containerizer/docker.cpp (line 94

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review146260 --- Patch looks great! Reviews applied: [51091, 51031, 51185, 51265,

Re: Review Request 49854: Implemented `DevicesSubsystem`.

> On Aug. 20, 2016, 9:17 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/devices.cpp, > > lines 157-159 > > > > > > I still don't get why isolator cleanup will be invoked more tha

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 21, 2016, 9:30 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 21, 2016, 9:30 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 21, 2016, 9:30 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Aug. 21, 2016, 9:30 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 21, 2016, 9:30 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50758/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51265: Allowed clean up unknown containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51265/ --- (Updated Aug. 21, 2016, 9:29 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 21, 2016, 9:13 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 21, 2016, 9:13 a.m.) Review request for mesos, Gilbert Song, Jie

Review Request 51265: Allowed clean up unknown containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51265/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. Bu

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- (Updated Aug. 21, 2016, 9:10 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51091: Disallowed unknown cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51091/ --- (Updated Aug. 21, 2016, 9:10 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Aug. 21, 2016, 9:10 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51172: Implemented the volume/image isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146256 --- src/slave/containerizer/mesos/isolators/volume/image.cpp (lines 8

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review146257 --- Patch looks great! Reviews applied: [51095, 51096, 51097] Passed