Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/ --- (Updated Sept. 18, 2016, 5:40 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/ --- (Updated Sept. 18, 2016, 5:16 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149356 --- src/cli/execute.cpp (line 270)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On 九月 18, 2016, 1:33 a.m., Guangya Liu wrote: > > Can you please also append your file:///home/abhishek/taskgroup.txt to the `Testing Done` section? - Guangya --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149352 --- src/cli/execute.cpp (lines 73 - 74)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149353 --- Bad patch! Reviews applied: [51623, 51991, 51990, 51978] Failed

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/#review149351 --- A rebase is needed. src/cli/execute.cpp (line 512)

Re: Review Request 51985: Waited for agent finish registering in test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51985/#review149350 --- Patch looks great! Reviews applied: [51985] Passed command: expo

Re: Review Request 51992: Fixed a bug in getRootContainerId due to protobuf copying issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51992/#review149347 --- Ship it! Ship It! - Kevin Klues On Sept. 17, 2016, 9:25 p.m.

Review Request 51992: Fixed a bug in getRootContainerId due to protobuf copying issue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51992/ --- Review request for mesos, Gilbert Song and Kevin Klues. Repository: mesos Des

Re: Review Request 51984: Cleaned up initialization of atomic fields in ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51984/#review149346 --- Patch looks great! Reviews applied: [51984] Passed command: expo

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 17, 2016, 8:56 p.m.) Review request for mesos, Anand Mazumdar an

Review Request 51991: Added parse function in flags namespace for v1::TaskGroupInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51991/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6096 https://issues.ap

Review Request 51990: Added << operator to stringify v1::TaskGroupInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51990/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6096 https://issues.ap

Re: Review Request 51988: Updated 'cgroups' isolator 'watch' to be properly nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51988/#review149345 --- Ship it! Ship It! - Jie Yu On Sept. 17, 2016, 7:47 p.m., Kev

Re: Review Request 51988: Updated 'cgroups' isolator 'watch' to be properly nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51988/#review149344 --- Ship it! Ship It! - Gilbert Song On Sept. 17, 2016, 12:47 p.

Re: Review Request 51981: Marked the pid namespace isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51981/#review149343 --- Ship it! Ship It! - Kevin Klues On Sept. 17, 2016, 6:07 p.m.

Re: Review Request 51989: Made the 'disk/du' isolator nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51989/#review149342 --- Ship it! Ship It! - Kevin Klues On Sept. 17, 2016, 7:33 p.m.

Re: Review Request 51988: Updated 'cgroups' isolator 'watch' to be properly nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51988/ --- (Updated Sept. 17, 2016, 7:47 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 51981: Marked the pid namespace isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51981/#review149341 --- Ship it! Ship It! - Gilbert Song On Sept. 17, 2016, 11:07 a.

Review Request 51988: Updated 'cgroups' isolator 'watch' to be properly nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51988/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6186 https://issues.apache

Re: Review Request 45491: Refactored subprocess options [1/2].

> On Sept. 17, 2016, 4:11 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess_base.hpp, lines 402-403 > > > > > > Hum, i don't like ChildHook::None(). Have you tried if ```const > > vector& child_

Review Request 51989: Made the 'disk/du' isolator nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51989/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues. Bugs

Re: Review Request 45491: Refactored subprocess options [1/2].

> On Sept. 17, 2016, 4:11 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess_base.hpp, line 314 > > > > > > I suggest we rename Hook to ParentHook. You can do that in a separate > > patch. Sound

Re: Review Request 45491: Refactored subprocess options [1/2].

> On Sept. 17, 2016, 4:11 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/subprocess_base.hpp, lines 402-403 > > > > > > Hum, i don't like ChildHook::None(). Have you tried if ```const > > vector& child_

Re: Review Request 51983: Avoided passing large object by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51983/#review149336 --- Patch looks great! Reviews applied: [51983] Passed command: expo

Re: Review Request 51981: Marked the pid namespace isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51981/ --- (Updated Sept. 17, 2016, 6:07 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/#review149334 --- Ship it! Ship It! - Vinod Kone On Sept. 17, 2016, 4:23 p.m.,

Re: Review Request 51983: Avoided passing large object by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51983/#review149332 --- Ship it! Ship It! - Jie Yu On Sept. 17, 2016, 3:05 p.m., Nei

Re: Review Request 51958: Removed use of "--registry_strict" master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/#review149331 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51871/ --- (Updated Sept. 17, 2016, 4:34 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/ --- (Updated Sept. 17, 2016, 4:23 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/ --- (Updated Sept. 17, 2016, 4:22 p.m.) Review request for mesos and Vinod Kone.

Review Request 51985: Waited for agent finish registering in test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51985/ --- Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, Joseph Wu, and Qian Z

Review Request 51984: Cleaned up initialization of atomic fields in ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51984/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 51983: Avoided passing large object by value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51983/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 51958: Removed use of "--registry_strict" master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51958/ --- (Updated Sept. 17, 2016, 2:23 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/#review149330 --- Ship it! Ship It! - Qian Zhang On Sept. 12, 2016, 9:05 p.m.,

Re: Review Request 51978: Refactored commandScheduler in cli/execute.cpp to take TaskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51978/#review149329 --- Bad patch! Reviews applied: [51978] Failed command: ./support/ap

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/#review149328 --- Patch looks great! Reviews applied: [51028, 51027, 51621] Passed

Re: Review Request 51968: Simplified usage of `os::pagesize` in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51968/#review149327 --- Ship it! Ship It! - Michael Park On Sept. 16, 2016, 7:02 p.m

Re: Review Request 51967: Changed return type of `os::pagesize` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51967/#review149326 --- Ship it! Ship It! - Michael Park On Sept. 16, 2016, 7:02 p.m

Re: Review Request 51981: Marke the pid namespace isolator as nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51981/#review149325 --- Patch looks great! Reviews applied: [51981] Passed command: expo

Re: Review Request 45491: Refactored subprocess options [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review149324 --- 3rdparty/libprocess/include/process/posix/subprocess.hpp (line 21

Re: Review Request 51869: Export "reserved_resources" in the agent HTTP endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51869/#review149323 --- Ship it! Ship It! - Anindya Sinha On Sept. 16, 2016, 6:24 p.

Re: Review Request 51868: Expose full reservation info in the agent's http endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51868/#review149322 --- Ship it! Ship It! - Anindya Sinha On Sept. 14, 2016, 6:21 p.

Re: Review Request 51868: Expose full reservation info in the agent's http endpoint.

> On Sept. 14, 2016, 11:56 p.m., Anindya Sinha wrote: > > src/slave/http.cpp, line 986 > > > > > > Add this new field in the output of help, i.e. `string > > Slave::Http::STATE_HELP()`? > > Jiang Yan Xu wrote: >

Re: Review Request 51871: Modified the `isolate` method to be nesting aware.

Ah, that simplifies things. In that case don't think there should be any change to `status`. On Fri, Sep 16, 2016 at 9:02 PM, Jie Yu wrote: > In fact, in MVP, 'status' won't be called for nested containers. > Containerizer will enforce that. > > On Fri, Sep 16, 2016 at 9:01 PM, Avinash Sridharan