Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

> On Sept. 18, 2016, 3:33 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 245 > > > > > > I think we can still call parseExecutorRunPath first. Then, we can call > > parseC

Re: Review Request 52007: Added nested container helper 'parseSandboxPath()'.

> On Sept. 18, 2016, 2:36 p.m., Jie Yu wrote: > > src/slave/paths.cpp, lines 106-122 > > > > > > Do you also want to update the comments about the layout in paths.hpp? Will update the comments in paths.hpp later.

Re: Review Request 52010: Supported filesystem linux isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52010/ --- (Updated Sept. 27, 2016, 10:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 52007: Added nested container helper 'parseSandboxPath()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52007/ --- (Updated Sept. 27, 2016, 10:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/#review150684 --- Patch looks great! Reviews applied: [51028, 51027, 51621] Passed

Re: Review Request 52328: Added a test for health check failure to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52328/#review150682 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp (li

Re: Review Request 52334: Removed 'directory' in nested container launch interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52334/ --- (Updated Sept. 27, 2016, 10:01 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52334: Removed 'directory' in nested container launch interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52334/#review150680 --- Fix it, then Ship it! src/slave/containerizer/mesos/containeri

Re: Review Request 52331: Increased the resources used by the default executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52331/#review150681 --- src/tests/slave_recovery_tests.cpp (line 562)

Re: Review Request 52333: Added a parent DESTROYING check for nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52333/#review150678 --- Ship it! - Jie Yu On Sept. 28, 2016, 4 a.m., Gilbert Song wro

Re: Review Request 52331: Increased the resources used by the default executor test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52331/ --- (Updated Sept. 28, 2016, 4:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52330: Fixed the race between launch and destroy in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52330/#review150675 --- src/slave/containerizer/composing.cpp (lines 352 - 356)

Re: Review Request 52317: Fixed default executor to honor the default task group restart policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52317/ --- (Updated Sept. 28, 2016, 4:03 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52328: Added a test for health check failure to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52328/ --- (Updated Sept. 28, 2016, 4:03 a.m.) Review request for mesos and Vinod Kone.

Review Request 52334: Removed 'directory' in nested container launch interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52334/ --- Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, Jie Yu,

Review Request 52333: Added a parent DESTROYING check for nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52333/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Vinod

Re: Review Request 52064: Support for multiple versions of docs.

> On Sept. 28, 2016, 3:20 a.m., haosdent huang wrote: > > Get this error during build. > > > > ``` > > git version 2>&1:sh: git: command not found > > /mesos/site/Rakefile:4:in `' > > (See full trace by running task with --trace) > > rake aborted! > > git version 2>&1:sh: git: command not

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review150674 --- site/Rakefile (lines 35 - 39)

Review Request 52331: Disabled the reconnect test for default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52331/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6264 https://issues.ap

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/ --- (Updated 九月 28, 2016, 3:38 a.m.) Review request for mesos, Benjamin Mahler, Jac

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review150673 --- Get this error during build. ``` git version 2>&1:sh: git: com

Review Request 52330: Fixed the race between launch and destroy in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52330/ --- Review request for mesos, Benjamin Mahler and Gilbert Song. Repository: mesos

Review Request 52329: Fixed logging in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52329/ --- Review request for mesos, Benjamin Mahler and Gilbert Song. Repository: mesos

Re: Review Request 52328: Added a test for health check failure to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52328/#review150672 --- Bad patch! Reviews applied: [52328, 52326, 52317] Failed command

Re: Review Request 52317: Fixed default executor to honor the default task group restart policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52317/ --- (Updated Sept. 28, 2016, 2:59 a.m.) Review request for mesos and Vinod Kone.

Review Request 52328: Added a test for health check failure to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52328/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6230 https://issues.ap

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review150668 --- Patch looks great! Reviews applied: [45962, 45963, 45967, 49571]

Re: Review Request 52327: Updated agent to handle false case from nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52327/#review150665 --- Ship it! Ship It! - Gilbert Song On Sept. 27, 2016, 6:18 p.m

Re: Review Request 52327: Updated agent to handle false case from nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52327/#review150664 --- Ship it! Ship It! - Vinod Kone On Sept. 28, 2016, 1:18 a.m.,

Review Request 52327: Updated agent to handle false case from nested container launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52327/ --- Review request for mesos, Gilbert Song and Vinod Kone. Bugs: MESOS-6241 htt

Re: Review Request 52326: Added HTTP/TCP health check support to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52326/#review150663 --- Ship it! Ship It! - Vinod Kone On Sept. 28, 2016, 12:56 a.m.

Re: Review Request 52317: Fixed default executor to honor the default task group restart policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52317/#review150662 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp (li

Review Request 52326: Added HTTP/TCP health check support to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52326/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6230 https://issues.ap

Re: Review Request 52325: Properly handle stopped child in the 'init' process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52325/#review150661 --- Ship it! Ship It! - Benjamin Hindman On Sept. 28, 2016, 12:4

Review Request 52325: Properly handle stopped child in the 'init' process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52325/ --- Review request for mesos, Benjamin Hindman, Gilbert Song, and Kevin Klues. Repo

Re: Review Request 52321: Fixed composing containerizer to handled nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52321/#review150658 --- src/slave/containerizer/composing.cpp (lines 491 - 497)

Re: Review Request 52320: Fixed port_mapping isolator unit test CGROUPS_ROOT_CleanUpOrphan.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52320/#review150660 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2016, 10:02 p.m., Gi

Re: Review Request 52321: Fixed composing containerizer to handled nested containers.

> On Sept. 27, 2016, 10:35 p.m., Gilbert Song wrote: > > src/slave/containerizer/composing.cpp, line 456 > > > > > > just some nits: > > we dont use `'` for containerId in our code. > > Gilbert Song wrote: >

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Sept. 28, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Sept. 28, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 28, 2016, 12:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated Sept. 28, 2016, 12:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52317: Fixed default executor to honor the default task group restart policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52317/#review150654 --- Patch looks great! Reviews applied: [52317] Passed command: expo

Re: Review Request 52319: Fixed unit test 'ROOT_XFS_QuotaTest.NoCheckpointRecovery'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52319/#review150653 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2016, 10:02 p.m., Gi

Re: Review Request 52321: Fixed composing containerizer to handled nested containers.

> On Sept. 27, 2016, 3:35 p.m., Gilbert Song wrote: > > src/slave/containerizer/composing.cpp, line 456 > > > > > > just some nits: > > we dont use `'` for containerId in our code. Drop it. Let's fix it later.

Re: Review Request 52321: Fixed composing containerizer to handled nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52321/#review150643 --- Fix it, then Ship it! +1 on Gilbert's nit. src/slave/containe

Re: Review Request 52321: Fixed composing containerizer to handled nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52321/#review150635 --- Fix it, then Ship it! src/slave/containerizer/composing.cpp (l

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review150634 --- Patch looks great! Reviews applied: [52308, 52309, 52310, 52311]

Review Request 52321: Fixed composing containerizer to handled nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52321/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gilbert Song, and Jie

Review Request 52320: Fixed port_mapping isolator unit test CGROUPS_ROOT_CleanUpOrphan.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52320/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, Jie Yu, Joseph Wu,

Review Request 52319: Fixed unit test 'ROOT_XFS_QuotaTest.NoCheckpointRecovery'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52319/ --- Review request for mesos, Anand Mazumdar, Artem Harutyunyan, Jie Yu, Joseph Wu,

Re: Review Request 52286: Enabled 'volume/sandbox_path' isolator in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52286/#review150632 --- Ship it! Ship It! - Joseph Wu On Sept. 26, 2016, 4:16 p.m.,

Re: Review Request 52285: Added 'volume/sandbox_path' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52285/#review150631 --- Fix it, then Ship it! LGTM! src/slave/containerizer/mesos/iso

Re: Review Request 52006: Supported docker/volume isolator to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52006/#review150629 --- Also want to confirm one thing: We cannot make sure if all of the

Review Request 52318: Added tests for 'volume/sandbox_path' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52318/ --- Review request for mesos, Gilbert Song and Joseph Wu. Repository: mesos Descr

Re: Review Request 52285: Added 'volume/sandbox_path' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52285/ --- (Updated Sept. 27, 2016, 9:23 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52315: Windows: Fixed build by adding a stub for `strsignal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52315/ --- (Updated Sept. 27, 2016, 2:16 p.m.) Review request for mesos, Daniel Pravat, Ar

Re: Review Request 52316: Fixed type mismatch in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52316/#review150623 --- Ship it! Ship It! - Benjamin Hindman On Sept. 27, 2016, 8:58

Re: Review Request 52316: Fixed type mismatch in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52316/#review150622 --- Ship it! Ship It! - Gilbert Song On Sept. 27, 2016, 1:58 p.m

Review Request 52317: Fixed default executor to honor the default task group restart policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52317/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6262 https://issues.ap

Review Request 52315: Windows: Fixed build by adding a stub for `strsignal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52315/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Vinod Kone. Rep

Review Request 52316: Fixed type mismatch in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52316/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Vinod Kone. Rep

Re: Review Request 51999: Refactor parsing of resources.

> On 九月 27, 2016, 5:28 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 587-617 > > > > > > Is the following cleaner? (I added the logic to validate resources in > > the result vector instead of implici

Re: Review Request 51999: Refactor parsing of resources.

> On 九月 22, 2016, 10:14 p.m., Guangya Liu wrote: > > src/common/resources.cpp, line 677 > > > > > > I think that we should still use > > `internal::validateCommandLineResources` as the command line resources > > sh

Re: Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- (Updated Sept. 27, 2016, 7:59 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Sept. 27, 2016, 7:59 p.m.) Review request for mesos and Joseph Wu. B

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Sept. 27, 2016, 7:59 p.m.) Review request for mesos and Joseph Wu. B

Review Request 52309: Pass the user variable from library to binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52309/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apa

Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apa

Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apa

Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5856 https://issues.apa

Re: Review Request 52285: Added 'volume/sandbox_path' isolator.

> On Sept. 27, 2016, 12:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp, lines > > 176-183 > > > > > > Is upwards traversal allowed here? (Should we validate?) > > Jie

Re: Review Request 52285: Added 'volume/sandbox_path' isolator.

> On Sept. 27, 2016, 12:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp, lines > > 159-164 > > > > > > The comment on `container_path` in the `Volume` proto says: > >

Re: Review Request 52285: Added 'volume/sandbox_path' isolator.

> On Sept. 27, 2016, 12:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp, lines > > 159-164 > > > > > > The comment on `container_path` in the `Volume` proto says: > >

Re: Review Request 52305: Removed `CHECK` for no-existent resolv.conf for root containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52305/#review150594 --- Ship it! Ship It! - Jie Yu On Sept. 27, 2016, 5:58 p.m., Avi

Re: Review Request 52301: Added test case `HealthCheckTest.HealthyTaskViaHTTPWithoutType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52301/#review150593 --- Patch looks great! Reviews applied: [51803, 51560, 52301] Passed

Review Request 52305: Removed `CHECK` for no-existent resolv.conf for root containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52305/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6259 https://issues.apache

Re: Review Request 52285: Added 'volume/sandbox_path' isolator.

> On Sept. 27, 2016, 12:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp, lines > > 176-183 > > > > > > Is upwards traversal allowed here? (Should we validate?) I have

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review150581 --- include/mesos/resources.hpp (lines 191 - 192)

Re: Review Request 52062: Fixed warnings in `numify.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52062/#review150579 --- Ship it! Ship It! - Michael Park On Sept. 26, 2016, 9:37 p.m

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review150578 --- Patch looks great! Reviews applied: [52250, 52251, 52252, 52253]

Re: Review Request 51999: Refactor parsing of resources.

> On Sept. 27, 2016, 10:28 a.m., Jiang Yan Xu wrote: > > src/tests/resources_tests.cpp, lines 630-657 > > > > > > With out refactor, the result of `Resources::parse()` doesn't change > > right? s/out/our/ - Jiang

Re: Review Request 51999: Refactor parsing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review150494 --- include/mesos/resources.hpp (lines 56 - 64)

Re: Review Request 51999: Refactor parsing of resources.

> On Sept. 20, 2016, 10 a.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, lines 60-64 > > > > > > We can get rid of this forward declaration if we can get rid of the > > internal convertJSON. > > Anindya Si

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 3:33 p.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 238 > > > > > > Asked this already. In case of flattening, w

Re: Review Request 51560: Support health check without specifying `type`.

> On Sept. 26, 2016, 5:22 p.m., Jiang Yan Xu wrote: > > src/health-check/health_checker.cpp, lines 185-189 > > > > > > How about the following? > > > > ``` > > if (check.has_command() && !check.has_http

Re: Review Request 51560: Support health check without specifying `type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 27, 2016, 3:38 p.m.) Review request for mesos, Alexander Ruklets

Review Request 52301: Added test case `HealthCheckTest.HealthyTaskViaHTTPWithoutType`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52301/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and Jian

Re: Review Request 51560: Support health check without specifying `type`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 27, 2016, 3:36 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 27, 2016, 3:35 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review150568 --- Ship it! Ship It! - Gastón Kleiman On Sept. 23, 2016, 3:28 p

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/#review150566 --- Ship it! Ship It! - Gastón Kleiman On Sept. 27, 2016, 2:54 p

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/#review150565 --- Ship it! Ship It! - Gastón Kleiman On Sept. 27, 2016, 2:54 p

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSegmentsIterator.java, > > line 36 > > > > > > The 2 impls of this have diff wrt Scan

Re: Review Request 52251: Added test case `HealthCheckTest.HealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Sept. 27, 2016, 2:53 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52250: Added test case `HealthCheckTest.HealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Sept. 27, 2016, 2:53 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52252: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52252/ --- (Updated Sept. 27, 2016, 2:54 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52253: Added test case `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52253/ --- (Updated Sept. 27, 2016, 2:54 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 238 > > > > > > Asked this already. In case of flattening,

Re: Review Request 51785: [HBASE-16608] Merge for the segments in the compaction pipeline and simplifying the user interface for in-memory flush

> On Sept. 27, 2016, 10:03 a.m., Anoop Sam John wrote: > > hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreCompactor.java, > > line 48 > > > > > > Why changed from 4 to 2? We have 4 refs no?

  1   2   >