Re: Review Request 50499: Added logic in master/main.cpp to use pid_group module.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/ --- (Updated Oct. 10, 2016, 6:52 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50838: Updated modules documentation to reflect PIDGroup module.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50838/ --- (Updated Oct. 10, 2016, 6:53 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50498: Added --pid_group flag in master.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50498/ --- (Updated Oct. 10, 2016, 6:52 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50497: Added new constructors in Log and LogProcess.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50497/ --- (Updated Oct. 10, 2016, 6:51 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50496: Added static `createPIDGroup` method to LogProcess.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50496/ --- (Updated Oct. 10, 2016, 6:51 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50495: Added PIDGroup module struct.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50495/ --- (Updated Oct. 10, 2016, 6:51 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50494: Remove `base` from ZooKeeperPIDGroup.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50494/ --- (Updated Oct. 10, 2016, 6:50 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50493: Added `base` to PIDGroup.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50493/ --- (Updated Oct. 10, 2016, 6:50 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50490: Separated ZooKeeper PIDGroup implementation into its own cpp/hpp.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50490/ --- (Updated Oct. 10, 2016, 6:48 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50492: Switched replicated log to use PIDGroup.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/ --- (Updated Oct. 10, 2016, 6:48 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 50491: Added PIDGroup to libprocess.

2016-10-09 Thread Jay Guo
> On Sept. 30, 2016, midnight, Joseph Wu wrote: > > 3rdparty/libprocess/include/process/pid_group.hpp, line 98 > > > > > > Hm, why is this in the header? It can easily go into the .cpp file. `PIDGroup::broadcast` is

Re: Review Request 50491: Added PIDGroup to libprocess.

2016-10-09 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50491/ --- (Updated Oct. 10, 2016, 6:43 a.m.) Review request for mesos and Joseph Wu. Ch

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

2016-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/#review151954 --- Bad review! Reviews applied: [51621, 51027] Error: No reviewers

Re: Review Request 51607: Used mesos-tcp-connect binary in TCP health checks.

2016-10-09 Thread Avinash sridharan
> On Sept. 6, 2016, 6:54 p.m., Avinash sridharan wrote: > > src/health-check/health_checker.cpp, line 520 > > > > > > This more of a question: > > Why is the --host hard coded to the `DEFAULT_DOMAIN`. What if the

Re: Review Request 51621: WIP: Made recovered resource allocated as soon as possible.

2016-10-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/ --- (Updated 十月 10, 2016, 5:01 a.m.) Review request for mesos, Benjamin Mahler, Jac

Re: Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/#review151952 --- Patch looks great! Reviews applied: [52671] Passed command: expo

Review Request 52671: Modified the `--network_cni_plugins_dir` flag.

2016-10-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52671/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6344 https://i

Re: Review Request 52668: Refactored nested container tests launcher orphans.

2016-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52668/#review151942 --- Patch looks great! Reviews applied: [52667, 52668] Passed comman

Review Request 52668: Refactored nested container tests launcher orphans.

2016-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52668/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Desc

Review Request 52667: Added mesos test helper 'createCommandInfo()'.

2016-10-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52667/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos Desc

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

2016-10-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50947/#review151938 --- src/slave/containerizer/mesos/isolators/gpu/allocator.cpp (line 1

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review151937 --- src/docker/docker.hpp (lines 95 - 120)

Re: Review Request 50599: Assigned Nvidia GPU devices to docker container.

2016-10-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review151933 --- src/slave/containerizer/docker.cpp (line 677)

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-10-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/#review151936 --- src/slave/containerizer/docker.hpp (line 76)