Re: Review Request 53127: Added the test `ProvisionerDockerWhiteoutTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53127/ --- (Updated Oct. 27, 2016, 1:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53128: Adding fromString test in UUIDTest testcase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53128/#review153982 --- Ship it! Ship It! - Timothy Chen On Oct. 26, 2016, 5:18

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/ --- (Updated Oct. 27, 2016, 4:54 a.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53201: Mentioned the minimum required GPU drivers for GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53201/#review153980 --- Patch looks great! Reviews applied: [53201] Passed command:

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/ --- (Updated Oct. 27, 2016, 4:10 a.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53193: Show the leading master's information in `/master/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53193/ --- (Updated Oct. 27, 2016, 4:10 a.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53138: Fix build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/ --- (Updated Oct. 27, 2016, 3:55 a.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53136: Emit the build options at the end of configure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53136/ --- (Updated Oct. 27, 2016, 3:55 a.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53137: Fix build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/ --- (Updated Oct. 27, 2016, 3:55 a.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53196: Fixed a typo in 'tests/containerizer.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53196/#review153977 --- Ship it! Ship It! - haosdent huang On Oct. 26, 2016, 4:56

Re: Review Request 53113: Added benchmark for measuring call ingestion throughput.

> On Oct. 25, 2016, 8:28 p.m., Vinod Kone wrote: > > Can you paste numbers for the benchmark in the testing section for > > posterity? My bad, fixed. > On Oct. 25, 2016, 8:28 p.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 1822 > >

Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/#review153973 --- Patch looks great! Reviews applied: [53208] Passed command:

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

> On Oct. 27, 2016, 1:34 a.m., Joseph Wu wrote: > > src/cli_new/bin/mesos-cli-tests, line 5 > > > > > > This isn't always true, as my build folder could be named anything. > > > > If you need to depend on

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51008/#review153936 --- src/cli_new/bin/mesos-cli-tests (line 5)

Re: Review Request 53201: Mentioned the minimum required GPU drivers for GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53201/ --- (Updated Oct. 26, 2016, 5:31 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53201: Mentioned the minimum required GPU drivers for GPU support.

> On Oct. 26, 2016, 12:17 p.m., Benjamin Mahler wrote: > > docs/gpu-support.md, line 9 > > > > > > Perhaps also add CUDA 6.5+ here given Jonathan's comment in the ticket? Hum... We only mention CUDA in the

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review153967 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999,

Re: Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/#review153961 --- src/master/master.cpp (line 2482)

Review Request 53208: Fixed Master that leaks empty entries in its hashmaps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53208/ --- Review request for mesos, (Disabled_DoNotUse) Anindya Sinha, Megha Sharma, and

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

> On Oct. 26, 2016, 2:54 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, line 6047 > > > > > > If neither of the above is true, can we log a warning? We recommend > > aganist this situation but in operations

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ --- (Updated Oct. 26, 2016, 10:40 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

> On Oct. 26, 2016, 2:43 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, lines 6036-6037 > > > > > > Assuming frameworks are not partition-aware based on the agent verison > > doesn't feel right. > > > >

Re: Review Request 53201: Mentioned the minimum required GPU drivers for GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53201/#review153957 --- Patch looks great! Reviews applied: [53201] Passed command:

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review153955 --- Fix it, then Ship it!

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

> On Oct. 26, 2016, 9:54 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, line 6047 > > > > > > If neither of the above is true, can we log a warning? We recommend > > aganist this situation but in operations

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

> On Oct. 26, 2016, 9:43 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, lines 6036-6037 > > > > > > Assuming frameworks are not partition-aware based on the agent verison > > doesn't feel right. > > > >

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53202/#review153950 --- src/master/master.cpp (line 6044)

Re: Review Request 53202: Avoided CHECK failure with pre-1.0 agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53202/#review153939 --- src/master/master.cpp (lines 6036 - 6037)

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/#review153937 --- Patch looks great! Reviews applied: [53193, 53172] Passed

Review Request 53203: Fixed code style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53203/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 53193: Show the leading master's information in `/master/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53193/#review153933 --- Fix it, then Ship it! src/master/http.cpp (line 2624)

Re: Review Request 53201: Mentioned the minimum required GPU drivers for GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53201/#review153928 --- Ship it! Ship It! - Kevin Klues On Oct. 26, 2016, 7:01

Re: Review Request 53201: Mentioned the minimum required GPU drivers for GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53201/#review153927 --- Ship it! docs/gpu-support.md (line 9)

Re: Review Request 53128: Adding fromString test in UUIDTest testcase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53128/#review153918 --- Patch looks great! Reviews applied: [53128] Passed command:

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- (Updated Oct. 26, 2016, 5 p.m.) Review request for mesos, Alexander Rukletsov,

Review Request 53197: Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53197/ --- Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till

Review Request 53196: Fixed a typo in 'tests/containerizer.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53196/ --- Review request for mesos, Alexander Rukletsov, haosdent huang, Jie Yu, Till

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/ --- (Updated Oct. 26, 2016, 4:29 p.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53193: Show the leading master's information in `/master/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53193/ --- (Updated Oct. 26, 2016, 4:29 p.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/ --- (Updated Oct. 26, 2016, 4:22 p.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53193: Show the leading master's information in endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53193/ --- (Updated Oct. 26, 2016, 4:22 p.m.) Review request for mesos, Joseph Wu, Vinod

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53172/ --- (Updated Oct. 26, 2016, 4:01 p.m.) Review request for mesos, Joseph Wu, Vinod

Review Request 53193: Show the leading master's information in endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53193/ --- Review request for mesos, Joseph Wu, Vinod Kone, and Jiang Yan Xu. Bugs:

Re: Review Request 53172: Fixed the broken metrics information of master in WebUI.

> On Oct. 25, 2016, 6:51 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 402 > > > > > > So `pollMetrics` makes the request directly to the leading master > > whereas `pollState` depends

Re: Review Request 52786: Add the health check test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153871 --- src/Makefile.am (line 1006)

Re: Review Request 53128: Adding fromString test in UUIDTest testcase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53128/#review153855 --- Ship it! Ship It! - haosdent huang On Oct. 26, 2016, 5:18