Re: Review Request 52718: Added mesos v1 test helper 'v1::createCallAccept()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52718/#review154868 --- Ship it! Ship It! - Jie Yu On Nov. 4, 2016, 12:38 a.m.,

Re: Review Request 52718: Added mesos v1 test helper 'v1::createCallAccept()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52718/#review154864 --- src/tests/mesos.hpp (lines 1470 - 1484)

Re: Review Request 53449: Added mesos test v1 scheduler default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53449/#review154863 --- src/tests/mesos.hpp (line 1829)

Re: Review Request 53448: Added mesos test helper for LAUNCH_GROUP offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53448/#review154861 --- Ship it! Ship It! - Jie Yu On Nov. 4, 2016, 12:32 a.m.,

Re: Review Request 52714: Added optional 'Type' to createExecutorInfo().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52714/#review154860 --- Ship it! Ship It! - Jie Yu On Nov. 4, 2016, 12:33 a.m.,

Re: Review Request 53447: Added mesos test helper 'createTaskGroupInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53447/#review154859 --- Fix it, then Ship it! src/tests/mesos.hpp (lines 1291 - 1296)

Re: Review Request 52667: Added mesos test helper 'createCommandInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52667/#review154858 --- Fix it, then Ship it! src/tests/mesos.hpp (lines 1028 - 1035)

Re: Review Request 53266: Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154855 --- As I was suggesting in the ticket, could we leverage the

Re: Review Request 53451: Added agent API protos for executing and attaching nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53451/#review154851 --- Patch looks great! Reviews applied: [53450, 53451] Passed

Re: Review Request 53266: Refactored `DefaultExecutorTest.ROOT_TaskRunning` [1/3].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154850 --- src/tests/default_executor_tests.cpp (line 64)

Re: Review Request 52612: Added nested container tests for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52612/ --- (Updated Nov. 3, 2016, 5:41 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 53447: Added mesos test helper 'createTaskGroupInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53447/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Joris Van Remoortere.

Review Request 53449: Added mesos test v1 scheduler default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53449/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Joris Van Remoortere.

Re: Review Request 52718: Added mesos v1 test helper 'v1::createCallAccept()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52718/ --- (Updated Nov. 3, 2016, 5:38 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52718: Added mesos v1 test helper 'v1::createCallAccept()'.

> On Oct. 10, 2016, 7:56 p.m., Anand Mazumdar wrote: > > src/tests/mesos.hpp, lines 957-971 > > > > > > We won't need this if we add an action `LaunchTasks` as per my earlier > > comment. We use

Review Request 53451: Added agent API protos for executing and attaching nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53451/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Jie Yu, and Kevin

Re: Review Request 53450: Added TTYInfo to ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53450/ --- (Updated Nov. 4, 2016, 12:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52714: Added optional 'Type' to createExecutorInfo().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52714/ --- (Updated Nov. 3, 2016, 5:33 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 53450: Added TTYInfo to ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53450/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, Jie Yu, and Kevin

Re: Review Request 52668: Refactored nested container tests launcher orphans.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52668/ --- (Updated Nov. 3, 2016, 5:33 p.m.) Review request for mesos, Benjamin Hindman

Review Request 53448: Added mesos test helper for LAUNCH_GROUP offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53448/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Joris Van Remoortere.

Re: Review Request 52667: Added mesos test helper 'createCommandInfo()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52667/ --- (Updated Nov. 3, 2016, 5:31 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 53411: Use a random TCP port for framework tests.

> On Nov. 3, 2016, 8:16 p.m., Vinod Kone wrote: > > src/tests/balloon_framework_test.sh, line 73 > > > > > > why did you pick these particular numbers? Chosen at random; we could use anything between 1024 and 65535.

Re: Review Request 52642: Improved the validation of RESERVE operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review154824 --- Thanks Gaston! The fix looks good, but some of the tests don't

Re: Review Request 53437: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53437/#review154823 --- Ship it! Ship It! - Kapil Arya On Nov. 3, 2016, 4:11 p.m.,

Re: Review Request 53137: Fix Mesos build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/#review154822 --- Ship it! Ship It! - Kapil Arya On Nov. 3, 2016, 1:09 p.m.,

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/#review154819 --- Patch looks great! Reviews applied: [53378, 53407, 53406, 53385]

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

> On Nov. 3, 2016, 8:40 p.m., Vinod Kone wrote: > > docs/release-guide.md, lines 14-16 > > > > > > If you want to make the list unordered you should use "*". Seems weird > > to use `1` here. > > Alexander Rukletsov

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/ --- (Updated Nov. 3, 2016, 9:37 p.m.) Review request for mesos, Joris Van

Re: Review Request 53383: Updated the release guide with the instructions regarding CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53383/ --- (Updated Nov. 3, 2016, 9:33 p.m.) Review request for mesos, Joris Van

Re: Review Request 53429: Updated the release guide with handy JIRA queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53429/ --- (Updated Nov. 3, 2016, 9:33 p.m.) Review request for mesos, Joris Van

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53382/ --- (Updated Nov. 3, 2016, 9:33 p.m.) Review request for mesos, Joris Van

Re: Review Request 53381: Added a section about unresolved issues to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/ --- (Updated Nov. 3, 2016, 9:32 p.m.) Review request for mesos, Joris Van

Re: Review Request 53381: Added a section about unresolved issues to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/#review154815 --- Ship it! Ship It! - Till Toenshoff On Nov. 3, 2016, 1:33

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

> On Nov. 3, 2016, 8:40 p.m., Vinod Kone wrote: > > docs/release-guide.md, lines 14-16 > > > > > > If you want to make the list unordered you should use "*". Seems weird > > to use `1` here. > > Alexander Rukletsov

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/ --- (Updated Nov. 3, 2016, 9:27 p.m.) Review request for mesos, Joris Van

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

> On Nov. 3, 2016, 8:40 p.m., Vinod Kone wrote: > > docs/release-guide.md, lines 14-16 > > > > > > If you want to make the list unordered you should use "*". Seems weird > > to use `1` here. It's autonumeration : )

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

> On Nov. 3, 2016, 8:31 p.m., Vinod Kone wrote: > > CHANGELOG, lines 126-128 > > > > > > These ticket summaries could use repharsing. They don't read great as > > feature descriptions. This is true, but the reason

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 3, 2016, 6:18 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, lines 383-399 > > > > > > Do you need to do this if the container class is DEBUG? Since you are > >

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53382/#review154807 --- Ship it! Modulo Vinod's comments. - Till Toenshoff On Nov.

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/#review154800 --- Fix it, then Ship it! Thanks for doing this! Can you link a

Re: Review Request 53383: Updated the release guide with the instructions regarding CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53383/#review154797 --- Ship it! docs/release-guide.md (line 83)

Re: Review Request 53429: Updated the release guide with handy JIRA queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53429/#review154799 --- Ship it! Ship It! - Vinod Kone On Nov. 3, 2016, 2:12 p.m.,

Re: Review Request 53383: Updated the release guide with the instructions regarding CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53383/#review154798 --- Ship it! Ship It! - Vinod Kone On Nov. 3, 2016, 1:34 p.m.,

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53382/#review154796 --- Fix it, then Ship it! CHANGELOG (line 113)

Re: Review Request 53429: Updated the release guide with handy JIRA queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53429/#review154794 --- Ship it! Thanks Alex! docs/release-guide.md (lines 66 - 67)

Re: Review Request 53411: Use a random TCP port for framework tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53411/#review154795 --- src/tests/balloon_framework_test.sh (line 73)

Re: Review Request 53437: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53437/ --- (Updated Nov. 3, 2016, 8:11 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53437: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53437/#review154793 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 3, 2016, 6:18 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp, line 330 > > > > > > Can you make sure if the container is in DEBUG class, the rootfs is not > > set?

Re: Review Request 53118: Fixed incorrect header order in `cni.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53118/#review154792 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 24, 2016,

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/#review154787 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 3, 2016,

Re: Review Request 53435: Fixed header include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53435/#review154786 --- Patch looks great! Reviews applied: [53386, 53387, 53435]

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/#review154782 --- See my comments for the filesystem isolator. You probably should

Re: Review Request 53387: Avoided memory leaks in exception/error paths in tests.

> On Nov. 3, 2016, 4:49 p.m., Benjamin Bannier wrote: > > Looks really good, thanks. Added a couple more nits re:potential leaks > > apparently undetected by `clang-tidy`. Due to MESOS-6496, I think it will be a bit ugly to fix this at the moment. I'd prefer to ignore this for now and revisit

Review Request 53437: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53437/ --- Review request for mesos. Repository: mesos Description --- Fix all the

Re: Review Request 53137: Fix Mesos build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/ --- (Updated Nov. 3, 2016, 5:09 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53136: Emit the build options at the end of configure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53136/ --- (Updated Nov. 3, 2016, 5:10 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53138: Fix libprocess build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/ --- (Updated Nov. 3, 2016, 5:09 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

> On Nov. 3, 2016, 3:57 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 3921 > > > > > > I'm surprised to find out that we don't have `DockerExecutorTest` > >

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 3, 2016, 4:58 p.m.) Review request for mesos, Alexander

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 3, 2016, 4:49 p.m.) Review request for mesos, Alexander

Re: Review Request 53387: Avoided memory leaks in exception/error paths in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/#review154753 --- Looks really good, thanks. Added a couple more nits re:potential

Re: Review Request 53428: Fixed the order of includes in launcher/executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53428/#review154755 --- Patch looks great! Reviews applied: [52878, 53084, 53196, 53197,

Re: Review Request 53387: Avoided memory leaks in exception/error paths in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53387/ --- (Updated Nov. 3, 2016, 4:23 p.m.) Review request for mesos and Joseph Wu.

Review Request 53435: Fixed header include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53435/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 3, 2016, 4:08 p.m.) Review request for mesos, Alexander

Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53406/ --- (Updated Nov. 3, 2016, 4:08 p.m.) Review request for mesos, Alexander

Re: Review Request 53407: Fixed the Docker executor to not generate RUNNING after KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53407/ --- (Updated Nov. 3, 2016, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 3, 2016, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53406/ --- (Updated Nov. 3, 2016, 4:05 p.m.) Review request for mesos, Alexander

Re: Review Request 53428: Fixed the order of includes in launcher/executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53428/ --- (Updated Nov. 3, 2016, 4:01 p.m.) Review request for mesos and Alexander

Re: Review Request 53428: Fixed the order of includes in launcher/executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53428/#review154746 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 3, 2016,

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/#review154713 --- src/tests/containerizer/docker_containerizer_tests.cpp (lines

Re: Review Request 52787: Reorganized the work directory and the runtime directory in local mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review154738 --- src/local/flags.hpp (lines 35 - 45)

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

> On Nov. 1, 2016, 10:08 p.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya

Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.

> On Nov. 3, 2016, 3:36 p.m., Alexander Rukletsov wrote: > > src/tests/command_executor_tests.cpp, line 259 > > > > > > ash? : ) `ash` is a shell that comes with some linux distros and with Busybox, not a typo =).

Re: Review Request 53385: Added a test to ensure MESOS-6457 is fixed for the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53385/ --- (Updated Nov. 3, 2016, 3:52 p.m.) Review request for mesos, Alexander

Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53406/ --- (Updated Nov. 3, 2016, 3:51 p.m.) Review request for mesos, Alexander

Re: Review Request 53406: Added a test to ensure MESOS-6457 is fixed for the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53406/#review154712 --- Fix it, then Ship it! src/tests/command_executor_tests.cpp

Re: Review Request 53386: Fixed memory leak in JVM code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/ --- (Updated Nov. 3, 2016, 3:31 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/#review154731 --- Patch looks great! Reviews applied: [53381, 53382, 53383, 53384]

Re: Review Request 53341: Fix stout build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53341/#review154730 --- Ship it! Ship It! - Kapil Arya On Nov. 1, 2016, 12:26 p.m.,

Re: Review Request 53137: Fix Mesos build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53137/#review154719 --- Thanks for the patience, James! It mostly looks good but there

Re: Review Request 53138: Fix libprocess build option argument handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53138/#review154729 --- Ship it! Ship It! - Kapil Arya On Nov. 1, 2016, 12:24 p.m.,

Review Request 53429: Updated the release guide with handy JIRA queries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53429/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Repository:

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/ --- (Updated Nov. 3, 2016, 2:12 p.m.) Review request for mesos, Joris Van

Re: Review Request 53381: Added a section about unresolved issues to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/#review154727 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 3, 2016,

Re: Review Request 53407: Fixed the Docker executor to not generate RUNNING after KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53407/ --- (Updated Nov. 3, 2016, 1:56 p.m.) Review request for mesos, Alexander

Review Request 53428: Fixed the order of includes in launcher/executor.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53428/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 53382: Added a full list of experimental features to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53382/ --- (Updated Nov. 3, 2016, 1:34 p.m.) Review request for mesos, Joris Van

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/ --- (Updated Nov. 3, 2016, 1:34 p.m.) Review request for mesos, Joris Van

Re: Review Request 53383: Updated the release guide with the instructions regarding CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53383/ --- (Updated Nov. 3, 2016, 1:34 p.m.) Review request for mesos, Joris Van

Re: Review Request 53381: Added a section about unresolved issues to CHANGELOG for 1.1.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53381/ --- (Updated Nov. 3, 2016, 1:33 p.m.) Review request for mesos, Joris Van

Re: Review Request 53381: Added a section about unresolved issues to CHANGELOG for 1.1.0.

> On Nov. 2, 2016, 4:32 p.m., Joris Van Remoortere wrote: > > CHANGELOG, line 106 > > > > > > From the ticket MESOS-5533 seems like a documentation issue. Should we > > verify with Kapil and lower the priority so

Re: Review Request 52879: Cleaned up the way in which the executors load configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/ --- (Updated Nov. 3, 2016, 1:28 p.m.) Review request for mesos, Alexander

Re: Review Request 53407: Fixed the Docker executor to not generate RUNNING after KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53407/#review154711 --- Fix it, then Ship it! src/docker/executor.cpp (lines 298 -

Re: Review Request 53378: Fixed the command executor to not generate RUNNING after KILLING.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53378/#review154710 --- Fix it, then Ship it! src/launcher/executor.cpp (lines 305 -

Re: Review Request 53384: Cleaned up formatting in release-guide.md according to our guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53384/#review154709 --- Patch looks great! Reviews applied: [53381, 53382, 53383, 53384]

  1   2   >