Re: Review Request 53586: Added special case for entering "mnt" namespaces for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53586/#review155410 --- Patch looks great! Reviews applied: [53585, 53350, 53351, 53352,

Re: Review Request 53567: Improved CREATE operation validation error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53567/#review155406 --- Patch looks great! Reviews applied: [53567] Passed command:

Re: Review Request 53489: Added support for request streaming to the connection abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53489/#review155395 --- Fix it, then Ship it! Unrelated to this particular change, but

Re: Review Request 53582: Updated mesos-tidy image to upstream 3.9 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53582/#review155399 --- Patch looks great! Reviews applied: [53582] Passed command:

Re: Review Request 53488: Removed `convert()` continuations in favor of using `io::read()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53488/#review155391 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line

Re: Review Request 53511: Parameterized existing decoder tests on the type of decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53511/#review155388 --- Fix it, then Ship it! Very clean update to the test! I left a

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review155390 --- Can you add the stubs for the handlers that do proper

Re: Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53574/#review155389 --- Patch looks great! Reviews applied: [53573, 53574] Passed

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 8, 2016, 4:43 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/ --- (Updated Nov. 8, 2016, 4:43 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 53541: Added authorization actions for debug API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review155387 --- Can you add a link to MESOS-6474 in the Bugs field? - Kevin

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 9, 2016, 12:09 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 9, 2016, 12:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

> On Nov. 4, 2016, 11:08 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp, line 286 > > > > > > What if `!containerConfig.has_container_class` (meaning using the > > default), do you

Re: Review Request 52645: Harden Mesos

> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am, line 120 > > > > > > Not sure we want to remove the existing `-Werror`. > > Aaron Wood wrote: > From a discussion with a few people on

Re: Review Request 52645: Harden Mesos

> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am, line 120 > > > > > > Not sure we want to remove the existing `-Werror`. > > Aaron Wood wrote: > From a discussion with a few people on

Re: Review Request 52696: Harden stout

> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release this

Re: Review Request 52645: Harden Mesos

> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote: > > src/Makefile.am, line 120 > > > > > > Not sure we want to remove the existing `-Werror`. > > Aaron Wood wrote: > From a discussion with a few people on

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 10:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release

Review Request 53586: Added special case for entering "mnt" namespaces for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53586/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6543

Re: Review Request 53354: Updated namespace isolators to customize based on 'ContainerClass'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53354/ --- (Updated Nov. 8, 2016, 9:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53353: Introduced a new 'DEBUG' container class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53353/ --- (Updated Nov. 8, 2016, 9:55 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53352: Updated 'LinuxLauncher->fork()` with *enter* and *clone* namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53352/ --- (Updated Nov. 8, 2016, 9:54 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53350: Removed unnecessary 'parentHooks' parameter from 'Launcher::fork()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53350/ --- (Updated Nov. 8, 2016, 9:53 p.m.) Review request for mesos and Jie Yu.

Review Request 53585: Added a default PATH environment variable when launching a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53585/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6543

Re: Review Request 53571: Improved some operation validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53571/#review155351 --- Patch looks great! Reviews applied: [52642, 53470, 53529, 53528,

Re: Review Request 53510: Removed extraneous socket argument from `DataDecoder` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53510/#review155348 --- Fix it, then Ship it! Ship It!

Re: Review Request 53486: Introduced a streaming request decoder in libprocess.

> On Nov. 8, 2016, 4:32 a.m., Benjamin Mahler wrote: > > Let's include some tests alongside the new code, like we did on the > > response side: > > https://github.com/apache/mesos/commit/6ac8eb1c524dc4adbc09d20dcb8e4e31d60eeb56 > > > > Otherwise, the implementation looks good, but I would wait

Re: Review Request 53500: Used an environment variable to pass command environment.

> On Nov. 8, 2016, 11:56 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1499 > > > > > > This appears to break every single test that uses the Mesos > > Containerizer. > > >

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/ --- (Updated Nov. 8, 2016, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 53510: Removed extraneous socket argument from `DataDecoder` constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53510/ --- (Updated Nov. 8, 2016, 8:22 p.m.) Review request for mesos and Benjamin

Re: Review Request 53487: Wired the libprocess code to use the streaming decoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53487/ --- (Updated Nov. 8, 2016, 8:21 p.m.) Review request for mesos and Benjamin

Re: Review Request 53486: Introduced a streaming request decoder in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53486/ --- (Updated Nov. 8, 2016, 8:21 p.m.) Review request for mesos and Benjamin

Re: Review Request 53500: Used an environment variable to pass command environment.

> On Nov. 8, 2016, 11:56 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1499 > > > > > > This appears to break every single test that uses the Mesos > > Containerizer. > > >

Re: Review Request 53500: Used an environment variable to pass command environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53500/#review155338 --- src/slave/containerizer/mesos/containerizer.cpp (line 1498)

Re: Review Request 53567: Improved CREATE operation validation error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53567/#review155337 --- I think we can definitely improve how we report error messages to

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

> On Nov. 8, 2016, 1:43 a.m., Gastón Kleiman wrote: > > 3rdparty/libprocess/src/process.cpp, line 183 > > > > > > Shoulnd't port `0` be rejected? AFAIK it is not a valid port. Port zero == random port. It is

Review Request 53582: Updated mesos-tidy image to upstream 3.9 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53582/ --- Review request for mesos and switched to 'mcypark'. Repository: mesos

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review155330 --- Patch looks great! Reviews applied: [53096, 45962, 49571]

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/ --- (Updated Nov. 8, 2016, 5:43 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 8, 2016, 5:41 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 8, 2016, 5:41 p.m.) Review request for mesos, James Peach,

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 8, 2016, 5:40 p.m.) Review request for mesos, James Peach,

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 8, 2016, 5:40 p.m.) Review request for mesos, James Peach,

Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/ --- (Updated Nov. 8, 2016, 5:39 p.m.) Review request for mesos, James Peach,

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 8, 2016, 5:39 p.m.) Review request for mesos, James Peach,

Re: Review Request 52754: Remove unused code which now throws errors with the new hardening flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52754/ --- (Updated Nov. 8, 2016, 5:38 p.m.) Review request for mesos, James Peach,

Re: Review Request 53500: Used an environment variable to pass command environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53500/#review155312 --- Ship it! Ship It! - Jie Yu On Nov. 8, 2016, 4:46 p.m.,

Review Request 53567: Improved CREATE operation validation error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53567/ --- Review request for mesos, (Disabled_DoNotUse) Anindya Sinha, Greg Mann, and

Re: Review Request 53500: Used an environment variable to pass command environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53500/ --- (Updated Nov. 8, 2016, 8:46 a.m.) Review request for mesos, Anindya Sinha,

Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53574/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Review Request 53573: Added the kill policy test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53573/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 53558: Added net::IP parsing template to the flags parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/ --- (Updated Nov. 8, 2016, 2:57 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53558: Added net::IP parsing template to the flags parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/ --- (Updated Nov. 8, 2016, 2:56 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53366: Introduced a streaming gzip::Decompressor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53366/#review155287 --- Patch looks great! Reviews applied: [53365, 53366] Passed

Re: Review Request 53556: Fixed and updated provisioner utility headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53556/#review155282 --- Fix it, then Ship it! LGTM, only a couple more to go. I found

Re: Review Request 52642: Improved the validation of RESERVE operations.

> On Nov. 8, 2016, 10:37 a.m., Alexander Rukletsov wrote: > > src/tests/master_validation_tests.cpp, lines 311-313 > > > > > > This test does not do what it says. It's a copy-paste of > >

Re: Review Request 53556: Fixed and updated provisioner utility headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53556/#review155281 --- Patch looks great! Reviews applied: [53554, 53555, 53556]

Re: Review Request 52642: Improved the validation of RESERVE operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/ --- (Updated Nov. 8, 2016, 10:45 a.m.) Review request for mesos, Alexander

Re: Review Request 52642: Improved the validation of RESERVE operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review155276 --- Fix it, then Ship it! I'll fix the formatting issues and will

Re: Review Request 52642: Improved the validation of RESERVE operations.

> On Nov. 3, 2016, 10:39 p.m., Benjamin Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 346-348 > > > > > > Have you gone through these tests? They also seem confusing. For > > example, this one says

Review Request 53571: Improved some operation validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53571/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Michael

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53559/#review155277 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 53558: Added net::IP parsing template to the flags parsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53558/#review155275 --- Fix it, then Ship it!

Re: Review Request 53529: Improved the readability of the master validation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53529/ --- (Updated Nov. 8, 2016, 9:18 a.m.) Review request for mesos, Alexander

Re: Review Request 53560: LOG(FATAL) transformed into EXIT(EXIT_FAILURE) in process::initialize.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53560/#review155273 --- Patch looks great! Reviews applied: [53558, 53559, 53560]