Re: Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54628/#review158791 --- Patch looks great! Reviews applied: [54627, 54628] Passed comman

Re: Review Request 54561: Added tests for IOSwitchboard heartbeat.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54561/#review158790 --- src/tests/containerizer/io_switchboard_tests.cpp (lines 392 - 396

Re: Review Request 54560: Added a bi-directional heartbeat for IOSwitchboard connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54560/#review158789 --- Ship it! Ship It! - Vinod Kone On Dec. 11, 2016, 1:03 a.m.,

Re: Review Request 54630: Added a `http_heartbeat_interval` flag to the agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54630/#review158788 --- Fix it, then Ship it! src/slave/flags.cpp (line 270)

Re: Review Request 54632: Added agent API test for attaching input to a nested container session.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54632/#review158787 --- Ship it! Ship It! - Vinod Kone On Dec. 11, 2016, 12:56 a.m.,

Review Request 54637: Fixed EOF bug when tty is enabled in switch board server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54637/ --- Review request for mesos, Jie Yu and Kevin Klues. Repository: mesos Descripti

Re: Review Request 54620: Removed "enable_io_switchboard_server" agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54620/ --- (Updated Dec. 11, 2016, 4:39 a.m.) Review request for mesos, Anand Mazumdar, Ji

Re: Review Request 54627: Updated address of 'http::connect()' with http scheme for SSL support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/ --- (Updated Dec. 11, 2016, 4:35 a.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54628/ --- (Updated Dec. 11, 2016, 4:35 a.m.) Review request for mesos, Anand Mazumdar and

Review Request 54636: Added LOCAL_IP to disk_full_framework_test.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54636/ --- Review request for mesos and Ian Downes. Bugs: 6614 https://issues.apache.o

Re: Review Request 54631: Windows: Disambiguated `os::write` by adding another overload.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54631/#review158786 --- Bad patch! Reviews applied: [54631, 54618, 54611, 54493, 54490, 5

Re: Review Request 54620: Removed "enable_io_switchboard_server" agent flag.

> On Dec. 10, 2016, 10:36 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.hpp, line 155 > > > > > > Shouldn't this be called `isEnabled()`. When I see `enable()` this > > implies to me that

Re: Review Request 54620: Removed "enable_io_switchboard_server" agent flag.

> On Dec. 10, 2016, 10:36 p.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 1476-1481 > > > > > > Maybe this belongs in a separate patch, but we should only close > > stdinFd here

Re: Review Request 54627: Forced variant of 'http::connect()' to use POLL even when SSL enabled.

> On Dec. 11, 2016, 12:06 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1323-1326 > > > > > > Instead of hard coding it, we can add a second parameter 'kind' and let > > the caller decide what to

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

> On Dec. 10, 2016, 12:37 a.m., Jiang Yan Xu wrote: > > Can we add a simple test for `isQuotaEnabled()` in ROOT_XFS_QuotaTest? > > James Peach wrote: > I didn't add a new test because I reasoned that this is implicitly tested > already, like `pathIsXfs`. > > Jiang Yan Xu wrote: > Impli

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/#review158782 --- Patch looks great! Reviews applied: [50414, 50415, 50455, 50456,

Re: Review Request 54630: Added a `http_heartbeat_interval` flag to the agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54630/ --- (Updated Dec. 11, 2016, 1:04 a.m.) Review request for mesos, Anand Mazumdar, Ji

Re: Review Request 54560: Added a bi-directional heartbeat for IOSwitchboard connections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54560/ --- (Updated Dec. 11, 2016, 1:03 a.m.) Review request for mesos, Jie Yu and Vinod K

Review Request 54630: Added a `http_heartbeat_interval` flag to the agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54630/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Repository: m

Re: Review Request 54632: Added agent API test for attaching input to a nested container session.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54632/ --- (Updated Dec. 11, 2016, 12:56 a.m.) Review request for mesos, Anand Mazumdar, J

Review Request 54632: Added agent API test for attaching input to a nested container session.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54632/ --- Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. Bugs: MESOS-6

Re: Review Request 54618: Windows: Added trivially passable tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54618/ --- (Updated Dec. 11, 2016, 12:42 a.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 54627: Forced variant of 'http::connect()' to use POLL even when SSL enabled.

> On Dec. 11, 2016, 12:06 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1323-1326 > > > > > > Instead of hard coding it, we can add a second parameter 'kind' and let > > the caller decide what to

Re: Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54628/#review158779 --- Ship it! Ship It! - Jie Yu On Dec. 10, 2016, 6:31 p.m., Kevi

Re: Review Request 54627: Forced variant of 'http::connect()' to use POLL even when SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/#review158778 --- 3rdparty/libprocess/src/http.cpp (lines 1323 - 1326)

Review Request 54631: Windows: Disambiguated `os::write` by adding another overload.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54631/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. B

Re: Review Request 54620: Removed "enable_io_switchboard_server" agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54620/#review158776 --- src/slave/containerizer/mesos/io/switchboard.hpp (line 155)

Re: Review Request 54618: Windows: Added trivially passable tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54618/ --- (Updated Dec. 10, 2016, 10:19 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 54618: Windows: Added trivially passable tests to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54618/ --- (Updated Dec. 10, 2016, 10:06 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 54618: Windows: Added `http_tests.cpp` and `type_utils_tests.cpp` to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54618/#review158775 --- Bad patch! Reviews applied: [54618, 54611, 54493, 54490, 54489, 5

Re: Review Request 54570: Added comments around some health check limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54570/ --- (Updated Dec. 10, 2016, 9:30 p.m.) Review request for mesos, Gastón Kleiman, ha

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/#review158774 --- Patch looks great! Reviews applied: [51999, 52002, 51879, 51880,

Re: Review Request 50463: Added code to build libmesosjava shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50463/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50459: Added code to generate JNI Header files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50459/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50457/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50460: Added code to build libstate shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50460/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50458: Added code to build mesos-java.jar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50458/ --- (Updated Dec. 10, 2016, 7:19 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50455: Enabled Java builds if Java is found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50455/ --- (Updated Dec. 10, 2016, 7:18 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50456: Added custom command to generate Java protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50456/ --- (Updated Dec. 10, 2016, 7:18 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50414: Added variables for building Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50414/ --- (Updated Dec. 10, 2016, 7:18 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 50415: Added build step to build Java Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50415/ --- (Updated Dec. 10, 2016, 7:18 p.m.) Review request for mesos, Alex Clemmer and J

Re: Review Request 54545: Cleaned up expectations in api_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54545/#review158767 --- Ship it! Thanks for the cleanup! - Anand Mazumdar On Dec. 8,

Re: Review Request 54544: Added AgentAPITest.LaunchNestedContainerSessionDisconnected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54544/#review158766 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 3977)

Re: Review Request 54516: Removed the TODO in AgentAPITest.AttachContainerOutputFailure test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54516/#review158765 --- Ship it! Ship It! - Anand Mazumdar On Dec. 8, 2016, 9:52 p.m

Re: Review Request 54508: Added a TTY test for LAUNCH_NESTED_CONTAINER_SESSION.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54508/#review158587 --- Fix it, then Ship it! src/tests/api_tests.cpp (line 3861)

Review Request 54628: Changed 'Socket::create()' in IOSwitchboard to always be of 'kind' POLL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54628/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Repository: mesos Descri

Review Request 54627: Forced variant of 'http::connect()' to use POLL even when SSL enabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54627/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Joseph W

Re: Review Request 54620: Removed "enable_io_switchboard_server" agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54620/#review158764 --- Ship it! Ship It! - Jie Yu On Dec. 10, 2016, 5:08 a.m., Vino

Re: Review Request 54570: Added comments around some health check limitations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54570/#review158759 --- Ship it! Ship It! - Gastón Kleiman On Dec. 9, 2016, 3:11 p.m