Re: Review Request 52534: Dispatch filter expiration twice.

> On Dec. 12, 2016, 5 p.m., Jiang Yan Xu wrote: > > I feel it's hard to explain this patch without /r/51027/. It's probably > > better to have it go after /r/51027/ in the chain. It's fine if /r/51027/ > > requires this patch to pass the tests. Yep, this this patch is necessary because of 5102

Re: Review Request 52534: Dispatch filter expiration twice.

> On Dec. 12, 2016, 5:33 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1084-1085 > > > > > > If you want to add such a TODO, it should probably live close to > > `recoverRe

Re: Review Request 52534: Dispatch filter expiration twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/ --- (Updated Dec. 21, 2016, 6:07 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Dec. 21, 2016, 6:02 a.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 29, 2016, 3:06 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3007-3011 > > > > > > Just a question here, can we always guarantee only one `allocate()` > > will be called?

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Dec. 21, 2016, 5:58 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 54083: Made headers in stout standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54083/#review159785 --- Ship it! Ship It! - Michael Park On Dec. 14, 2016, 1:04 a.m.

Review Request 54928: Added initial random delay to agent (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54928/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and

Review Request 54927: Fixed partition to pass when `HAS_AUTHENTICATED` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54927/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and

Re: Review Request 54909: Fixed spurious registration bug in framework and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54909/ --- (Updated Dec. 21, 2016, 3:09 a.m.) Review request for mesos, Andrew Schwartzmey

Review Request 54926: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54926/ --- Review request for mesos, Benjamin Mahler and Guangya Liu. Repository: mesos

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/ --- (Updated Dec. 21, 2016, 2:19 a.m.) Review request for mesos, Xiaojian Huang, Gi

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/ --- (Updated Dec. 21, 2016, 2:16 a.m.) Review request for . Bugs: MESOS-6162

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/ --- (Updated Dec. 21, 2016, 2:16 a.m.) Review request for . Bugs: MESOS-6162

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

> On Dec. 13, 2016, 7:29 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp, lines > > 54-57 > > > > > > Let's only add defintions for proto in this file. Sure. I wa

Re: Review Request 54921: Added blog post for the 0.28.3 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54921/#review159780 --- Ship it! Ship It! - Joseph Wu On Dec. 20, 2016, 3:33 p.m., A

Re: Review Request 54920: Updated releases.yml for Mesos 0.28.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54920/#review159779 --- Ship it! Ship It! - Joseph Wu On Dec. 20, 2016, 3:33 p.m., A

Re: Review Request 54919: Fixed target version for the 1.1.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54919/#review159778 --- Ship it! Ship It! - Joseph Wu On Dec. 20, 2016, 3:34 p.m., A

Review Request 54920: Updated releases.yml for Mesos 0.28.3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54920/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 54919: Fixed target version for the 1.1.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54919/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Review Request 54921: Added blog post for the 0.28.3 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54921/ --- Review request for mesos and Joseph Wu. Repository: mesos Description ---

Re: Review Request 51028: Fix broken tests post batched event allocation.

> On Dec. 13, 2016, 4:30 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3621-3629 > > > > > > I think we are still intereted in the number of allocations and we > > expect to see th

Re: Review Request 54909: Added member to agent to avoid spurious re-registrations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54909/ --- (Updated Dec. 20, 2016, 3:18 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 54913: Added some missing log statements for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54913/ --- (Updated Dec. 20, 2016, 11:09 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 54763: Replaced `::pipe` with `os::pipe` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54763/ --- (Updated Dec. 20, 2016, 2:36 p.m.) Review request for mesos. Repository: meso

Re: Review Request 54880: Added unit-test for dynamic addition/deletion of CNI config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54880/ --- (Updated Dec. 20, 2016, 10:36 p.m.) Review request for mesos, Jie Yu and Qian Z

Re: Review Request 54593: Replaced `::lseek` with `os::lseek` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54593/ --- (Updated Dec. 20, 2016, 2:36 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54596: Replaced `::dup` with `os::dup` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54596/ --- (Updated Dec. 20, 2016, 2:35 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54603: Replaced `int` with `int_fd` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54603/ --- (Updated Dec. 20, 2016, 2:34 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54602/ --- (Updated Dec. 20, 2016, 2:33 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- (Updated Dec. 20, 2016, 10:32 p.m.) Review request for mesos, Adam B, Andrew Sc

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54601/ --- (Updated Dec. 20, 2016, 2:32 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54762/ --- (Updated Dec. 20, 2016, 2:31 p.m.) Review request for mesos. Summary (updated

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/ --- (Updated Dec. 20, 2016, 2:30 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Dec. 20, 2016, 2:31 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Dec. 20, 2016, 2:29 p.m.) Review request for mesos and Daniel Pravat.

Re: Review Request 54889: Handled all possible offers in test.

> On Dec. 20, 2016, 5:41 p.m., Neil Conway wrote: > > Can we add an expectation for exactly when we expect to receive the offer? > > i.e., another `WillOnce(FutureSatisfy(...))` and then wait for the future > > at the appropriate time. > > > > The thing I don't like about the `WillRepeatedly(.

Re: Review Request 54889: Handled all possible offers in test.

- Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54889/#review159727 --- On Dec. 20, 2016, 11:15 p.m., Benjamin Bannier wrote:

Re: Review Request 54889: Handled all possible offers in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54889/ --- (Updated Dec. 20, 2016, 11:15 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 54910: Fixed more tests to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54910/ --- (Updated Dec. 20, 2016, 10:09 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 53716: Used `Shell::entrypoint`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53716/#review159755 --- Fix it, then Ship it! I can tweak this before committing. src

Re: Review Request 54828: Fixed flags::fetch() to support Windows file paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54828/#review159757 --- 3rdparty/stout/include/stout/flags/fetch.hpp (line 54)

Re: Review Request 54913: Added some missing log statements for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54913/#review159756 --- Fix it, then Ship it! src/master/master.cpp (line 4697)

Re: Review Request 53715: Define docker `--entrypoint` for `Windows`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53715/#review159671 --- 3rdparty/stout/include/stout/os/posix/shell.hpp (lines 41 - 42) <

Review Request 54913: Added some missing log statements for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54913/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos Descript

Re: Review Request 53719: Created default mount point on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53719/#review159751 --- Ship it! src/slave/flags.cpp (lines 634 - 638)

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 53718: Defined and used Windows string `docker-mesos-executor.exe`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53718/#review159747 --- Fix it, then Ship it! I can fix this up before committing. sr

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review159750 --- Patch looks great! Reviews applied: [54613] Passed command: expo

Re: Review Request 54910: Fixed more tests to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54910/ --- (Updated Dec. 20, 2016, 8:37 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 54896: Fixed copy-template-and-create-symlink make target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54896/#review159743 --- src/Makefile.am (line 2428)

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Re: Review Request 54880: Added unit-test for dynamic addition/deletion of CNI config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54880/#review159739 --- Patch looks great! Reviews applied: [54716, 54717, 54718, 54880]

Re: Review Request 54035: Extended test coverage of posix/rlimits isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54035/#review159658 --- Fix it, then Ship it! src/tests/containerizer/posix_rlimits_is

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

> On Dec. 20, 2016, 12:29 a.m., Daniel Pravat wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 748 > > > > > > I don't think the conversion to UTF-8 is appropiate here. > > Andrew Schwartzmeyer wrote: >

Review Request 54910: Fixed more tests to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54910/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, and Jo

Review Request 54909: Added member to agent to avoid spurious re-registrations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54909/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, and

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

> On Dec. 20, 2016, 5:36 p.m., Greg Mann wrote: > > LGTM, thanks Alex! Have you tested these on Windows as well? If so, it > > would be good to include in the "testing" section. I have, but unfortunately, some of these tests have other issues that I need to deal with on Windows before they're

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/#review159732 --- Ship it! LGTM, thanks Alex! Have you tested these on Windows as

Re: Review Request 54889: Handled all possible offers in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54889/#review159727 --- Can we add an expectation for exactly when we expect to receive th

Re: Review Request 54901: Updated description of "--agent_reregister_timeout".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54901/#review159724 --- Ship it! Ship It! - Vinod Kone On Dec. 20, 2016, 4:09 p.m.,

Re: Review Request 54901: Updated description of "--agent_reregister_timeout".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54901/#review159722 --- Ship it! Ship It! - haosdent huang On Dec. 20, 2016, 4:09 p.

Review Request 54901: Updated description of "--agent_reregister_timeout".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54901/ --- Review request for mesos, haosdent huang and Vinod Kone. Repository: mesos De

Review Request 54898: Added a CHECK in updateFrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/ --- Review request for mesos, Guangya Liu and Joris Van Remoortere. Repository: mes

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52071/#review159717 --- Patch looks great! Reviews applied: [51999, 52002, 51879, 51880,

Re: Review Request 54613: Install a symlink rather than building mesos-slave twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54613/#review159714 --- Ship it! src/Makefile.am (line 2446)

Review Request 54896: Fixed copy-template-and-create-symlink make target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54896/ --- Review request for mesos, James Peach and Till Toenshoff. Repository: mesos D

Re: Review Request 53791: Use the stout ELF parser to collect Linux rootfs files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review159711 --- Patch looks great! Reviews applied: [53790, 54712, 54878, 53791]

Re: Review Request 51028: Fix broken tests post batched event allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/ --- (Updated Dec. 20, 2016, 12:05 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 29, 2016, 3:06 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3623-3627 > > > > > > Instead of killing this part, what about updating `offerCallback` > > function to recor

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Sept. 28, 2016, 11:02 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2974 > > > > > > Can you please add some comments here for why not using > > `Clock::pause()`? Added this ba

Re: Review Request 51028: Fix tests with rapidly triggered allocations.

> On Dec. 13, 2016, 4:30 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3005-3006 > > > > > > Similar to Guangya's suggestion, I think we can elaborate on the reason > > to use tow

Review Request 54889: Handled all possible offers in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54889/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6820 https://

Re: Review Request 54875: CMake: Fixed typo `-DHAS_AUTHENTICATION=0` instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54875/#review159699 --- Patch looks great! Reviews applied: [54875] Passed command: expo

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

> On Dec. 20, 2016, 12:01 a.m., Greg Mann wrote: > > I was able to catch one flaky test by running the agent tests in > > repetition. For the other patches you're working on, I would recommend > > running the altered tests for a while with `--gtest_repeat=-1 > > --gtest_break_on_failure` to ch

Re: Review Request 54803: Fixed `SlaveTests` to pass when `HAS_AUTHENTICATION` is undefined.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54803/ --- (Updated Dec. 20, 2016, 10:37 a.m.) Review request for mesos, Adam B, Andrew Sc