Re: Review Request 55828: Updated Resources::apply to handle Resource.AllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55828/#review163236 --- Fix it, then Ship it! Ship It! src/common/resources.cpp

Re: Review Request 56016: Expanded a comment about TaskStatus protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/#review163379 --- include/mesos/mesos.proto (lines 1768 - 1771)

Re: Review Request 55884: Updated the naming of unacknowledged tasks in executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55884/#review163378 --- Ship it! Ship It! - Vinod Kone On Jan. 27, 2017, 12:10

Re: Review Request 55761: Fixed name matching for automatic resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55761/#review163376 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 7:10 a.m.,

Re: Review Request 55901: [WIP] Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/#review163363 --- src/checks/health_checker.hpp (line 137)

Re: Review Request 55694: CMake: Separated Stout system headers from Stout API headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55694/#review163368 --- Ship it! LGTM. - Joseph Wu On Jan. 18, 2017, 5:23 p.m.,

Re: Review Request 55695: CMake: Separated Libprocess system headers from Libprocess API headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55695/#review163369 --- Ship it! LGTM. - Joseph Wu On Jan. 18, 2017, 5:23 p.m.,

Re: Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56037/#review163374 --- Ship it! Ship It! - Joseph Wu On Jan. 27, 2017, 12:45 p.m.,

Re: Review Request 55748: CMake: Deleted spurious configuration settings in agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55748/#review163372 --- Ship it! Ship It! - Joseph Wu On Jan. 19, 2017, 11:31 p.m.,

Re: Review Request 55696: CMake: Separated Mesos system headers from Mesos API headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55696/#review163370 --- src/CMakeLists.txt (line 361)

Re: Review Request 55637: CMake: Added `test` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/#review163366 --- Ship it! LGTM, except your review description is out of date.

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55607/#review163364 --- Ship it! Quickly verified: ``` cmake .. ls bin # Looks

Re: Review Request 55900: Improved style in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review163348 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 6:15 p.m.,

Re: Review Request 55955: Added validation tests to ensure environment variable value is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55955/#review163346 --- Ship it! Ship It! - Vinod Kone On Jan. 26, 2017, 2:36 a.m.,

Re: Review Request 55954: Changed 'Environment.Variable.Value' from required to optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55954/#review163344 --- src/slave/validation.cpp (line 175)

Re: Review Request 55940: Added support for the new streaming request/response headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55940/#review163343 --- Ship it! Ship It! - Vinod Kone On Jan. 26, 2017, 5:03 a.m.,

Re: Review Request 55978: Added some assertions to the switchboard request handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55978/#review163342 --- Ship it! Ship It! - Vinod Kone On Jan. 26, 2017, 5:03 a.m.,

Re: Review Request 55937: Added constants for referring to request/response streaming headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55937/#review163341 --- Ship it! Ship It! - Vinod Kone On Jan. 26, 2017, 5:04 a.m.,

Re: Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56037/#review163330 --- Bad patch! Reviews applied: [56037, 55749, 55748, 55696, 55695,

Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56037/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/ --- (Updated Jan. 27, 2017, 11:46 a.m.) Review request for mesos, Avinash

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

> On Jan. 27, 2017, 8:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 301 > > > > > > I'd add some comment about the order of `fslayers` here. whether it

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

> On Jan. 25, 2017, 12:27 a.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > > > > > Why not use `*.hpp` instead? > > Alex Clemmer wrote: > Generally, we also would like to include

Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/#review163314 --- Patch looks great! Reviews applied: [56027, 56028] Passed

Review Request 56027: Consistently add the FollowSymlink stat argument on POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56027/ --- Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and

Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/ --- Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and

Re: Review Request 56017: WIP: Added a helper for building a task status from an existing one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/#review163293 --- Patch looks great! Reviews applied: [56016, 56017] Passed

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review163288 --- Fix it, then Ship it! Variable naming still seems

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/#review163283 --- Fix it, then Ship it!

Review Request 56024: Added Dmitry Zhuk to contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56024/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 55767: Ensured task's check status is delivered with reconciliation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55767/ --- (Updated Jan. 27, 2017, 3:38 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 55884: Updated the naming of unacknowledged tasks in executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55884/#review163274 --- Patch looks great! Reviews applied: [55884] Passed command:

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/#review163261 --- Patch looks great! Reviews applied: [55876] Passed command:

Review Request 56017: WIP: Added a helper for building a task status from an existing one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56017/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Review Request 56016: Expanded a comment about TaskStatus protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56016/ --- Review request for mesos, Gastón Kleiman and Vinod Kone. Repository: mesos

Re: Review Request 55884: Updated the naming of unacknowledged tasks in executors for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55884/ --- (Updated Jan. 27, 2017, 12:10 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/ --- (Updated Jan. 27, 2017, 11:52 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 55900: Improved style in `HealthChecker`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review163250 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 25, 2017,

Re: Review Request 55900: Improved style in `HealthChecker`.

> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote: > > I remember we have special reason to use `Option` here instead of `const > > Option&` in previous patches. @alex may remember that, or I > > missunderstanding something here? > > Gastón Kleiman wrote: > The parameter was introduced

Re: Review Request 55876: Avoided shadowing in `Slave::run()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55876/ --- (Updated Jan. 27, 2017, 11:39 a.m.) Review request for mesos, Anand Mazumdar,