Re: Review Request 55973: Update the tests to handle MULTI_ROLE support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55973/#review163459 --- src/examples/dynamic_reservation_framework.cpp (line 123)

Re: Review Request 56004: Fixed MULTI_ROLE related bugs when updating framework info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56004/#review163456 --- Fix it, then Ship it! Ship It! src/master/master.hpp (lines

Re: Review Request 55972: Updated master to handle non-MULTI_ROLE agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55972/#review163455 --- src/master/master.cpp (lines 5620 - 5628)

Re: Review Request 55971: Updated the agent to be MULTI_ROLE capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55971/#review163428 --- src/slave/slave.cpp (lines 1874 - 1878)

Re: Review Request 55964: Improved executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/#review163454 --- Ship it! Ship It! - Anand Mazumdar On Jan. 29, 2017, 11:41

Re: Review Request 55964: Improved executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/#review163453 --- Patch looks great! Reviews applied: [55964] Passed command:

Re: Review Request 55863: Introduce a helper for injecting AllocationInfo into offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55863/#review163448 --- Fix it, then Ship it! src/common/protobuf_utils.cpp (lines

Re: Review Request 55825: Augmented printing of Resources to include AllocationInfo.

> On Jan. 25, 2017, 10:19 a.m., Michael Park wrote: > > src/common/resources.cpp, line 1942 > > > > > > Labeling `allocated:` seems okay to me, but also seems to be new to > > this format. > > > > It's

Re: Review Request 55825: Augmented printing of Resources to include AllocationInfo.

> On Jan. 25, 2017, 11:10 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 822 > > > > > > How about not clear this but keep the `allocated` label for all of the > > test or just add this to the end

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

> On Dec. 18, 2016, 1:10 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 1062 > > > > > > Shall we add a `CHECK` here to make sure this resource was not > > allocated to any role? > > Benjamin Mahler

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

> On Jan. 25, 2017, 10:40 a.m., Guangya Liu wrote: > > src/tests/resources_tests.cpp, line 2774 > > > > > > How about > > > > ``` > > Resources cpus2 = cpus1; > > ``` > > > > Ditto for

Re: Review Request 55828: Updated Resources::apply to handle Resource.AllocationInfo.

> On Jan. 29, 2017, 12:02 a.m., Michael Park wrote: > > It took me a while trying to figure out what the invariants of `Resources` > > and `Offer::Operation` are, but I think I have a grasp of it. > > > > - We have `recovered.apply(operation);` where we have `recovered` and > > `operation`

Re: Review Request 56005: Added a safety CHECK when accessing activeRoles in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56005/#review163444 --- Ship it! Ship It! - Neil Conway On Jan. 27, 2017, 12:31

Re: Review Request 55964: Improved executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/ --- (Updated Jan. 29, 2017, 11:41 p.m.) Review request for mesos and Anand

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review163438 --- Fix it, then Ship it! I'll fix the issues below for you.

Re: Review Request 55964: Updates for executor, scheduler V1 API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55964/#review163441 --- Looks good and thanks for the cleanup! Can you update the

Re: Review Request 53741: Display maintainance info in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review163433 --- Patch looks great! Reviews applied: [53741] Passed command:

Re: Review Request 48291: Use varint comparator in replica log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- (Updated Jan. 29, 2017, 2:56 p.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 48291: Use varint comparator in replica log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- (Updated Jan. 29, 2017, 2:54 p.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 51053: Update leveldb to 1.19.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/ --- (Updated Jan. 29, 2017, 2:52 p.m.) Review request for mesos, Bing Li, Benjamin

Re: Review Request 53741: Display maintainance info in the webui.

> On Jan. 25, 2017, 6:16 p.m., haosdent huang wrote: > > Hi, may you mind rebase this. Done. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review162986

Re: Review Request 53741: Display maintainance info in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- (Updated Jan. 29, 2017, 2:48 p.m.) Review request for mesos, haosdent huang

Re: Review Request 55828: Updated Resources::apply to handle Resource.AllocationInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55828/#review163320 --- Fix it, then Ship it! It took me a while trying to figure out