Re: Review Request 56314: Fix the OS X build.

> On Feb. 4, 2017, 8:48 p.m., Guangya Liu wrote: > > Seems the docker_archive.hpp also need some update. The places that actually use DockerArchive and Rootfs are still linux only. Agreed that this (not just `Rootfs` but linux only headers in general) is pretty error-prone though and we

Re: Review Request 56314: Fix the OS X build.

> On Feb. 4, 2017, 11:25 p.m., Jiang Yan Xu wrote: > > Ship It! Gotta call it macOS man. :) - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/#review164271

Re: Review Request 56314: Fix the OS X build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/#review164271 --- Ship it! Ship It! - Jiang Yan Xu On Feb. 4, 2017, 7:47

Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess.

> On Feb. 2, 2017, 11:46 a.m., Alex Clemmer wrote: > > 3rdparty/libprocess/src/io.cpp, line 222 > > > > > > This comparison is definitely a bug. On Windows, when this `fd` is a > > pipe `HANDLE`, this comparison

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

> On Feb. 2, 2017, 11:47 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/mktemp.hpp, line 44 > > > > > > This also seems to be not a correct comparison? See the comment in > > `io::read` in

Re: Review Request 56270: Made the default executor launch multiple task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/#review164268 --- Patch looks great! Reviews applied: [56267, 56308, 56269, 56268,

Re: Review Request 56314: Fix the OS X build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/#review164266 --- Seems the docker_archive.hpp also need some update. - Guangya

Re: Review Request 52379: Added agent flag '--oci_store_dir'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52379/#review164265 --- Fix it, then Ship it! src/slave/flags.cpp (line 173)

Re: Review Request 55140: Added tests for parsing OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55140/#review164264 --- Fix it, then Ship it!

Re: Review Request 55139: Implemented parse methods for OCI image spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55139/#review164262 --- Fix it, then Ship it! src/oci/spec.cpp (line 33)

Review Request 56314: Fix the OS X build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/ --- Review request for mesos, Benjamin Bannier and Jiang Yan Xu. Repository: mesos

Re: Review Request 56314: Fix the OS X build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/ --- (Updated Feb. 5, 2017, 3:47 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 56292: Updated isolator module docs with checkpointing information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56292/#review164261 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2017, 11:06 p.m.,

Re: Review Request 56293: Added '--runtime_dir' flag to the agent configuration docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56293/#review164258 --- Patch looks great! Reviews applied: [56293] Passed command:

Re: Review Request 54603: Replaced `int` with `int_fd` in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54603/ --- (Updated Feb. 4, 2017, 5:39 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54602/ --- (Updated Feb. 4, 2017, 5:39 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54601/ --- (Updated Feb. 4, 2017, 5:39 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/ --- (Updated Feb. 4, 2017, 5:38 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54762/ --- (Updated Feb. 4, 2017, 5:38 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/ --- (Updated Feb. 4, 2017, 5:38 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54591/ --- (Updated Feb. 4, 2017, 5:36 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 56174: Added skipping already stored layers to local Docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56174/#review164257 --- Fix it, then Ship it! I'll commit the code first without the

Re: Review Request 56291: Removed unnecessary mkdirs in ProvisionerDockerLocalStoreTest.*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56291/#review164253 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2017, 8:43 p.m., Ilya

Re: Review Request 56251: Tightened assertions in sorter and allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56251/#review164251 --- Ship it! Ship It! - Michael Park On Feb. 3, 2017, 4:22

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56284/ --- (Updated Feb. 4, 2017, 6:37 p.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

> On Feb. 4, 2017, 3:23 a.m., Timothy Chen wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 396 > > > > > > How about making this a bit simpler: > > "This test verifies that the store skips

Re: Review Request 56284: Added ProvisionerDockerLocalStoreTest.SkippedLayers test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56284/ --- (Updated Feb. 4, 2017, 6:36 p.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 56270: Made the default executor launch multiple task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56270/ --- (Updated Feb. 4, 2017, 5:53 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56268/ --- (Updated Feb. 4, 2017, 5:52 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 56268: Made `kill()` not invoke `shutdown()` in the default executor.

> On Feb. 3, 2017, 10:32 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 674-677 > > > > > > not new in this patch chain, but: > > > > do we care about non-zero exit code if the task

Re: Review Request 56269: Introduced a `Container` struct on the default executor.

> On Feb. 3, 2017, 11:02 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 89 > > > > > > hmm. it's unfortunate that each task/container stores TaskInfos of all > > tasks in the task group. > >

Re: Review Request 56269: Introduced a `Container` struct on the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56269/ --- (Updated Feb. 4, 2017, 5:51 p.m.) Review request for mesos and Vinod Kone.

Review Request 56308: Modified active containers key to be `TaskID` in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56308/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6296

Re: Review Request 55541: Replaced (another) recursive implementation with process::loop.

> On Jan. 16, 2017, 9:10 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1003-1004 > > > > > > I see that you simply restore the previous behaviour here, but still, I > > don't see how