Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/#review170674 --- Patch looks great! Reviews applied: [58095, 58096, 58097, 58099]

Re: Review Request 58055: Documentation updates to reflect multi-role framework support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58055/#review170670 --- Fix it, then Ship it! docs/authorization.md Line 61 (original)

Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. Bugs: M

Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- Review request for mesos, Adam B and Benjamin Mahler. Bugs: MESOS-7260 http

Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- Review request for mesos, Adam B and Benjamin Mahler. Bugs: MESOS-7260 http

Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- Review request for mesos, Adam B and Benjamin Mahler. Bugs: MESOS-7260 http

Re: Review Request 57254: Updated DRFSorter to support hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated March 30, 2017, 5:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57564/ --- (Updated March 30, 2017, 5:58 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 58084: Adjust `using` style in a few places.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58084/#review170608 --- Patch looks great! Reviews applied: [58037, 58038, 58039, 58040,

Re: Review Request 58030: Added support for COMMAND checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58030/#review170582 --- Fix it, then Ship it! src/checks/checker.hpp Line 25 (original

Re: Review Request 57912: Enabled pause/resume for checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57912/#review170574 --- Fix it, then Ship it! src/checks/checker.cpp Lines 370-371 (pa

Re: Review Request 57854: Improved log/failure messages in the (health)checker libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57854/#review170561 --- Fix it, then Ship it! Thanks a lot for the cleanup, Gastón! s

Re: Review Request 58043: Cleanup usage of namespace-qualified identifiers.

> On March 30, 2017, 8:36 a.m., Benjamin Bannier wrote: > > src/checks/checker.cpp > > Line 1 (original), 1 (patched) > > > > > > Since you focus on `std::string` and `testing::WithParamInterface` in > > this patch, c

Review Request 58084: Adjust `using` style in a few places.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58084/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 58044: Removed unused "using" statements.

> On March 30, 2017, 8:36 a.m., Benjamin Bannier wrote: > > Jikes, getting these right is even harder than getting includes right due > > to e.g., ADL. Any idea how to automate this beyond one-off drive-by fixes? Not sure. We could look into building something with `clang-tidy`, perhaps? - Ne

Re: Review Request 58041: Don't mark a value parameter `const`.

> On March 30, 2017, 8:36 a.m., Benjamin Bannier wrote: > > src/tests/fetcher_cache_tests.cpp > > Line 410 (original), 410 (patched) > > > > > > You do not need to remove the `const` here, e.g., the following is ok,

Re: Review Request 58039: Avoid redundant copies when using `std::get` on a tuple.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58039/ --- (Updated March 30, 2017, 4:05 p.m.) Review request for mesos and Benjamin Banni

Re: Review Request 57564: Changed DRFSorter's representation of inactive clients.

> On March 29, 2017, 10:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/sorter/drf/sorter.hpp > > Lines 214-216 (original), 215-217 (patched) > > > > > > This comment is no longer accurate, right? We used to

Re: Review Request 57516: Updated CHANGELOG for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57516/ --- (Updated March 30, 2017, 3:54 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 58057: Changed SSL Socket destruction into a synchronous operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58057/ --- (Updated March 30, 2017, 7:15 a.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 55065: Added support for s390x architecture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55065/#review170567 --- Patch looks great! Reviews applied: [55065] Passed command: expo

Re: Review Request 55065: Added support for s390x architecture

> On March 22, 2017, 2:45 p.m., Till Toenshoff wrote: > > src/linux/ldcache.cpp > > Line 120 (original), 120 (patched) > > > > > > Can you elaborate why this change is safe for all systems? > > Ayanampudi Varsha wro

Re: Review Request 55065: Added support for s390x architecture

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55065/ --- (Updated March 30, 2017, 11:29 a.m.) Review request for mesos, Till Toenshoff a

Re: Review Request 58060: Added a check to default clang-tidy check list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58060/#review170555 --- Patch looks great! Reviews applied: [58037, 58038, 58039, 58040,

Re: Review Request 58055: Documentation updates to reflect multi-role framework support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58055/#review170551 --- docs/roles.md Lines 34 (patched)

Re: Review Request 58043: Cleanup usage of namespace-qualified identifiers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58043/#review170549 --- src/checks/checker.cpp Line 1 (original), 1 (patched)

Re: Review Request 58044: Removed unused "using" statements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58044/#review170550 --- Ship it! Jikes, getting these right is even harder than getting

Re: Review Request 58041: Don't mark a value parameter `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58041/#review170544 --- Fix it, then Ship it! src/tests/fetcher_cache_tests.cpp Line 4

Re: Review Request 58040: Avoid various redundant copies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/#review170548 --- The changes here look good to me, but running % CHECKS='-*,pe

Re: Review Request 58042: Remove unused include in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58042/#review170546 --- Ship it! Not sure fixes like this are worthwhile beyond drive-b

Re: Review Request 58039: Avoid redundant copies when using `std::get` on a tuple.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58039/#review170542 --- Fix it, then Ship it! src/checks/health_checker.cpp Line 1 (or

Re: Review Request 58065: Added initial code for the python mesoshttp package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58065/#review170547 --- Patch looks great! Reviews applied: [58065] Passed command: expo