Re: Review Request 58320: Added an upgrade test for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58320/ --- (Updated April 11, 2017, 4:46 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58328/ --- (Updated April 11, 2017, 4:37 a.m.) Review request for mesos, Anand Mazumdar

Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58328/ --- Review request for mesos. Repository: mesos Description --- Updated

Review Request 58327: Changed '--executor_secret_key' agent flag to accept a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58327/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6999

Re: Review Request 58292: Removed unnecesary break statements in local approver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58292/#review171511 --- Ship it! Ship It! - Adam B On April 10, 2017, 3:09 a.m.,

Re: Review Request 58254: Added implicit executor authorization to the agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58254/#review171506 --- include/mesos/authorizer/authorizer.proto Line 176 (original),

Re: Review Request 58329: Parameterized the existing alpine based test with more registries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58329/ --- (Updated April 10, 2017, 5:07 p.m.) Review request for mesos, Avinash

Review Request 58329: Parameterized the existing alpine based test with more registries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58329/ --- Review request for mesos, Avinash sridharan, Chun-Hung Hsiao, Artem

Re: Review Request 48917: Fixed docker fetcher 3xx redirect errors by header attached.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48917/ --- (Updated April 10, 2017, 5:01 p.m.) Review request for mesos, Avinash

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171505 --- Fix it, then Ship it! src/common/validation.cpp Lines 21

Re: Review Request 58314: Removed `thread_local.hpp` from stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58314/#review171503 --- Patch looks great! Reviews applied: [58310, 58311, 58312, 58313,

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/ --- (Updated April 10, 2017, 10:37 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57972/ --- (Updated April 10, 2017, 9:41 p.m.) Review request for mesos, Andrew

Re: Review Request 57971: Added test filtering framework to libprocess-tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57971/ --- (Updated April 10, 2017, 9:41 p.m.) Review request for mesos, Andrew

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/ --- (Updated April 10, 2017, 9:41 p.m.) Review request for mesos, Andrew

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171490 --- Patch looks great! Reviews applied: [58317] Passed command:

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

> On April 10, 2017, 9:05 p.m., Aaron Wood wrote: > > src/common/validation.cpp > > Lines 40 (patched) > > > > > > Maybe it's better to put this check in `src/slave/paths.cpp` and add up > > the length of `rootDir`,

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

> On April 10, 2017, 9:05 p.m., Aaron Wood wrote: > > src/common/validation.cpp > > Lines 40 (patched) > > > > > > Maybe it's better to put this check in `src/slave/paths.cpp` and add up > > the length of `rootDir`,

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171488 --- Ship it! Ship It! - James Peach On April 10, 2017, 6:16

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171483 --- src/common/validation.cpp Lines 40 (patched)

Re: Review Request 58253: Added a ContainerID to 'ObjectApprover::Object'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58253/#review171480 --- Ship it! Ship It! - Vinod Kone On April 7, 2017, 3:33 a.m.,

Re: Review Request 58252: Allowed the local authorizer to accept subjects with no value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58252/#review171478 --- Ship it! Ship It! - Vinod Kone On April 7, 2017, 11:15

Re: Review Request 58251: Changed 'Principal.claims' to a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58251/#review171477 --- Ship it! Ship It! - Vinod Kone On April 7, 2017, 3:26 a.m.,

Re: Review Request 58279: Lazily unmount persistent volumes in DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58279/#review171476 --- Ship it! Ship It! src/slave/containerizer/docker.cpp Line

Review Request 58320: Added an upgrade test for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58320/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6999

Re: Review Request 58278: Lazily unmount persistent volumes in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58278/#review171475 --- Ship it! Ship It!

Review Request 58321: Added a new overload of 'StartSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58321/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6999

Review Request 58314: Removed `thread_local.hpp` from stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58314/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7373

Review Request 58313: Replaced `THREAD_LOCAL` with `thread_local` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58313/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Review Request 58311: Updated "getting started" instructions for XCode 8.0 dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58311/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7373

Review Request 58310: Removed workaround for lack of `thread_local` on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58310/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7373

Re: Review Request 58289: Avoided excessive copying in the default implementation of 'stringify'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58289/#review171471 --- Ship it! Ship It! - Neil Conway On April 10, 2017, 6:15

Re: Review Request 58288: Added stringify overload specialized for std::string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58288/#review171470 --- Ship it! Ship It! - Neil Conway On April 10, 2017, 6:22

Re: Review Request 58289: Avoided excessive copying in the default implementation of 'stringify'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58289/#review171462 --- Patch looks great! Reviews applied: [58288, 58289] Passed

Re: Review Request 58288: Added stringify overload specialized for std::string.

> On April 10, 2017, 8:17 p.m., Neil Conway wrote: > > 3rdparty/stout/include/stout/stringify.hpp > > Lines 47 (patched) > > > > > > Can you add an explanatory comment here? Done, I agree that this looks like a

Re: Review Request 58288: Added stringify overload specialized for std::string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58288/ --- (Updated April 10, 2017, 8:22 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171456 --- src/common/validation.cpp Line 46 (original), 50 (patched)

Re: Review Request 58288: Added stringify overload specialized for 'std::string'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58288/#review171455 --- 3rdparty/stout/include/stout/stringify.hpp Lines 47 (patched)

Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/ --- Review request for mesos, Jie Yu and James Peach. Bugs: MESOS-7346

Re: Review Request 58289: Avoided excessive copying in the default implementation of 'stringify'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58289/ --- (Updated April 10, 2017, 8:15 p.m.) Review request for mesos and Neil Conway.

Review Request 58288: Added stringify overload specialized for 'std::string'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58288/ --- Review request for mesos and Neil Conway. Repository: mesos Description

Review Request 58289: Avoided excessive copying in the default implementation of 'stringify'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58289/ --- Review request for mesos and Neil Conway. Bugs: MESOS-6560

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review171449 --- Patch looks great! Reviews applied: [58303, 58304, 58305]

Re: Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/ --- (Updated April 10, 2017, 3:50 p.m.) Review request for mesos and Mesos

Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- Review request for mesos and Mesos Reviewbot. Bugs: MESOS-7372.

Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/ --- Review request for mesos. Bugs: MESOS-7372

Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/ --- Review request for mesos and Mesos Reviewbot. Bugs: MESOS-7372

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 10, 2017, 12:11 p.m.) Review request for mesos, Adam B and

Review Request 58292: Removed unnecesary break statements in local approver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58292/ --- Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/#review171428 --- Patch looks great! Reviews applied: [58287] Passed command:

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/#review171424 --- src/tests/hierarchical_allocator_tests.cpp Lines 4582 (patched)

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/#review171423 --- Bad patch! Reviews applied: [58137, 57952, 57951, 57896] Failed

Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated April 10, 2017, 6:38 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 10, 2017, 6:37 a.m.) Review request for mesos, Joseph Wu and

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated April 10, 2017, 6:33 a.m.) Review request for mesos and Joseph Wu.