Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/#review171679 --- Patch looks great! Reviews applied: [57815, 57816, 57817, 57818]

Review Request 58379: Fixed a typo in persistent volume doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58379/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/#review171674 --- src/master/http.cpp Lines 3504-3507 (patched)

Re: Review Request 58097: Added a test to check framework filtering in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58097/ --- (Updated April 12, 2017, 1:38 p.m.) Review request for mesos, Adam B,

Re: Review Request 58096: Added authorization for frameworks in /roles endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/ --- (Updated April 12, 2017, 1:38 p.m.) Review request for mesos, Adam B,

Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58099/ --- (Updated April 12, 2017, 1:38 p.m.) Review request for mesos, Adam B,

Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

> On April 7, 2017, 9:11 p.m., Alexander Rojas wrote: > > src/master/http.cpp > > Line 3383 (original), 3385 (patched) > > > > > > With the proposed changes, there's no reason to have this function in > >

Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58095/ --- (Updated April 12, 2017, 1:35 p.m.) Review request for mesos, Adam B,

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58337/ --- (Updated April 12, 2017, 4:17 a.m.) Review request for mesos and haosdent

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review171664 --- Bad patch! Reviews applied: [58305, 58304, 58303] Failed

Re: Review Request 56722: Add a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review171663 --- Patch looks great! Reviews applied: [55334, 55335, 53105, 53330,

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 12, 2017, 1:42 a.m.) Review request for mesos, Jie Yu and Vinod

Review Request 58374: Updated check tests to authenticate with agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58374/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Vinod Kone.

Review Request 58369: Updated default executor to pass authorization header to checkers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58369/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Vinod Kone.

Review Request 58370: Updated a health checker test to enable executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58370/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Vinod Kone.

Review Request 58373: Updated 'Checker' to authenticate with agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58373/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Vinod Kone.

Review Request 58368: Updated 'HealthChecker' to authenticate with the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58368/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Vinod Kone.

Re: Review Request 58320: Added an upgrade test for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58320/#review171659 --- Patch looks great! Reviews applied: [58321, 58320] Passed

Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/ --- (Updated April 12, 2017, 12:04 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58357: Added more language support in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/ --- (Updated April 12, 2017, 12:02 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58146/#review171655 --- Ship it! LGTM. - Joseph Wu On April 9, 2017, 11:40 p.m.,

Re: Review Request 58278: Lazily unmount persistent volumes in MesosContainerizer.

> On April 10, 2017, 8:45 p.m., Jason Lai wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Line 827 (original), 829 (patched) > > > > > > Not sure `strings::startsWith` would be the safest

Re: Review Request 57817: Suppress offers for frameworks on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated April 11, 2017, 11:10 p.m.) Review request for mesos, James Peach,

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated April 11, 2017, 11:10 p.m.) Review request for mesos, James Peach,

Re: Review Request 57815: Added `suppress_offers` field in SUBSCRIBE.

> On April 11, 2017, 7:38 p.m., Vinod Kone wrote: > > include/mesos/scheduler/scheduler.proto > > Lines 251 (patched) > > > > > > Can we use an active word here, say "suppress_offers" or "suppress", > > because our

Re: Review Request 57815: Added `suppress_offers` field in SUBSCRIBE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57815/ --- (Updated April 11, 2017, 11:09 p.m.) Review request for mesos, James Peach,

Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57816/ --- (Updated April 11, 2017, 11:09 p.m.) Review request for mesos, James Peach,

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171650 --- src/cli_new/lib/cli/plugins/config/main.py Lines 54-62 (patched)

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 11, 2017, 10:33 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/ --- (Updated April 11, 2017, 10:33 p.m.) Review request for mesos, Adam B, Mesos

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/ --- (Updated April 11, 2017, 10:31 p.m.) Review request for mesos, Adam B, Mesos

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

> On April 11, 2017, 7:05 p.m., Neil Conway wrote: > > I wonder if we should make a similar change to `Master::updateTask()`? I > > don't feel super strongly one way or another, but you could argue that it > > would improve symmetry. Done. - James

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/#review171646 --- Modulo some final comments, should be ready to go...

Re: Review Request 57527: Avoided storing weights in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/ --- (Updated April 11, 2017, 10 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/ --- (Updated April 11, 2017, 9:58 p.m.) Review request for mesos, Adam B,

Re: Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/#review171642 --- Bad patch! Reviews applied: [58361, 58360, 58359, 58358, 58357]

Re: Review Request 57972: Added base stout Environment class to mesos-tests Environment class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57972/#review171621 --- src/tests/environment.hpp Lines 31-32 (patched)

Re: Review Request 57971: Added test filtering framework to libprocess-tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57971/#review171619 --- 3rdparty/libprocess/src/tests/main.cpp Lines 34 (patched)

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

> On April 11, 2017, 11:45 a.m., Neil Conway wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp > > Line 294 (original), 294 (patched) > > > > > > Seems like the reference to `GTEST_IS_THREADSAFE` should be

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/#review171632 --- Patch looks great! Reviews applied: [57896, 57951, 57952, 58137]

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review171512 --- Fix it, then Ship it! I can fix the below issues for you,

Re: Review Request 56722: Add a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated April 11, 2017, 8:33 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated April 11, 2017, 8:32 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 53330: Tracked layers and pull latency in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated April 11, 2017, 8:29 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 55334: Checkpoint and recover `ContainerConfig` in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55334/ --- (Updated April 11, 2017, 8:28 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 57816: Add a scheduler flag `offers_suppressed_on_register`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57816/#review171628 --- src/sched/flags.hpp Lines 127 (patched)

Re: Review Request 57815: Added `offers_suppressed` field in SUBSCRIBE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57815/#review171623 --- include/mesos/scheduler/scheduler.proto Lines 251 (patched)

Re: Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/#review171614 --- For consistency, should we also remove the

Re: Review Request 58320: Added an upgrade test for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58320/#review171618 --- Fix it, then Ship it! Nice test! src/tests/slave_tests.cpp

Re: Review Request 58321: Added a new overload of 'StartSlave'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58321/#review171617 --- Ship it! Ship It! - Vinod Kone On April 10, 2017, 8:40

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/#review171615 --- 3rdparty/libprocess/src/process.cpp Lines 2362-2363 (patched)

Re: Review Request 58254: Added implicit executor authorization to the agent operator API.

> On April 11, 2017, 12:27 a.m., Vinod Kone wrote: > > src/authorizer/local/authorizer.cpp > > Lines 725 (patched) > > > > > > Is this based on the assumption that claims subjects only come from > > executors and

Re: Review Request 58258: Added a new agent authorization test which runs a task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58258/#review171610 --- src/tests/slave_authorization_tests.cpp Lines 499-506 (patched)

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/#review171611 --- I wonder if we should make a similar change to

Re: Review Request 58351: Updated GMock/GTest in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58351/#review171609 --- Bad patch! Reviews applied: [58351, 58350, 58349, 58348, 58347]

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/#review171608 --- Should you also update the reference to `tr1` in

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/#review171598 --- I'm curious what the goal of these assertions is: to fail the

Re: Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/#review171606 --- Can you update the gmock references in

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/#review171600 --- src/slave/http.cpp Lines 699-701 (original), 727-729 (patched)

Review Request 58361: Updated LICENSE information for protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58361/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7228

Review Request 58360: Added a test for evolving large protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58360/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6644 and MESOS-7228

Review Request 58359: Update Mesos build library to use protobuf 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58359/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7228

Review Request 58358: Upgrade vendored 3rdparty protobuf to 3.2.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58358/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7228

Re: Review Request 58357: Added more language support in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/ --- (Updated April 11, 2017, 4:30 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 58357: Added more language support in test-upgrade script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58357/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 11, 2017, 4:28 p.m.) Review request for mesos and Mesos

Re: Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/ --- (Updated April 11, 2017, 4:27 p.m.) Review request for mesos and Mesos

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/ --- (Updated April 11, 2017, 4:27 p.m.) Review request for mesos and Mesos

Re: Review Request 58355: Removed unnecessary Registry copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58355/ --- (Updated April 11, 2017, 4:33 p.m.) Review request for mesos and Benjamin

Review Request 58355: Removed unnecessary Registry copying.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58355/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7376

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/ --- (Updated April 11, 2017, 3:14 p.m.) Review request for mesos, Jie Yu and James

Re: Review Request 58317: Prevent agent from crashing when the ID is longer than the maximum file name length.

> On April 10, 2017, 11:48 p.m., Jie Yu wrote: > > src/common/validation.cpp > > Lines 42 (patched) > > > > > > 255? Cau you use NAME_MAX in the error message as well? My fault, I should have done that initially

Re: Review Request 58254: Added implicit executor authorization to the agent operator API.

> On April 11, 2017, 12:27 a.m., Vinod Kone wrote: > > src/authorizer/local/authorizer.cpp > > Lines 725 (patched) > > > > > > Is this based on the assumption that claims subjects only come from > > executors and

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated April 11, 2017, 2:53 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/ --- (Updated April 11, 2017, 2:52 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/ --- (Updated April 11, 2017, 2:51 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58328/#review171561 --- Patch looks great! Reviews applied: [58327, 58328] Passed

Review Request 58351: Updated GMock/GTest in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58351/ --- Review request for mesos, Neil Conway and Till Toenshoff. Bugs: MESOS-7364

Review Request 58350: Updated GMock/GTest in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58350/ --- Review request for mesos, Neil Conway and Till Toenshoff. Bugs: MESOS-7364

Review Request 58349: Updated GMock/GTest to version 1.8.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58349/ --- Review request for mesos, Neil Conway and Till Toenshoff. Bugs: MESOS-7364

Review Request 58348: Used 'ASSERT_THREADSAFE' in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58348/ --- Review request for mesos, Neil Conway and Till Toenshoff. Bugs: MESOS-7193

Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58347/ --- Review request for mesos, Neil Conway and Till Toenshoff. Bugs: MESOS-7193

Re: Review Request 58329: Parameterized the existing alpine based test with more registries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58329/#review171555 --- Patch looks great! Reviews applied: [48917, 58329] Passed

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58337/ --- (Updated April 11, 2017, 11:13 a.m.) Review request for mesos and haosdent

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 11, 2017, 12:58 p.m.) Review request for mesos, Adam B and

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58337/#review171544 ---

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58337/ --- (Updated April 11, 2017, 9:40 a.m.) Review request for mesos and haosdent

Re: Review Request 57473: Added support for authorization of Hierachical roles.

> On April 11, 2017, 8:21 a.m., Adam B wrote: > > src/authorizer/local/authorizer.cpp > > Line 458 (original), 405 (patched) > > > > > > Why isn't this a `return Error();` too? Originally we used the `UNKNOWN` in

Re: Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58337/ --- (Updated April 11, 2017, 9:32 a.m.) Review request for mesos. Repository:

Re: Review Request 58253: Added a ContainerID to 'ObjectApprover::Object'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58253/#review171542 --- include/mesos/authorizer/authorizer.proto Lines 57 (patched)

Review Request 58337: Add allowed devices whitelist for cgroups/devices isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58337/ --- Review request for mesos. Repository: mesos Description --- Add allowed

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review171538 --- Ship it! Ship It! - Adam B On March 22, 2017, 11:36 a.m.,

Re: Review Request 57730: Fixed example tests which broke due to the new `register_agents` ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57730/#review171536 --- src/tests/script.cpp Lines 161 (patched)

Re: Review Request 57710: Added `register_agents` to authorization.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57710/#review171535 --- Ship it! Ship It! - Adam B On March 16, 2017, 4:07 p.m.,

Re: Review Request 57534: Added and implemented RegisterAgent ACL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review171533 --- Fix it, then Ship it! Nit: unnecessary `break`

Re: Review Request 58304: Remove unnecessary hashmap lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58304/#review171532 --- Fix it, then Ship it! LGTM, minor tweak to a log message

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/#review171531 --- Fix it, then Ship it! LGTM, minor nit. src/master/master.cpp

Re: Review Request 57473: Added support for authorization of Hierachical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57473/ --- (Updated April 11, 2017, 1:48 a.m.) Review request for mesos, Adam B and

Re: Review Request 57474: Added test for authorization of hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/ --- (Updated April 11, 2017, 1:47 a.m.) Review request for mesos, Adam B and

Re: Review Request 57652: Allow authenticators to return any http Response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57652/#review171529 --- 3rdparty/libprocess/include/process/authenticator.hpp Lines

  1   2   >