Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review171985 --- Patch looks great! Reviews applied: [57898, 58446, 58447, 58448,

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/ --- (Updated April 14, 2017, 4:12 a.m.) Review request for mesos, Jeff Coffler,

Re: Review Request 58443: Unit test for file/directory overwriting support in provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58443/#review171982 --- Patch looks great! Reviews applied: [58408, 58443] Passed

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/#review171981 --- Please note that this patch was also [submitted to

Re: Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/ --- (Updated April 14, 2017, 2:15 a.m.) Review request for mesos, Jeff Coffler,

Re: Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/#review171980 --- Documentation does need to be updated, but it will come in my

Review Request 58449: CMake: Bump minimum version to 3.7.0 on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58449/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Review Request 58448: Windows: Updated ZooKeeper to use CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58448/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Re: Review Request 58447: CMake: Cleaned up 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58447/#review171979 --- This pays back a lot of technical debt and confusing build cruft

Review Request 58447: CMake: Cleaned up 3rdparty dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58447/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Re: Review Request 58446: Windows: Set CMake generator for Protobuf correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/#review171978 --- Looking at what I ended up doing for ZooKeeper, I think it may be

Review Request 58446: Windows: Set CMake generator for Protobuf correctly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58446/ --- Review request for mesos. Repository: mesos Description --- Reuse the

Re: Review Request 57952: Added 'config' plugin to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57952/#review171976 --- Ship it! LGTM. src/cli_new/lib/cli/plugins/config/main.py

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/#review171977 --- Fix it, then Ship it! I can fixup the mistakes in the Readme.

Re: Review Request 58381: Added a Table abstraction to the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58381/#review171974 --- Ship it! LGTM. As we discussed offline, since this code was

Re: Review Request 58430: Changed some failing Base64 tests to use 'u8' string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58430/#review171973 --- Ship it! Ship It! - Joseph Wu On April 13, 2017, 11:48

Review Request 58443: Unit test for file/directory overwriting support in provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58443/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- (Updated April 14, 2017, 12:24 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 57999: Made Path and Mount root optional in Resource.DiskInfo.Source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57999/#review171969 --- Ship it! Ship It! - Jie Yu On April 5, 2017, 1:56 p.m.,

Re: Review Request 58374: Updated check tests to authenticate with agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58374/#review171960 --- Ship it! Ship It! - Vinod Kone On April 12, 2017, 9:21

Re: Review Request 58370: Updated a health checker test to enable executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58370/#review171959 --- Ship it! Ship It! - Vinod Kone On April 12, 2017, 9:21

Re: Review Request 58369: Updated default executor to pass authorization header to checkers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58369/#review171958 --- Ship it! Ship It! - Vinod Kone On April 13, 2017, 8:27

Re: Review Request 58373: Updated 'Checker' to authenticate with agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58373/#review171955 --- Ship it! Ship It! - Vinod Kone On April 12, 2017, 9:21

Re: Review Request 58368: Updated 'HealthChecker' to authenticate with the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58368/#review171954 --- Ship it! Ship It! - Vinod Kone On April 12, 2017, 9:20

Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58328/#review171953 --- Ship it! Ship It! - Vinod Kone On April 13, 2017, 8:17

Re: Review Request 58327: Changed '--executor_secret_key' agent flag to accept a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58327/#review171952 --- Ship it! Ship It! - Vinod Kone On April 13, 2017, 8:15

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review171950 --- Ship it! Ship It! - Jason Lai On April 12, 2017, 9:44 p.m.,

Re: Review Request 57898: Windows: Add deprecation warning for VS 2015.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57898/ --- (Updated April 13, 2017, 10:03 p.m.) Review request for mesos, Jeff Coffler,

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57254/ --- (Updated April 13, 2017, 9:42 p.m.) Review request for mesos, Benjamin

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review171942 --- Patch looks great! Reviews applied: [58327, 58328, 58251, 58252,

Re: Review Request 58408: Overwriting Directories with Files in Copy Provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58408/ --- (Updated April 13, 2017, 8:37 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 58369: Updated default executor to pass authorization header to checkers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58369/ --- (Updated April 13, 2017, 8:27 p.m.) Review request for mesos, Alexander

Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7339

Re: Review Request 58258: Added a new agent authorization test which runs a task group.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58258/ --- (Updated April 13, 2017, 8:19 p.m.) Review request for mesos, Adam B,

Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58328/ --- (Updated April 13, 2017, 8:17 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58327: Changed '--executor_secret_key' agent flag to accept a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58327/ --- (Updated April 13, 2017, 8:15 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

> On April 13, 2017, 6:54 p.m., Greg Mann wrote: > > src/tests/mesos.cpp > > Lines 218-235 (patched) > > > > > > Use `os::write()` Looks like we don't provide an overload of `os::write` which accepts access

Re: Review Request 58430: Changed some failing Base64 tests to use 'u8' string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58430/#review171923 --- Patch looks great! Reviews applied: [58430] Passed command:

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/#review171920 --- Add TODO to possibly move into authorizer, create ticket for

Re: Review Request 58254: Added implicit executor authorization to the agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58254/#review171917 --- src/authorizer/local/authorizer.cpp Lines 323-327 (original),

Re: Review Request 58254: Added implicit executor authorization to the agent operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58254/ --- (Updated April 13, 2017, 6:56 p.m.) Review request for mesos, Adam B,

Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58328/#review171915 --- src/tests/mesos.cpp Lines 218-235 (patched)

Re: Review Request 58327: Changed '--executor_secret_key' agent flag to accept a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58327/#review171913 --- src/slave/slave.cpp Lines 307-312 (patched)

Re: Review Request 58430: Changed some failing Base64 tests to use 'u8' string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58430/ --- (Updated April 13, 2017, 6:48 p.m.) Review request for mesos, Andrew

Re: Review Request 58327: Changed '--executor_secret_key' agent flag to accept a path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58327/ --- (Updated April 13, 2017, 6:48 p.m.) Review request for mesos, Anand Mazumdar

Review Request 58430: Changed some failing Base64 tests to use 'u8' string literals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58430/ --- Review request for mesos. Repository: mesos Description --- Changed

Re: Review Request 58369: Updated default executor to pass authorization header to checkers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58369/#review171911 --- src/launcher/default_executor.cpp Lines 1406-1410 (original),

Re: Review Request 58252: Allowed the local authorizer to accept subjects with no value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58252/ --- (Updated April 13, 2017, 6:05 p.m.) Review request for mesos, Adam B,

Re: Review Request 58251: Changed 'Principal.claims' to a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58251/ --- (Updated April 13, 2017, 6:04 p.m.) Review request for mesos, Adam B,

Re: Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58421/#review171897 --- Patch looks great! Reviews applied: [58421] Passed command:

Re: Review Request 58410: Removed a duplicate unit test 'ROOT_INTERNET_CURL_Normalize'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58410/#review171892 --- Ship it! Ship It! - Jie Yu On April 13, 2017, 5:34 a.m.,

Review Request 58421: Passed `--zk_session_timeout` to ZK master contender and detector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58421/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-7387

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/#review171879 --- Patch looks great! Reviews applied: [58287] Passed command:

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/#review171868 --- Patch looks great! Reviews applied: [57896, 57951, 58381, 57952,

Re: Review Request 58287: Print corresponding address when socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58287/ --- (Updated 四月 13, 2017, 12:44 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.

> On April 11, 2017, 8:45 p.m., Neil Conway wrote: > > I'm curious what the goal of these assertions is: to fail the test (at > > runtime) if the current version of GTest is not thread-safe, right? It > > seems weird to be doing that at runtime, since whether GTest is threadsafe > > or not

Re: Review Request 57817: Suppress offers for frameworks on registration.

> On April 13, 2017, 12:21 a.m., Vinod Kone wrote: > > src/master/allocator/mesos/allocator.hpp > > Line 70 (original), 70-71 (patched) > > > > > > This is making me think whether we want framework to subscribe with

Re: Review Request 58329: Parameterized the existing alpine based test with more registries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58329/#review171845 --- Patch looks great! Reviews applied: [48917, 58329] Passed