Re: Review Request 58925: Updated runtime isolators to use new task_environment member.

2017-05-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58925/#review174127 --- Ship it! Ship It! - Gilbert Song On May 2, 2017, 10:28

Re: Review Request 58924: Updated containerizer for isolator task_environment merge.

2017-05-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58924/#review174126 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1333

Re: Review Request 58923: Added new ContainerLaunchInfo task_environment.

2017-05-06 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58923/#review174125 --- include/mesos/slave/containerizer.proto Lines 165-167 (patched)

Re: Review Request 59038: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.

2017-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59038/#review174124 --- Patch looks great! Reviews applied: [59038] Passed command:

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

2017-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review174123 --- Bad patch! Reviews applied: [58939] Failed command: python

Re: Review Request 58892: Added C++11 scoped enumeration to style guide.

2017-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58892/#review174122 --- Patch looks great! Reviews applied: [58892] Passed command:

Re: Review Request 52064: Support for multiple versions of docs.

2017-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review174121 --- Patch looks great! Reviews applied: [52064] Passed command:

Re: Review Request 57815: Added `deactivated_roles` field in `FrameworkInfo`.

2017-05-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57815/ --- (Updated May 6, 2017, 10:30 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

2017-05-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated May 6, 2017, 10:30 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for deactivated roles as indicated in `SUBSCRIBE`.

2017-05-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 6, 2017, 10:30 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 59029: Added a script to publish JARs to maven snapshot repository.

2017-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59029/#review174120 --- Patch looks great! Reviews applied: [59029] Passed command:

Re: Review Request 59001: Added volume secret isolator.

2017-05-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- (Updated May 6, 2017, 5:29 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 59038: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.

2017-05-06 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59038/#review174119 --- Fix it, then Ship it! Ship It!

Re: Review Request 56193: Use Docker cpus instead of cpu_share if possible.

2017-05-06 Thread Tomasz Janiszewski
> On Mar 27, 2017, 8:38 po poĊ‚udniu, Jie Yu wrote: > > src/docker/docker.cpp > > Lines 524 (patched) > > > > > > Can you test if docker support arbitratry double here like 1.01 > > (more than 3 digits after