Re: Review Request 59194: Validate DESTROY operation in `Resources::apply()`.

2017-05-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59194/#review174924 --- Fix it, then Ship it! src/common/resources.cpp Lines

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

2017-05-14 Thread Jiang Yan Xu
> On April 25, 2017, 9:41 a.m., James Peach wrote: > > src/master/allocator/mesos/metrics.hpp > > Lines 73 (patched) > > > > > > Since this metric is measuring the latency from when the allocation was > > dispatched

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

2017-05-14 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/#review174871 --- src/master/allocator/mesos/hierarchical.cpp Lines 1425-1435

Re: Review Request 59177: CLI: Added Config class to manage the config file.

2017-05-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/#review174920 --- Patch looks great! Reviews applied: [59177] Passed command:

Re: Review Request 59177: CLI: Added Config class to manage the config file.

2017-05-14 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59177/ --- (Updated May 15, 2017, 1:59 a.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58760: Added default secret resolver module.

2017-05-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/#review174913 --- Fix it, then Ship it! src/secret/resolver.cpp Lines 76

Re: Review Request 58759: Introduced SecretResolver module interface.

2017-05-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review174912 --- include/mesos/secret/resolver.hpp Lines 26-35 (patched)

Re: Review Request 58759: Introduced SecretResolver module interface.

2017-05-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review174911 --- Ship it! Ship It! - Gilbert Song On May 12, 2017, 10:52