Re: Review Request 59355: WIP: Optimized sorter perf for many inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59355/#review175463 --- Patch looks great! Reviews applied: [59383, 59355] Passed comman

Re: Review Request 59088: Implemented QuotaTree structure to be used by allocator.

> On May 15, 2017, 8:45 p.m., Alexander Rojas wrote: > > src/master/quota.hpp > > Lines 56 (patched) > > > > > > So after looking more closely I realized that in no small part this is > > a copy paste of the other `Q

Re: Review Request 59088: Implemented QuotaTree structure to be used by allocator.

> On May 15, 2017, 8:20 p.m., Alexander Rojas wrote: > > src/master/quota.hpp > > Lines 56 (patched) > > > > > > why do we need a new class called `QuotaTree` when we have already one > > in `quota_handler.cpp`? > >

Re: Review Request 59375: Added REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59375/#review175456 --- Patch looks great! Reviews applied: [59375] Passed command: expo

Re: Review Request 59318: Replace an EXPECT with an ASSERT in master_tests to avoid segfaults.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59318/#review175454 --- Bad patch! Reviews applied: [59318, 59001, 59000, 58999, 58760, 5

Re: Review Request 59355: WIP: Optimized sorter perf for many inactive clients.

> On May 18, 2017, 5:03 p.m., James Peach wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 478 (patched) > > > > > > I'd prefer this: > > > > ``` > > if (child->active || !child->children.

Review Request 59383: Added benchmark for allocator perf with many suppressed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59383/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 59355: WIP: Optimized sorter perf for many inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59355/ --- (Updated May 18, 2017, 10:40 p.m.) Review request for mesos, Benjamin Mahler an

Review Request 59375: Added REASON_TASK_HEALTH_CHECK_STATUS_UPDATED as task reason. (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59375/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain line feeds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59293/#review175426 --- Ship it! Ship It! - Joseph Wu On May 17, 2017, 3:13 p.m., An

Re: Review Request 59372: Disable port-mapping isolator by default.

> On May 18, 2017, 2:36 p.m., Jie Yu wrote: > > configure.ac > > Lines 347 (patched) > > > > > > Should we set enable_port_mapping_isolator=no here explicitly? Doing that would override the setting from `--enable-po

Re: Review Request 58358: Update vendored protobuf tar.gz to 3.2.0.

> On May 16, 2017, 10:27 p.m., Chun-Hung Hsiao wrote: > > I personally don't like using an RC version. We should update protobuf to > > an official release, say 3.3.1? > > Zhitao Li wrote: > IIRC the rc2 tar was what's available when I looked at the download page. > It seems like they have

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175420 --- Ship it! Confirmed that this works on macOS with default flags,

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175419 --- Fix it, then Ship it! configure.ac Lines 347 (patched)

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/ --- (Updated May 18, 2017, 2:28 p.m.) Review request for mesos, Jie Yu and Tim Hans

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175418 --- configure.ac Line 345 (original), 345 (patched)

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175417 --- Ship it! Ship It! - Tim Hansen On May 18, 2017, 5:56 p.m., K

Re: Review Request 59372: Disable port-mapping isolator by default.

> On May 18, 2017, 1:50 p.m., Tim Hansen wrote: > > configure.ac > > Line 346 (original), 346 (patched) > > > > > > This should also be enable_port_mapping_isolator=no No. The first action is when the flag is specif

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/ --- (Updated May 18, 2017, 1:56 p.m.) Review request for mesos, Jie Yu and Tim Hans

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175413 --- configure.ac Line 346 (original), 346 (patched)

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175412 --- configure.ac Line 346 (original), 346 (patched)

Re: Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/#review175411 --- configure.ac Line 192 (original), 192 (patched)

Review Request 59372: Disable port-mapping isolator by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59372/ --- Review request for mesos, Jie Yu and Tim Hansen. Repository: mesos Descriptio

Re: Review Request 59355: WIP: Improved sorter perf with many inactive clients.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59355/#review175396 --- src/master/allocator/sorter/drf/sorter.cpp Lines 478 (patched)

Re: Review Request 59141: Added new parameter 'data' to the URI fetcher interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59141/#review175360 --- include/mesos/uri/fetcher.hpp Line 72 (original), 74 (patched)