Re: Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

2017-05-26 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59578/#review176242 --- Ship it! Ship It! - Kevin Klues On May 25, 2017, 6:44 p.m.,

Re: Review Request 59578: Made MasterTest.MaxCompletedTasksPerFrameworkFlag less fragile.

2017-05-26 Thread Kevin Klues
> On May 26, 2017, 12:03 a.m., Kevin Klues wrote: > > src/tests/master_tests.cpp > > Lines 5635-5636 (patched) > > > > > > Is this something standard we've been doing recently to fix flaky > > tests? I'm not

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

2017-05-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/ --- (Updated May 27, 2017, 1:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

2017-05-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/ --- (Updated May 27, 2017, 1:32 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59545: Added a test to verify the agent flag 'executor_reregistration_timeout'.

2017-05-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59545/ --- (Updated May 27, 2017, 1:32 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 59616: Add `six` python package in install_require.

2017-05-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59616/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-26 Thread Joseph Wu
> On May 26, 2017, 9:52 a.m., Zhitao Li wrote: > > 3rdparty/cmake/Versions.cmake > > Lines 30 (patched) > > > > > > Can you explain how is these hashes geneareted and used? > > > > I'm working on upgrading

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review176219 --- Fix it, then Ship it!

Re: Review Request 59579: Fixed flakiness in MasterTest.EndpointsForHalfRemovedSlave.

2017-05-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59579/#review176216 --- Ship it! Ship It! - Anand Mazumdar On May 25, 2017, 7:05

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated May 26, 2017, 11:23 a.m.) Review request for mesos, Dmitry Zhuk, Ilya

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated May 26, 2017, 11:22 a.m.) Review request for . Bugs: MESOS-7508

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated May 26, 2017, 11:22 a.m.) Review request for . Bugs: MESOS-7508

Re: Review Request 59463: Added test for agent ping timeout during agent recovery.

2017-05-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59463/ --- (Updated May 26, 2017, 5:17 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58515: Update 3rdparty build to support protobuf 3.3.0.

2017-05-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58515/ --- (Updated May 26, 2017, 4:58 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 53841: Added metrics for sorting in the role and quota sorters.

2017-05-26 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53841/#review176110 --- For this and the next review, could you summarize how these

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review176208 --- 3rdparty/cmake/Versions.cmake Lines 30 (patched)

Re: Review Request 58360: Added a test for evolving large protobuf message.

2017-05-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58360/#review176207 --- Fix it, then Ship it! I would fix this minor thing before

Re: Review Request 58359: Update Mesos build library to use protobuf 3.3.0.

2017-05-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58359/#review176206 --- Ship it! For posterity, we would be asking framework

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

2017-05-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176198 --- Bad patch! Reviews applied: [59583, 59582] Failed command:

Re: Review Request 59584: Introduced executor reconnect retries on the agent.

2017-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59584/#review176195 --- Ship it! Ship It! - Vinod Kone On May 26, 2017, 12:56 a.m.,

Re: Review Request 59583: Added a test to verify executor driver message dropping behavior.

2017-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59583/#review176194 --- Ship it! Ship It! - Vinod Kone On May 25, 2017, 11:07 p.m.,

Re: Review Request 59582: Made the executor driver drop some messages when not connected.

2017-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59582/#review176193 --- Ship it! Ship It! - Vinod Kone On May 25, 2017, 10:48 p.m.,

Re: Review Request 59605: Use glog for logging in executors.

2017-05-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59605/#review176192 --- Patch looks great! Reviews applied: [59605] Passed command:

Review Request 59605: Use glog for logging in executors.

2017-05-26 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59605/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6961

Re: Review Request 59601: Removed an unused declaration in type_utils.hpp.

2017-05-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59601/#review176186 --- Patch looks great! Reviews applied: [59091, 59094, 59596, 59597,

Re: Review Request 59129: Introduced `inet6::Address` to handle IPv6 addresses in `libprocess`.

2017-05-26 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59129/ --- (Updated May 26, 2017, 6:38 a.m.) Review request for mesos, Benjamin Hindman