Re: Review Request 59525: Added filtering of `/slaves` endpoint and `GET_AGENTS` API call.

2017-06-10 Thread Greg Mann
> On June 11, 2017, 5:27 a.m., Greg Mann wrote: > > src/master/http.cpp > > Line 2385 (original), 2415 (patched) > > > > > > What about tests for these? To be more specific: at the very least we need tests which

Re: Review Request 59525: Added filtering of `/slaves` endpoint and `GET_AGENTS` API call.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review177555 --- src/master/http.cpp Lines 399 (patched)

Re: Review Request 59721: Refactored net::IP and added net::IPv4 and net::IPv6.

2017-06-10 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59721/ --- (Updated June 11, 2017, 1:16 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 59186: Additional linux/capabilities isolator documentation.

2017-06-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59186/#review177558 --- Bad review! Reviews applied: [59186, 59806, 59554] Error: No

Re: Review Request 59185: Add ambient capability support.

2017-06-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59185/#review177557 --- Bad patch! Reviews applied: [59185, 59552, 59551, 59550, 59549,

Re: Review Request 59552: Add support for explicitly setting bounding capabilities.

2017-06-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59552/ --- (Updated June 10, 2017, 9:43 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 59552: Add support for explicitly setting bounding capabilities.

2017-06-10 Thread James Peach
> On June 9, 2017, 9:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp > > Lines 99-103 (patched) > > > > > > In fact, i think the semantics should be: > > > > 1)

Re: Review Request 58964: Added authorization support for operator endpoints.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58964/#review177554 --- Fix it, then Ship it! src/tests/authorization_tests.cpp Lines

Re: Review Request 59147: Enabled authorization for v1 calls starting and stopping maintenance.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59147/#review177553 --- src/master/http.cpp Lines 4377-4379 (patched)

Re: Review Request 59099: Enabled authorization for v1 API call UPDATE_MAINTENANCE_SCHEDULE.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59099/#review177533 --- src/master/http.cpp Lines 4114-4115 (patched)

Re: Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59100/#review177552 --- src/master/http.cpp Line 4030 (original), 4030-4034 (patched)

Re: Review Request 59101: Enabled authorization when accesing maintenance status in v0 and v1 API.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59101/#review177549 --- Fix it, then Ship it! src/master/http.cpp Lines 4649-4651

Re: Review Request 59552: Add support for explicitly setting bounding capabilities.

2017-06-10 Thread Jie Yu
> On June 9, 2017, 9:28 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp > > Lines 99-103 (patched) > > > > > > In fact, i think the semantics should be: > > > > 1)

Re: Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59100/#review177548 --- Could you update the description to reflect that this also

Re: Review Request 59100: Enabled authorization for v1 API call GET_MAINTENANCE_SCHEDULE.

2017-06-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59100/#review177539 --- src/master/http.cpp Lines 4073 (patched)

Re: Review Request 59930: Support RO mode for bind mount volumes with filesystem/linux isolator

2017-06-10 Thread Gilbert Song
> On June 10, 2017, 1:09 a.m., Gilbert Song wrote: > > https://serverfault.com/questions/136515/read-only-bind-mount - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 59930: Support RO mode for bind mount volumes with filesystem/linux isolator

2017-06-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59930/#review177543 --- src/slave/containerizer/mesos/isolators/filesystem/linux.cpp