Review Request 60898: Added more tests for agent reregistration.

2017-07-16 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60898/ --- Review request for mesos, James Peach and Neil Conway. Bugs: MESOS-7711 htt

Re: Review Request 60400: Skipped consulting registry if the agent is in the `slaves.recovered`.

2017-07-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60400/#review180643 --- Patch looks great! Reviews applied: [60854, 60400] Passed comman

Re: Review Request 60898: Added more tests for agent reregistration.

2017-07-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60898/#review180644 --- Patch looks great! Reviews applied: [60854, 60400, 60898] Passed

Review Request 60899: Moved new Mesos CLI to src/python/.

2017-07-16 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60899/ --- Review request for mesos, Eric Chung and Kevin Klues. Repository: mesos Descr

Review Request 60900: Updated Python linter to work with multiple directories.

2017-07-16 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/ --- Review request for mesos, Eric Chung and Kevin Klues. Repository: mesos Descr

Re: Review Request 60900: Updated Python linter to work with multiple directories.

2017-07-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/#review180645 --- Patch looks great! Reviews applied: [60899, 60900] Passed comman

Review Request 60901: Use a consistent preprocessor check for ENABLE_PORT_MAPPING_ISOLATOR.

2017-07-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60901/ --- Review request for mesos and Qian Zhang. Bugs: MESOS-7675 https://issues.ap

Review Request 60903: Added the `network/ports` isolator to the Mesos containerizer.

2017-07-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60903/ --- Review request for mesos and Qian Zhang. Bugs: MESOS-7675 https://issues.ap

Review Request 60902: Moved the libnl3 configure checks into a macro.

2017-07-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/ --- Review request for mesos and Qian Zhang. Bugs: MESOS-7675 https://issues.ap

Re: Review Request 60496: Added socket checking to the network ports isolator.

2017-07-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated July 17, 2017, 12:04 a.m.) Review request for mesos, Qian Zhang and Ji

Re: Review Request 60901: Use a consistent preprocessor check for ENABLE_PORT_MAPPING_ISOLATOR.

2017-07-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60901/#review180650 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,

Re: Review Request 60594: Added a`network/ports` isolator nested container test.

2017-07-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60594/#review180651 --- Patch looks great! Reviews applied: [60491, 60493, 60494, 60764,

Re: Review Request 60901: Use a consistent preprocessor check for ENABLE_PORT_MAPPING_ISOLATOR.

2017-07-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60901/#review180652 --- Ship it! Ship It! - Qian Zhang On July 17, 2017, 7:42 a.m.,

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

2017-07-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/#review180653 --- configure.ac Line 350 (original)

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

2017-07-16 Thread James Peach
> On July 17, 2017, 3:20 a.m., Qian Zhang wrote: > > configure.ac > > Line 350 (original) > > > > > > So `--with-nl` is removed, will it cause backward compatibility issue? No, `--with-nl` is provided by the `MESOS_

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

2017-07-16 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/#review180655 --- Do we need to change anything in CMake side? - Qian Zhang On Ju

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

2017-07-16 Thread James Peach
> On July 17, 2017, 5:14 a.m., Qian Zhang wrote: > > Do we need to change anything in CMake side? No, this isn't implemented in the CMake build. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa