Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/#review183303 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 1

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review183307 --- src/slave/containerizer/mesos/containerizer.cpp Line 244 (origina

Re: Review Request 60903: Added the `network/ports` isolator to the Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60903/#review183311 --- Ship it! Ship It! - Qian Zhang On July 17, 2017, 7:44 a.m.,

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183318 --- Failed to apply patch! Reviews applied: [61262, 61189] Logs avai

Re: Review Request 61759: Updated the docs for V1 HEARTBEAT Event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61759/#review183319 --- Failed to apply patch! Reviews applied: [61759] Logs available h

Re: Review Request 61763: Added heartbeat interval for V1 Operator API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/#review183320 --- Failed to apply patch! Reviews applied: [61759, 61763] Logs avai

Re: Review Request 61666: Added a test to verify filtering of resource reservations on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61666/#review183321 --- src/tests/slave_authorization_tests.cpp Lines 106 (patched)

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/#review183332 --- src/checks/checker_process.cpp Lines 913-920 (original), 913-920

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183331 --- src/checks/checker_process.cpp Lines 644-650 (patched)

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 913-920 (original), 913-920 (patched) > > > > > > Let's print stderr regardless of the retcode, what you now do w

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/#review183336 --- src/checks/checker_process.cpp Lines 921-924 (original), 921-924

Re: Review Request 60592: Configure the `network/ports` isolator watch interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60592/ --- (Updated Aug. 21, 2017, 3:50 p.m.) Review request for mesos, Qian Zhang and Jia

Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61220/#review183353 --- Fix it, then Ship it! Would you mind rebasing it? Sorry it does

Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61220/ --- (Updated Aug. 21, 2017, 5:57 p.m.) Review request for mesos, Anand Mazumdar, Ka

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183351 --- src/checks/checker_process.cpp Lines 143-146 (patched)

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 644-650 (patched) > > > > > > I'd rather `VLOG(1)` here. It seems we do `LOG(INFO)` for important > > messages i

Re: Review Request 61620: Tracked successful task fetches rather than total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61620/#review183360 --- src/slave/containerizer/fetcher.cpp Line 575 (original), 573 (pat

Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61220/#review183365 --- Patch looks great! Reviews applied: [61220] Passed command: supp

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/ --- (Updated Aug. 21, 2017, 7:08 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 61620: Tracked successful task fetches rather than total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61620/ --- (Updated Aug. 21, 2017, 7:10 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 61697: Included nested command checks output in the executor logs.

> On Aug. 21, 2017, 6:10 p.m., Greg Mann wrote: > > src/checks/checker_process.cpp > > Lines 149-150 (patched) > > > > > > This seems more concise to me, and just as readable: > > > > s/stdoutReceived/stdout

Review Request 61791: Raised the logging level of some (health) check messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61791/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone. Bugs:

Re: Review Request 61620: Tracked successful task fetches rather than total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61620/#review183374 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 21, 2017, 12:10 p.m

Re: Review Request 61620: Tracked successful task fetches rather than total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61620/#review183375 --- Patch looks great! Reviews applied: [61620] Passed command: supp

Re: Review Request 61791: Raised the logging level of some (health) check messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61791/#review183376 --- Bad patch! Reviews applied: [61791, 61766, 61697] Failed command

Re: Review Request 60591: Optionally isolate only the agent network ports.

> On Aug. 21, 2017, 7:15 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 183 (patched) > > > > > > This method is only called by `NetworkPortsIsolatorProcess::create()

Re: Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- (Updated Aug. 21, 2017, 8:36 p.m.) Review request for mesos, Qian Zhang and Jia

Review Request 61798: Added _EXIT as alternative to ABORT.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61798/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler

Review Request 61799: Replaced ABORT with _EXIT in `childMain` to handle `os::execvpe` error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61799/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler

Review Request 61797: Added async-signal safe implementation of `write` function in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61797/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler

Review Request 61800: Enhanced async-signal safety of `signalSafeWriteStatus` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61800/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler

Review Request 61801: Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61801/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler

Re: Review Request 61260: Added agent garbage collection metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61260/#review183385 --- Can we cover the failure case in the tests? e.g., `GarbageCollect

Re: Review Request 61261: Documented agent garbage collection metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61261/#review183389 --- docs/monitoring.md Lines 1338 (patched)

Re: Review Request 61588: Added a `[-s|--skip-hooks]` option when applying reviews.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61588/#review183393 --- Patch looks great! Reviews applied: [61588] Passed command: expo

Re: Review Request 61664: Libprocess: Added a timeout for send socket operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61664/#review183390 --- Thanks Alex! A couple of things of note: (1) Looks like the libev

Re: Review Request 61801: Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61801/#review183394 --- Patch looks great! Reviews applied: [61797, 61798, 61799, 61800,

Re: Review Request 61791: Raised the logging level of some (health) check messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61791/#review183402 --- Ship it! Ship It! - Greg Mann On Aug. 21, 2017, 7:46 p.m., G

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/ --- (Updated Aug. 21, 2017, 10:01 p.m.) Review request for mesos, Qian Zhang and Ji

Re: Review Request 60766: Ignored containers that join CNI networks.

> On Aug. 21, 2017, 8:32 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Line 244 (original), 245 (patched) > > > > > > So here we only count `network/cni` isolator and `network/port_m

Review Request 61806: Updated depiction of runtime directory file structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61806/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305 https:/

Re: Review Request 60888: WIP: Added recovery logic for standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60888/ --- (Updated Aug. 21, 2017, 3:21 p.m.) Review request for mesos, Gilbert Song and J

Review Request 61805: Renamed CONTAINERS_DIR to EXECUTOR_RUNS_DIR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61805/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-7305 https:/

Re: Review Request 61697: Included nested command checks output in the executor logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61697/#review183405 --- Ship it! src/checks/checker_process.cpp Lines 648-649 (patched

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

> On Aug. 21, 2017, 1:46 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 921-924 (original), 921-924 (patched) > > > > > > Additionally `VLOG(1)` stderr? This failure message will be pr

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 916-919 (original), 916-919 (patched) > > > > > > Looking at this, I'm not sure we should return a failure here:

Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61766/#review183408 --- Ship it! Ship It! - Greg Mann On Aug. 19, 2017, 12:27 a.m.,

Re: Review Request 61805: Renamed CONTAINERS_DIR to EXECUTOR_RUNS_DIR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61805/#review183410 --- Ship it! Ship It! - Jie Yu On Aug. 21, 2017, 10:21 p.m., Jos

Re: Review Request 61124: Push metric history entries with their timestamp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61124/#review183412 --- Ship it! Ship It! - Jiang Yan Xu On July 25, 2017, 4:26 p.m.

Re: Review Request 61806: Updated depiction of runtime directory file structure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61806/#review183411 --- Fix it, then Ship it! src/slave/containerizer/mesos/paths.hpp

Re: Review Request 61806: Updated depiction of runtime directory file structure.

> On Aug. 21, 2017, 4:33 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/paths.hpp > > Lines 54 (patched) > > > > > > Align this field? Ah whoops. Was: ``` // | |-- // | |-- pid ``

Review Request 61808: Add task env overwriting executor env glog print

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61808/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Repository: mesos Descr

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review183429 --- Patch looks great! Reviews applied: [61262, 61189] Passed comman

Re: Review Request 61808: Add task env overwriting executor env glog print

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61808/#review183431 --- Patch looks great! Reviews applied: [61808] Passed command: supp

Re: Review Request 60491: Captured the inode when scanning for sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60491/#review183432 --- Ship it! Ship It! - Jie Yu On June 28, 2017, 7:44 a.m., Jame

Re: Review Request 60493: Removed diagnostic socket IPv4 assumptions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60493/#review183433 --- Ship it! Ship It! - Jie Yu On June 28, 2017, 7:45 a.m., Jame

Re: Review Request 60494: Exposed LinuxLauncher cgroups helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60494/#review183434 --- Ship it! Ship It! - Jie Yu On Aug. 14, 2017, 11:30 p.m., Jam

Re: Review Request 60764: Refactored isolator dependency checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60764/#review183435 --- Fix it, then Ship it! Thanks for the cleanup! src/slave/conta

Re: Review Request 60901: Use a consistent preprocessor check for ENABLE_PORT_MAPPING_ISOLATOR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60901/#review183437 --- Ship it! Ship It! - Jie Yu On July 16, 2017, 11:42 p.m., Jam

Re: Review Request 60836: Added IntervalSet to Ranges conversion helper declarations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60836/#review183438 --- Ship it! Ship It! - Jie Yu On July 13, 2017, 4:53 a.m., Jame

Re: Review Request 61538: Used common port range interval code in the port_mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61538/#review183439 --- Can you explain a bit more why this change? - Jie Yu On Aug. 9,

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/#review183440 --- Ship it! Ship It! - Jie Yu On July 16, 2017, 11:43 p.m., Jam

Re: Review Request 60492: Added a `network/ports` isolator skeleton.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60492/#review183441 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/