Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review184024 --- Patch looks great! Reviews applied: [61262, 61189] Passed comman

Re: Review Request 61901: Added common validation for Volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61901/#review184023 --- Ship it! Ship It! - Joseph Wu On Aug. 28, 2017, 8:28 p.m., J

Re: Review Request 61189: Added authorization for V1 events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61189/#review184021 --- Failed to apply patch! Reviews applied: [61262, 61189] Logs avai

Re: Review Request 61189: Added authorization for V1 events.

> On 八月 23, 2017, 12:29 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 2214 (patched) > > > > > > Since you don't modify these flags at all, you can get rid of this. If > > you start the master withou

Re: Review Request 61189: Added authorization for V1 events.

> On 八月 16, 2017, 9:21 a.m., Alexander Rojas wrote: > > Can you also update the summary to mention that it only affects the > > `SUBSCRIBE` event. The authorization filtering does affect othre events. And I have updated the summary to make it more specific, thanks. - Quinn

Re: Review Request 61901: Added common validation for Volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61901/ --- (Updated Aug. 29, 2017, 3:28 a.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 60890: WIP: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/#review184020 --- include/mesos/agent/agent.proto Line 65 (original), 67 (patched)

Re: Review Request 61901: Added common validation for Volume.

> On Aug. 28, 2017, 7:11 p.m., Joseph Wu wrote: > > src/common/validation.cpp > > Lines 206 (patched) > > > > > > Seems like you could start with adding this: > > ``` > > if (!path::absolute(volume.host_path(

Re: Review Request 60890: WIP: Defined API for launching standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60890/ --- (Updated Aug. 28, 2017, 5:26 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 61927: MESOS-7912 In strict mode code, functions can only be declared at top level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61927/#review184015 --- Ship it! Ship It! - Benjamin Mahler On Aug. 26, 2017, 1:14 p

Re: Review Request 61899: Added HOST_PATH volume source protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61899/#review184013 --- Ship it! Ship It! - Joseph Wu On Aug. 24, 2017, 4:57 p.m., J

Re: Review Request 61900: Added equal operator for Error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61900/#review184014 --- Ship it! Ship It! - Joseph Wu On Aug. 24, 2017, 4:58 p.m., J

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review184009 --- Failed to apply patch! Reviews applied: [61473] Logs available h

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review184007 --- Bad patch! Reviews applied: [61473] Failed command: python suppo

Re: Review Request 61929: Parameterized the volume host path tests on executor type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61929/#review184004 --- Ship it! None of our other test parameterization goes this far,

Re: Review Request 61666: Added test to verify filtering of resource reservations & allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61666/#review184000 --- Patch looks great! Reviews applied: [60915, 61666] Passed comman

Re: Review Request 60622: Add new stout function: path::uri (convert filename to valid URI).

> On Aug. 15, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 77 (patched) > > > > > > If this is the case, what are we doing on Linux if the path has > > backslashes

Re: Review Request 61919: Adjusted the test helpers for creating host and sandbox path volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61919/#review183997 --- Ship it! Ship It! - Joseph Wu On Aug. 25, 2017, 3:29 p.m., J

Re: Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61915/#review183996 --- src/slave/containerizer/docker.cpp Lines 1869-1870 (patched)

Re: Review Request 61908: Used path::absolute to replace some startsWith checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61908/#review183995 --- Ship it! Oh, didn't notice this one when I commented on an earl

Re: Review Request 61907: Moved host volume related tests to a dedicated file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61907/#review183994 --- Ship it! Ship It! - Joseph Wu On Aug. 24, 2017, 5 p.m., Jie

Re: Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/#review183993 --- Should we also update the upgrade guide in the documentation with

Re: Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/#review183992 --- Ship it! Ship It! - Greg Mann On Aug. 28, 2017, 8:46 p.m., M

Re: Review Request 61906: Added a dependency check 'filesystem/linux' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61906/#review183991 --- Ship it! Ship It! - Joseph Wu On Aug. 24, 2017, 5 p.m., Jie

Re: Review Request 61905: Integrated 'volume/host_path' into MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61905/#review183982 --- Ship it! src/slave/containerizer/mesos/isolators/filesystem/li

Re: Review Request 61904: Added volume/host_path isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61904/#review183978 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 61946: Added validation of resource provider operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61946/#review183988 --- src/master/validation.cpp Lines 2205 (patched)

Re: Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/ --- (Updated Aug. 28, 2017, 1:46 p.m.) Review request for mesos and Greg Mann. Ch

Re: Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/#review183986 --- Patch looks great! Reviews applied: [61952] Logs available here:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review183985 --- Patch looks great! Reviews applied: [61172] Passed command: expo

Re: Review Request 61904: Added volume/host_path isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61904/ --- (Updated Aug. 28, 2017, 8:26 p.m.) Review request for mesos, Gilbert Song and J

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review183980 --- Bad patch! Reviews applied: [61172] Logs available here: http://

Re: Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61915/#review183979 --- Fix it, then Ship it! src/slave/containerizer/docker.cpp Lines

Re: Review Request 61899: Added HOST_PATH volume source protobuf.

> On Aug. 28, 2017, 6:58 p.m., Joseph Wu wrote: > > include/mesos/mesos.proto > > Lines 2516-2518 (original), 2516-2518 (patched) > > > > > > Does this new enum deprecate this `host_path` field? > > > > T

Re: Review Request 61662: Added SlaveRecoveryTest.RebootWithSlaveInfoMismatchAndRestart test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61662/#review183976 --- Ship it! Will fix the nit when committing. src/tests/slave_re

Re: Review Request 61661: Added 'latest' symlink removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61661/#review183975 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 15, 2017, 7:48 a.m.

Re: Review Request 61902: Added master and agent validation for ContainerInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61902/#review183974 --- Ship it! LGTM (assuming the upstream patches don't change much)

Re: Review Request 61903: Fixed a indentation issue in linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61903/#review183973 --- Ship it! Ship It! - Joseph Wu On Aug. 24, 2017, 4:59 p.m., J

Re: Review Request 61901: Added common validation for Volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61901/#review183968 --- src/common/validation.cpp Lines 206 (patched)

Re: Review Request 61899: Added HOST_PATH volume source protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61899/#review183972 --- include/mesos/mesos.proto Lines 2516-2518 (original), 2516-2518 (

Re: Review Request 58021: Added storage-related offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58021/#review183971 --- src/common/protobuf_utils.cpp Line 442 (original), 442 (patched)

Re: Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/#review183969 --- This change LGTM, one small nit below. Could you also verify this

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183970 --- Patch looks great! Reviews applied: [61849] Logs available here:

Re: Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/ --- (Updated Aug. 28, 2017, 11:31 a.m.) Review request for mesos and Greg Mann. B

Re: Review Request 61947: Implemented handling of resource provider offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/#review183967 --- Bad patch! Reviews applied: [61947, 61946, 61810, 58021, 58047, 5

Re: Review Request 58048: Added id to Resource.DiskInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review183960 --- src/common/resources.cpp Line 187 (original), 187 (patched)

Review Request 61952: Fixed the communication between old masters and new agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61952/ --- Review request for mesos and Greg Mann. Repository: mesos Description ---

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review183963 --- bump? - Eric Chung On Aug. 9, 2017, 5:54 p.m., Eric Chung wrote

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review183958 --- Bad patch! Reviews applied: [61473] Failed command: python suppo

Re: Review Request 61947: Implemented handling of resource provider offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/#review183953 --- Failed to apply patch! Reviews applied: [61275, 61654, 61271, 612

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review183952 --- Failed to apply patch! Reviews applied: [61473] Logs available h

Re: Review Request 61924: Moved the 'RejectingObjectApprover' to a public header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61924/#review183949 --- Bad patch! Reviews applied: [61922, 61923, 61924] Logs available

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183946 --- Patch looks great! Reviews applied: [61849] Passed command: expo

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Aug. 28, 2017, 3:31 p.m.) Review request for mesos, Vinod Kone and Jia

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Aug. 10, 2017, 9 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 342 (patched) > > > > > > One empty line above. Fixed > On Aug. 10, 2017, 9 p.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > L

Review Request 61947: Implemented handling of resource provider offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61947/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos Desc

Review Request 61946: Added validation of resource provider operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61946/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos Desc

Re: Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61915/#review183931 --- Patch looks great! Reviews applied: [61915] Logs available here:

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183930 --- Ship it! - Andrei Budnik On Aug. 25, 2017, 5:34 p.m., Armand

Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61849/#review183925 --- Patch looks great! Reviews applied: [61849] Logs available here:

Re: Review Request 60915: Enabled filtering of resource allocations and reservations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60915/#review183921 --- Ship it! Ship It! - Alexander Rojas On July 21, 2017, 2:24 a

Re: Review Request 61801: Used _EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61801/#review183918 --- Patch looks great! Reviews applied: [61797, 61798, 61799, 61800,

Re: Review Request 61929: Parameterized the volume host path tests on executor type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61929/#review183916 --- Patch looks great! Reviews applied: [61899, 61900, 61901, 61902,

Re: Review Request 61921: Added tests to ensure that tasks can access their parent's volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61921/#review183911 --- Failed to apply patch! Reviews applied: [61921] Logs available h

Re: Review Request 61920: Added a test that uses environment secrets and the DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61920/#review183910 --- Failed to apply patch! Reviews applied: [61920] Logs available h

Re: Review Request 61927: MESOS-7912 In strict mode code, functions can only be declared at top level

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61927/#review183909 --- Bad review! Error: No reviewers specified. Please find a reviewer