Re: Review Request 60495: Added network ports isolator listen socket utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review184953 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line 11

Re: Review Request 61536: Added network ports isolator socket utilities tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61536/#review184954 --- src/tests/containerizer/ports_isolator_tests.cpp Lines 51 (patche

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review184958 --- Ship it! Ship It! - Qian Zhang On Sept. 8, 2017, 8:09 a.m.,

Re: Review Request 60593: Added `network/ports` isolator recovery tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/#review184960 --- Ship it! Ship It! - Qian Zhang On Sept. 8, 2017, 5:57 a.m.,

Re: Review Request 62147: Added a comment about master sending a checkpointed resources message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62147/#review184964 --- Ship it! Ship It! - Jan Schlicht On Sept. 7, 2017, 6:11 a.m.

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review184967 --- src/checks/tcp_connect.cpp Line 119 (original), 119 (patched)

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review184968 --- src/logging/logging.cpp Line 156 (original), 165 (patched)

Review Request 62187: This patch is needed to triger Apache CI build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62187/ --- Review request for mesos, Andrei Budnik and Alexander Rukletsov. Repository: me

Re: Review Request 62187: This patch is needed to triger Apache CI build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62187/#review184995 --- FAIL: Some Mesos tests failed. Please check http://dcos-win.westu

Re: Review Request 61982: Cleaned up DefaultExecutor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61982/#review184853 --- src/tests/default_executor_tests.cpp Line 178 (original), 166 (pa

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review185019 --- Ship it! Ship It! - Greg Mann On Sept. 7, 2017, 6:09 p.m., G

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review185021 --- Could you just update the description with some info about the spe

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/ --- (Updated Sept. 8, 2017, 10:13 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/ --- (Updated Sept. 8, 2017, 10:13 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/ --- (Updated Sept. 8, 2017, 10:35 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 61536: Added network ports isolator socket utilities tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61536/ --- (Updated Sept. 8, 2017, 10:42 p.m.) Review request for mesos, Qian Zhang and Ji

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/ --- (Updated Sept. 8, 2017, 10:44 p.m.) Review request for mesos, Qian Zhang and Ji

Review Request 62196: Updated the HTTP executor authentication docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62196/ --- Review request for mesos and James Peach. Repository: mesos Description -

Re: Review Request 62196: Updated the HTTP executor authentication docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62196/#review185031 --- Ship it! Ship It! - James Peach On Sept. 8, 2017, 10:48 p.m.

Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad. Bugs: M

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review185032 --- ERROR: Failed to apply patch 60491. Please check http://dcos-win.

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185035 --- FAIL: Mesos tests failed to build. Please check http://dcos-win.w

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/#review185036 --- ERROR: Failed to apply patch 62197. Please check http://dcos-win.

Re: Review Request 61109: Used the default value when parsing an optional enum field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61109/#review185038 --- Ship it! This looks pretty reasonable to me. It's unfortunate t

Re: Review Request 61174: Added a test `ProtobufTest.ParseJSONOptionalEnum`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61174/#review185039 --- Ship it! Ship It! - James Peach On July 27, 2017, 8:19 a.m.,

Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/ --- (Updated Sept. 9, 2017, 12:03 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/ --- (Updated Sept. 9, 2017, 12:03 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61982: Cleaned up DefaultExecutor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61982/ --- (Updated Sept. 9, 2017, 12:03 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 61109: Used the default value when parsing an optional enum field.

> On Sept. 8, 2017, 11:59 p.m., James Peach wrote: > > This looks pretty reasonable to me. It's unfortunate that this will convert > > all invalid enum names into the default value, but AFAICT that is > > unavoidable. Since we're talking about optional enums, it's not obvious to me whether it'

Re: Review Request 62042: Changed `EXPECT` to `ASSERT` when relying on the assertion afterwards.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review185043 --- ERROR: Failed to apply patch 62197. Please check http://dcos-win.

Review Request 62203: Use a `process::Executor` to ensure safety of asynchronous callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62203/ --- Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone. Repo

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/ --- (Updated Sept. 9, 2017, 6:52 a.m.) Review request for mesos, Benjamin Bannier,