Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.

> On Sept. 18, 2017, 8:29 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos tests failed. > > > > Reviews applied: `['62391']` > > > > Failed command: `C:\mesos\src\mesos-tests.exe --verbose` > > > > All the build artifacts available at: > >

Re: Review Request 61528: Implemented a registrar for resource provider manager state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/#review183651 --- src/master/registry.proto Lines 73-75 (patched)

Re: Review Request 62003: Added `network/ports` isolator nested container tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review185641 --- FAIL: Failed to apply the dependent review: 60491. Failed

Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62391/#review185640 --- FAIL: Some Mesos tests failed. Reviews applied: `['62391']`

Re: Review Request 60766: Ignored containers that join CNI networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60766/#review185637 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60495: Added network ports isolator listen socket utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/#review185635 --- src/slave/containerizer/mesos/isolators/network/ports.cpp Line

Re: Review Request 60496: Added socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- (Updated Sept. 19, 2017, 12:20 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60495: Added network ports isolator listen socket utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Sept. 19, 2017, 12:19 a.m.) Review request for mesos, Qian Zhang and

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 16, 2017, 3 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 421-424 (patched) > > > > > > We need to log this message like what we did here: > > > >

Re: Review Request 60496: Added socket checking to the network ports isolator.

> On Sept. 16, 2017, 3 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 421-424 (patched) > > > > > > I did some experiments and found when I launch a comman task

Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62391/ --- (Updated Sept. 18, 2017, 4:39 p.m.) Review request for mesos, James Peach and

Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.

> On Sept. 18, 2017, 3:49 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some Mesos stdout-tests tests failed. > > > > Reviews applied: `['62391']` > > > > Failed command: `C:\mesos\3rdparty\stout\tests\Debug\stout-tests.exe` > > > > All the build artifacts available at: > >

Re: Review Request 62391: Fixed invalid handle bug in `os::process()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62391/#review185627 --- FAIL: Some Mesos stdout-tests tests failed. Reviews applied:

Re: Review Request 62332: Linted JavaScript files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62332/#review185626 --- FAIL: Some Mesos tests failed. Reviews applied: `['62332']`

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/#review185583 --- src/slave/slave.cpp Lines 1524 (patched)

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185624 --- Ship it! I'll fix the outstanding issues and commit this for

Review Request 62391: Fixed invalid handle bug in `os::process()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62391/ --- Review request for mesos, James Peach and Joseph Wu. Bugs: MESOS-7988

Re: Review Request 62288: Added Log.Reader.catchup() method to Java bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62288/#review185623 --- Patch looks great! Reviews applied: [62283, 62284, 62285, 62286,

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62381/#review185622 --- FAIL: Some Mesos tests failed. Reviews applied: `['62381']`

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

> On Sept. 8, 2017, 4:40 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos tests failed to build. Please check > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62176/logs/mesos-tests-cmake-build.log > > for any relevant errors > > > > Reviews applied: [62105, 62106, 62176]

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

> On Sept. 18, 2017, 4:18 p.m., Andrei Budnik wrote: > > src/examples/long_lived_framework.cpp > > Lines 578 (patched) > > > > > > Extra newline? > > Alexander Rukletsov wrote: > This seems to be consistent to

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

> On Sept. 18, 2017, 12:45 p.m., Andrew Schwartzmeyer wrote: > > Ship It! (But wait on required reviews; i.e. this isn't for the whole chain.) - Andrew --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 62176: Added cmake dependency check for libsasl2 on non-Windows platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62176/#review185617 --- Ship it! Ship It! - Andrew Schwartzmeyer On Sept. 8, 2017,

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

> On Sept. 18, 2017, 12:42 p.m., Andrew Schwartzmeyer wrote: > > src/master/master.cpp > > Lines 494-605 (original), 494-587 (patched) > > > > > > I believe this to be fine, and I briefly checked with Jie (I think)

Re: Review Request 62106: Enabled CRAM MD5 Authentication on Windows and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62106/#review185614 --- src/CMakeLists.txt Line 617 (original), 613-614 (patched)

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185611 --- src/cli/execute.cpp Line 1026 (original), 1021 (patched)

Re: Review Request 62105: Enabled building of the Cyrus SASL CRAM MD5 lib on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review185613 --- 3rdparty/CMakeLists.txt Lines 189-213 (patched)

Re: Review Request 62357: Updated logging initialization arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/#review185609 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 18, 2017,

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review185608 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 18, 2017,

Re: Review Request 62122: Fixed parameter name in uri/fetcher.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62122/#review185607 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 6, 2017,

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

> On Sept. 18, 2017, 4:18 p.m., Andrei Budnik wrote: > > src/examples/long_lived_framework.cpp > > Lines 578 (patched) > > > > > > Extra newline? This seems to be consistent to other frameworks. > On Sept. 18,

Re: Review Request 62365: Added the missing isolators to the doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62365/#review185603 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2017, 6:10

Re: Review Request 62308: Added the description for the isolators section.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62308/#review185601 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2017, 6:49

Re: Review Request 62307: Added gpu/nvidia isolator to the index.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62307/#review185600 --- Ship it! Ship It! - Gilbert Song On Sept. 13, 2017, 1:51

Re: Review Request 62306: Added an index in the mesos containerizer doc about isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62306/#review185599 --- Ship it! Ship It! - Gilbert Song On Sept. 13, 2017, 1:51

Re: Review Request 62304: Moved linux capabilities isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62304/#review185597 --- Ship it! Ship It! - Gilbert Song On Sept. 13, 2017, 1:51

Re: Review Request 62305: Moved posix rlimits isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62305/#review185598 --- Ship it! Ship It! - Gilbert Song On Sept. 13, 2017, 1:51

Re: Review Request 62303: Moved IPC namespace isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62303/#review185596 --- Ship it! Ship It! - Gilbert Song On Sept. 13, 2017, 1:50

Re: Review Request 62302: Moved docker volume isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62302/#review185595 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2017, 6:46

Re: Review Request 62357: Updated logging initialization arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/ --- (Updated Sept. 18, 2017, 6:33 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62301/#review185592 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2017, 6:45

Re: Review Request 62300: Moved docker runtime isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62300/#review185591 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2017, 6:44

Re: Review Request 62297: Moved pid namespace isolator doc to the isolators folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62297/#review185588 --- Ship it! Ship It! - Gilbert Song On Sept. 15, 2017, 6:42

Re: Review Request 62158: Rescinded offers possibly affected by updates to agent total resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62158/#review185571 --- Fix it, then Ship it! src/master/master.cpp Lines 6779-6781

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review185569 --- Fix it, then Ship it! src/tests/resources_tests.cpp Lines

Re: Review Request 62037: Added logging::initialize to main functions that use glog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185565 --- PASS: Mesos patch 62037 was successfully built and tested.

Re: Review Request 62357: Updated logging initialization arguments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/#review185564 --- Ship it! Ship It! - Andrei Budnik On Sept. 18, 2017, 2:24

Re: Review Request 62214: Added JavaScript linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62214/ --- (Updated Sept. 18, 2017, 3:10 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review185557 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62381/#review185548 --- FAIL: Mesos tests failed to build. Reviews applied: `['62381']`

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/ --- (Updated Sept. 18, 2017, 1:05 p.m.) Review request for mesos, Andrei Budnik

Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62381/ --- Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent huang,