Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187160 --- Patch looks great! Reviews applied: [62780, 62781] Passed

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187157 --- FAIL: Failed to apply the dependent review: 62780. Failed

Re: Review Request 62781: Mesos UI: extract the agent URL generation to a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/#review187156 --- FAIL: Failed to apply the dependent review: 62780. Failed

Re: Review Request 62780: Mesos UI: used relative paths for master endpoints and static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62780/#review187155 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 62780: Mesos UI: used relative paths for master endpoints and static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62780/#review187154 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 62780: Mesos UI: used relative paths for master endpoints and static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62780/#review187152 --- Ship it! Ship It! - Benjamin Mahler On Oct. 5, 2017, 12:35

Review Request 62781: Mesos UI: extract the agent URL generation to a function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62781/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 62780: Mesos UI: used relative paths for master endpoints and static resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62780/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review187138 --- PASS: Mesos patch 62777 was successfully built and tested.

Re: Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review187127 --- PASS: Mesos patch 62777 was successfully built and tested.

Re: Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review187126 --- src/tests/default_executor_tests.cpp Lines 1273-1277 (patched)

Re: Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review187124 --- PASS: Mesos patch 62775 was successfully built and tested.

Review Request 62777: Fixed build dependency for `protobuf_tests.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-8052

Re: Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review187113 --- Patch looks great! Reviews applied: [62685, 62326, 62327, 62774,

Re: Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review187109 --- PASS: Mesos patch 62775 was successfully built and tested.

Re: Review Request 62327: Checked TASK_KILLED in the test `ROOT_INTERNET_CURL_PortMapper`.

> On Sept. 30, 2017, 1:13 a.m., Vinod Kone wrote: > > Can you also add tests for command and default executors to test this > > behavior? Did you mean Docker and default executors? I think this patch has already covered command executor. I have posted two patches for Docker and default

Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62774/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7975

Review Request 62775: Added a test `ROOT_INTERNET_CURL_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-7975

Re: Review Request 62326: Always send TASK_KILLED when the task is killed by a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62326/ --- (Updated Oct. 4, 2017, 11:43 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 62587: Added HTTP authenticatee interface definition.

> On Sept. 28, 2017, 5:54 p.m., Benjamin Bannier wrote: > > include/mesos/authentication/http/authenticatee.hpp > > Lines 48-49 (patched) > > > > > > Since our Doxygen setup uses `JAVADOC_AUTOBRIEF` which makes the

Re: Review Request 62638: Removed support for platforms without O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62638/#review187074 --- Fix it, then Ship it!