Re: Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/#review189882 --- Who is hausdorff and why is this their TODO? - Andrew

Review Request 63499: Fixed the unit test that broke Windows build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63499/ --- Review request for mesos, Andrew Schwartzmeyer and Vinod Kone. Repository:

Re: Review Request 63389: WIP: Added a mock resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/ --- (Updated Nov. 2, 2017, 4:44 a.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/#review189879 --- FAIL: Mesos tests failed to build. Reviews applied: `['61183',

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63472/#review189878 --- Ship it! Mind splitting the folder level readme from the

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63472/#review189876 --- Bad patch! Reviews applied: [63472] Failed command: python

Re: Review Request 63389: WIP: Added a mock resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63389/ --- (Updated Nov. 2, 2017, 3:28 a.m.) Review request for mesos, Jie Yu, Joseph Wu,

Re: Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.

> On Nov. 2, 2017, 12:47 a.m., Gaston Kleiman wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 4168-4169 (patched) > > > > > > I don't think this test passes now that the built-in

Review Request 63497: Fixed the unit test that missed to check the TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63497/ --- Review request for mesos, Alexander Rukletsov, Gaston Kleiman, and Vinod Kone.

Re: Review Request 63485: Added initial code for offer operation status update in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63485/#review189868 --- FAIL: Failed to apply the dependent review: 59988. Failed

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/#review189867 --- FAIL: Mesos tests failed to build. Reviews applied: `['63174']`

Review Request 63493: Transmitted agent resource versions in (re)registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63493/ --- Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.

Review Request 63494: Removed unused declaration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63494/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 63491: Added resource version to resource provider UpdateTotalResources call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/ --- Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.

Re: Review Request 61183: Triggered 'UpdateSlaveMessage' when 'ResourceProviderManager' updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61183/ --- (Updated Nov. 2, 2017, 2:57 a.m.) Review request for mesos, Jie Yu and Jan

Review Request 63495: Added comparison operators for 'ResourceVerionUUID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63495/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63492/ --- Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.

Review Request 63496: Added tests for agent resource version transmission.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63496/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 63468: Added TERMINATED state to processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63468/#review189865 --- Ship it! Could we avoid the shared pointer per the discussion?

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189861 --- Per offline discussion, looks like we don't actually need to be

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63476/#review189859 --- PASS: Mesos patch 63476 was successfully built and tested.

Review Request 63485: Added initial code for offer operation status update in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63485/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman,

Review Request 63484: Changed slave_id field to be optional in OfferOperationStatusUpdate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63484/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman,

Review Request 63483: Added some protobuf helper for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63483/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman,

Review Request 63482: Added streaming function for OfferOperationState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63482/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman,

Review Request 63481: Added latest_status field to OfferOperation protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63481/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman,

Re: Review Request 63432: Updated the comment about slaves.removed in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63432/ --- (Updated Nov. 1, 2017, 11:14 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 63480: Added the initial implementation for applying offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63480/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman,

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63414/ --- (Updated Nov. 1, 2017, 11:11 p.m.) Review request for mesos and Benjamin

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

> On Oct. 30, 2017, 3:44 p.m., Benjamin Bannier wrote: > > src/common/resources_utils.cpp > > Lines 97 (patched) > > > > > > We should try to prevent the initialization and copy assignement of > > `resource`, e.g.,

Re: Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63479/#review189855 --- FAIL: Mesos stdout-tests failed to build. Reviews applied:

Re: Review Request 63413: Added streaming functions for offer operation ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63413/ --- (Updated Nov. 1, 2017, 11:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/#review189854 --- Patch looks great! Reviews applied: [63353, 63474] Passed

Re: Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63472/#review189853 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/#review189851 --- FAIL: Mesos tests failed to build. Reviews applied: `['63353',

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63174/ --- (Updated Nov. 1, 2017, 3:06 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 63174: Added a benchmark for agent reregistration during master failover.

> On Oct. 24, 2017, 2:55 p.m., Benjamin Mahler wrote: > > A couple of suggestions for speeding up the benchmark overhead: > > > > (1) Upgrade protobuf to 3.4.x, this comes with move support and rvalue > > setters for fields. Which will avoid some copies in the benchmark code and > > improve

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

> On Nov. 1, 2017, 2:58 p.m., Andrew Schwartzmeyer wrote: > > Emoji test: > > Andrew Schwartzmeyer wrote: > :no_entry_sign: :double_vertical_bar: :heavy_check_mark: > > Andrew Schwartzmeyer wrote: > > > Andrew Schwartzmeyer wrote: > ?? > > Andrew Schwartzmeyer

Re: Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63476/#review189842 --- Emoji test: - Andrew Schwartzmeyer On Nov. 1, 2017,

Re: Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63479/#review189839 --- This will fail until it's been migrated, so we need to be careful

Re: Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63479/#review189838 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 1, 2017,

Review Request 63479: Migrated `3rdparty/mesos-3rdparty` to `mesos/3rdparty`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63479/ --- Review request for mesos and Andrew Schwartzmeyer. Repository: mesos

Review Request 63472: Replaced `concurrentqueue-1.0.0-beta` with `concurrentqueue-7b69a8f`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63472/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 63476: Revert "Added a test `ROOT_NoTransitionFromKillingToFinished`".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63476/ --- Review request for mesos, Qian Zhang and Vinod Kone. Bugs: MESOS-8157

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

> On Oct. 31, 2017, 3:43 p.m., Benjamin Mahler wrote: > > src/tests/master_slave_reconciliation_tests.cpp > > Lines 721 (patched) > > > > > > TaskExecutorIds? Renamed in RR 63474. - Gaston

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/ --- (Updated Nov. 1, 2017, 1:53 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 63474: Added a regression test for MESOS-8135.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63474/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone. Bugs:

Re: Review Request 62616: Binary packaging for Centos 7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review189824 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 63468: Added TERMINATED state to processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63468/#review189821 --- FAIL: Mesos tests failed to build. Reviews applied: `['63468']`

Re: Review Request 63468: Added TERMINATED state to processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63468/#review189820 --- Patch looks great! Reviews applied: [63468] Passed command:

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 538-548 (patched) > > > > > > This is racy; there's no guarantee that the first `TASK_RUNNING` status > > update

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

> On Nov. 1, 2017, 8 a.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 538-548 (patched) > > > > > > This is racy; there's no guarantee that the first `TASK_RUNNING` status > > update

Re: Review Request 62774: Added a test `ROOT_DOCKER_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62774/#review189811 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 63463: Added support for credential secret to test-http-framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63463/#review189805 --- Patch looks great! Reviews applied: [63463] Passed command:

Review Request 63468: Added TERMINATED state to processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63468/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

> On Nov. 1, 2017, 3 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 538-548 (patched) > > > > > > This is racy; there's no guarantee that the first `TASK_RUNNING` status > > update

Re: Review Request 62837: Added a test `DefaultExecutorTest.KillMultipleTasks`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62837/#review189800 --- src/tests/default_executor_tests.cpp Lines 538-548 (patched)

Review Request 63463: Added support for credential secret to test-http-framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63463/ --- Review request for mesos, Armand Grillet and Alexander Rojas. Repository:

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

> On Oct. 30, 2017, 3:44 p.m., Benjamin Bannier wrote: > > src/common/resources_utils.cpp > > Lines 104-121 (patched) > > > > > > It would be great if we could explicitly `break` for any case not > > containing an

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review189796 --- FAIL: Mesos tests failed to build. Reviews applied: `['62685',

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189793 --- Ship it! Ship It! - Qian Zhang On Nov. 1, 2017, 12:57 a.m.,

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

> On Nov. 1, 2017, 8:02 a.m., Gaston Kleiman wrote: > > LGTM, just two small comments: > > > > 1) The `TASK_STARTING` changes have landed, so we'll have to update the > > test. > > 2) There's a new helper method that we should use to create the `KILL` call. Thanks for the review comments! I

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

> On Nov. 1, 2017, 6:33 a.m., Vinod Kone wrote: > > Can you update the testing section. Ran it in a loop I hope? Updated the testing section, and yes, I ran it in a loop (100 times) and it works well. - Qian --- This is an

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/ --- (Updated Nov. 1, 2017, 7:45 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63453/#review189787 --- Patch looks great! Reviews applied: [63453] Passed command:

Re: Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63453/#review189785 --- PASS: Mesos patch 63453 was successfully built and tested.