Re: Review Request 64095: Added a generic actor to be used by status update managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64095/#review192904 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

> On Dec. 6, 2017, 12:23 a.m., Jie Yu wrote: > > src/resource_provider/storage/provider.cpp > > Lines 696-698 (patched) > > > > > > Can you comment on why this is not a fatal error and it is safe to > > ignore?

Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

> On Nov. 7, 2017, 12:37 a.m., Qian Zhang wrote: > > src/master/master.cpp > > Lines 9674-9676 (original), 9675-9678 (patched) > > > > > > To be consistent with this log message, I think we also need to change > >

Re: Review Request 61128: Improved log messages in master when adding/removing tasks/executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61128/ --- (Updated Dec. 6, 2017, 1:33 a.m.) Review request for mesos, Benno Evers and

Review Request 64357: Updated the allocator to untrack allocations via a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64357/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 63388: Handling offer operations in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63388/#review192955 --- src/resource_provider/storage/provider.cpp Lines 1901-1931

Re: Review Request 63387: Added publish/unpublish in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63387/#review192946 --- Fix it, then Ship it!

Re: Review Request 64145: Added status update acknowledgement to resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64145/#review192952 --- Ship it! Ship It! - Gaston Kleiman On Dec. 4, 2017, 11:37

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64143/#review192951 --- Ship it! Ship It! - Gaston Kleiman On Dec. 4, 2017, 11:33

Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64142/#review192950 --- Ship it! Ship It! - Gaston Kleiman On Dec. 4, 2017, 2:08

Re: Review Request 64093: Added operators for offer operation update protobuf classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64093/ --- (Updated Dec. 5, 2017, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

> On Dec. 5, 2017, 2:08 p.m., James DeFelice wrote: > > src/resource_provider/storage/provider.cpp > > Lines 1203 (patched) > > > > > > some plugins might not implement create/delete, but DO implement list. > >

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64304/ --- (Updated Dec. 5, 2017, 2:42 p.m.) Review request for mesos, Alexander

Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations.

> On Dec. 4, 2017, 5:08 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 1272 (patched) > > > > > > After reading through the test, this is the dynamic reservation case > >

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/#review192943 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 5:57 a.m.,

Re: Review Request 64355: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64355/#review192942 --- Ship it! Ship It! - Vinod Kone On Dec. 5, 2017, 10:37 p.m.,

Review Request 64355: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64355/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-8288

Review Request 64354: Added tests for UriVolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64354/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Bugs: MESOS-8251

Review Request 64353: Added example VolumeProfile module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Bugs: MESOS-8251

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review192895 --- Awesome! Only minor comments below. src/master/master.cpp Lines

Re: Review Request 63761: Replaced std::shared_ptr with std::unique_ptr in dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63761/#review192937 --- Ship it! Ship It! - Michael Park On Dec. 5, 2017, 10:07

Re: Review Request 63913: Replaced std::shared_ptr with std::unique_ptr in Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63913/#review192938 --- Ship it! Ship It! - Michael Park On Nov. 21, 2017, 9:52

Review Request 64352: Added default VolumeProfile module implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64352/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Bugs: MESOS-8251

Re: Review Request 63971: Defined a module interface for translating volume profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/ --- (Updated Dec. 5, 2017, 2:06 p.m.) Review request for mesos, Chun-Hung Hsiao

Review Request 64351: Moved generated CSI code into public directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64351/ --- Review request for mesos, Chun-Hung Hsiao and Jie Yu. Bugs: MESOS-8251

Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Dec. 5, 2017, 9:26 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 5, 2017, 9:25 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64012: Added new `--reconfiguration_policy` slave flag and implementation.

> On Dec. 5, 2017, 8:18 p.m., Vinod Kone wrote: > > src/slave/compatibility.hpp > > Lines 33-36 (original), 32-41 (patched) > > > > > > Instead of specifying each field here, since it can go out of date, why > >

Re: Review Request 64101: Skip registry update when nothing changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/#review192924 --- Ship it! Ship It! - Vinod Kone On Dec. 5, 2017, 1:36 p.m.,

Re: Review Request 64169: Check if slave is marked gone during reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64169/#review192923 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2017, 11:43 p.m.,

Re: Review Request 64012: Added new `--reconfiguration_policy` slave flag and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review192913 --- Fix it, then Ship it! src/slave/compatibility.hpp Lines 33-36

Re: Review Request 64342: Correctly updated total resources when agent capabilities changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64342/#review192921 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 5, 2017,

Re: Review Request 63641: Used move for events consumption in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63641/#review192917 --- Ship it! Ship It! - Michael Park On Nov. 7, 2017, 9:42

Re: Review Request 63638: Added callable once support in Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63638/#review192916 --- Ship it! Ship It! - Michael Park On Nov. 21, 2017, 9:51

Re: Review Request 63637: Added callable once support in defer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63637/#review192915 --- Ship it! Ship It! - Michael Park On Dec. 5, 2017, 4:20

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192911 --- Ship it! Ship It! - Vinod Kone On Dec. 5, 2017, 7:03 p.m.,

Re: Review Request 64338: Reduced number of supported arguments in _Deferred conversion operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64338/#review192910 --- Ship it! Ship It! - Michael Park On Dec. 5, 2017, 4:18

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 5, 2017, 7:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 63635: Prepared defer for use in callable once contexts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63635/#review192907 --- Ship it! Ship It! - Michael Park On Nov. 7, 2017, 8:51

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64008/#review192906 --- Ship it! Ship It! - Vinod Kone On Dec. 1, 2017, 6:32 p.m.,

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review192905 --- Fix it, then Ship it!

Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/#review192903 --- Ship it! Ship It! - Vinod Kone On Dec. 5, 2017, 5:39 p.m.,

Re: Review Request 64009: Added new UpdateSlave registry operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192902 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2017, 3:28 p.m.,

Re: Review Request 64252: Convert resource format of messages entering master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64252/#review192901 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2017, 3:27 p.m.,

Re: Review Request 64146: Added offer operation update acknowledgement to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64146/#review192893 --- Fix it, then Ship it! src/slave/slave.cpp Lines 3860

Re: Review Request 64347: Made libprocess event movable only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64347/#review192894 --- Ship it! Ship It! - Michael Park On Dec. 5, 2017, 10:06

Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64143/#review192891 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 7:33 a.m., Greg

Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64144/#review192890 --- Ship it! Ship It! - Jie Yu On Dec. 5, 2017, 7:06 a.m., Greg

Re: Review Request 63761: Replaced std::shared_ptr with std::unique_ptr in dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63761/ --- (Updated Dec. 5, 2017, 6:07 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64347: Made libprocess event movable only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64347/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 63631: Separated event visiting and consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63631/ --- (Updated Dec. 5, 2017, 6 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64010/ --- (Updated Dec. 5, 2017, 5:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64332: Removed `constexpr`-ness from `cpp17::invoke`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64332/#review192885 --- Ship it! - Benjamin Bannier On Dec. 5, 2017, 9:55 a.m.,

Re: Review Request 64331: Added more `cpp17::invoke` test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64331/#review192884 --- Ship it! Ship It! - Benjamin Bannier On Dec. 5, 2017, 9:31

Re: Review Request 64151: Added a V1 API call to list resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/#review192877 --- include/mesos/agent/agent.proto Lines 60 (patched)

Re: Review Request 63631: Separated event visiting and consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63631/#review192879 --- Fix it, then Ship it!

Re: Review Request 64342: Correctly updated total resources when agent capabilities changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64342/#review192880 --- Ship it! Ship It! - Benjamin Bannier On Dec. 5, 2017, 4:33

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/ --- (Updated Dec. 5, 2017, 4:14 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64012: Added new `--reconfiguration_policy` slave flag and implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/ --- (Updated Dec. 5, 2017, 4:02 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

> On Dec. 4, 2017, 11:14 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp > > Lines 8912 (patched) > > > > > > what about testing the resources? I originally left that out because it has to assume quite a

Review Request 64342: Correctly updated total resources when agent capabilities changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64342/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier.

Re: Review Request 64337: Fixed CallableOnce operator() signature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64337/#review192872 --- Ship it! Ship It! - Michael Park On Dec. 5, 2017, 4:13

Re: Review Request 63636: Added placeholder implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63636/ --- (Updated Dec. 5, 2017, 7:21 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 63914: Changed agent reregistration to work with message directly.

> On Dec. 4, 2017, 9:18 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 6492-6499 (patched) > > > > > > Hm.. I'm curious if you have any thoughts on avoiding copying it out of > > the message. We

Re: Review Request 63914: Changed agent reregistration to work with message directly.

> On Dec. 4, 2017, 5:57 p.m., Michael Park wrote: > > src/master/master.cpp > > Line 6433 (original), 6394 (patched) > > > > > > I think these `message` to `message_` changes should either take the > > type of the

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

> On Dec. 4, 2017, 7:37 p.m., Michael Park wrote: > > src/master/master.hpp > > Line 128 (original), 128 (patched) > > > > > > Maybe we can consider making this `vector&&` as discussed in > >

Re: Review Request 64151: Added a V1 API call to list resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/ --- (Updated Dec. 5, 2017, 3:34 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63022: Imported and reconcile resources from CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63022/#review192864 --- src/resource_provider/storage/provider.cpp Lines 1203 (patched)

Re: Review Request 63632: Migrated to event consumer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63632/ --- (Updated Dec. 5, 2017, 1:50 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64151: Added a V1 API call to list resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/#review192860 --- include/mesos/agent/agent.proto Lines 445 (patched)

Re: Review Request 64101: Skip registry update when nothing changed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64101/ --- (Updated Dec. 5, 2017, 1:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/ --- (Updated Dec. 5, 2017, 2:05 p.m.) Review request for mesos, Alexander

Re: Review Request 63637: Added callable once support in defer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63637/ --- (Updated Dec. 5, 2017, 12:20 p.m.) Review request for mesos, Benjamin Mahler

Review Request 64338: Reduced number of supported arguments in _Deferred conversion operators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64338/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Review Request 64337: Fixed CallableOnce operator() signature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64337/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/ --- (Updated Dec. 5, 2017, 11:17 a.m.) Review request for mesos, Alexander

Re: Review Request 64247: Fixed a flaky test case in reservation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64247/ --- (Updated Dec. 5, 2017, 12:15 p.m.) Review request for mesos, Alexander

Review Request 64335: Made "agent_features" flag available on non-Linux systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64335/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Jie Yu.

Re: Review Request 64151: Added a V1 API call to list resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64151/ --- (Updated Dec. 5, 2017, 10:48 a.m.) Review request for mesos, Benjamin Bannier

Review Request 64332: Removed `constexpr`-ness from `cpp17::invoke`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64332/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 64331: Added more `cpp17::invoke` test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64331/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description