Re: Review Request 65474: Updated socket shutdown to return SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65474/#review196688 --- 3rdparty/libprocess/include/process/socket.hpp Line 193 (original

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196687 --- Can you include Andy on this review as well? I would love to know

Review Request 65474: Updated socket shutdown to return SocketError.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65474/ --- Review request for mesos, Andrei Budnik and Benjamin Mahler. Bugs: MESOS-8513

Review Request 65475: Fixed SSL socket shutdown returned errno.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/ --- Review request for mesos, Benjamin Mahler and Joseph Wu. Repository: mesos De

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

> On Jan. 19, 2018, 11:30 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 210-233 (patched) > > > > > > As we discussed offline, it would be great if we can move this into the

Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65060/ --- (Updated Feb. 2, 2018, 5:25 a.m.) Review request for mesos, Gaston Kleiman, Gre

Review Request 65472: Added `csi::paths::parseContainerPath` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65472/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Repository: me

Review Request 65471: Made the SLRP tests more consistent in coding style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65471/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Repository: me

Re: Review Request 65032: Added a SLRP unit test for agent reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65032/ --- (Updated Feb. 2, 2018, 5:07 a.m.) Review request for mesos, Gaston Kleiman, Gre

Re: Review Request 65032: Added a SLRP unit test for agent reboot.

> On Jan. 18, 2018, 6:49 p.m., Greg Mann wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 1749 (patched) > > > > > > I'm curious why you place all expectations together in some tests, and >

Re: Review Request 65463: Removed the `mesos-style.py` run from `buildbot.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65463/#review196672 --- Ship it! +1 use docker - Jie Yu On Feb. 1, 2018, 7:20 p.m.,

Re: Review Request 65470: Added metrics for showing number of subscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65470/#review196671 --- PASS: Mesos patch 65470 was successfully built and tested. Review

Re: Review Request 65470: Added metrics for showing number of subscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65470/ --- (Updated Feb. 2, 2018, 12:27 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 65467: Windows: Added `internal::windows::enable_inherit(WindowsFD)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65467/ --- Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Repository: mesos

Review Request 65469: Windows: Made `IO::OWNED` file descriptors inheritable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65469/ --- Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Repository: mesos

Re: Review Request 65409: Fixed `SlaveRecoveryTest.ReconcileTasksMissingFromSlave`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65409/ --- (Updated Feb. 1, 2018, 4:15 p.m.) Review request for mesos, Akash Gupta, Jie Yu

Re: Review Request 65408: Windows: Ported `slave_recovery_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65408/ --- (Updated Feb. 1, 2018, 4:14 p.m.) Review request for mesos, Akash Gupta, Jie Yu

Re: Review Request 65407: Windows: Enabled tests that were blocked by MESOS-7604.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65407/ --- (Updated Feb. 1, 2018, 4:03 p.m.) Review request for mesos, Akash Gupta, Jie Yu

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated Feb. 1, 2018, 3:52 p.m.) Review request for mesos and Greg Mann. Bug

Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65363/ --- (Updated Feb. 1, 2018, 3:50 p.m.) Review request for mesos and Greg Mann. Cha

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/ --- (Updated Feb. 1, 2018, 3:49 p.m.) Review request for mesos and Greg Mann. Cha

Re: Review Request 65362: Added a method to increment invalid scheduler API call counters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65362/ --- (Updated Feb. 1, 2018, 3:48 p.m.) Review request for mesos and Greg Mann. Cha

Review Request 65470: Added metrics for showing number of subscribed resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65470/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann. Bug

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

> On Feb. 1, 2018, 10:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/main.cpp > > Lines 40-50 (patched) > > > > > > Flying by. Why this logic is not in launch.cpp? Sounds to me it's > > unrelated to, for ex

Re: Review Request 65405: Implemented `net::socket()` for Windows using `WSASocket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65405/ --- (Updated Feb. 1, 2018, 3:30 p.m.) Review request for mesos, Akash Gupta, Jie Yu

Re: Review Request 65403: Windows: Disabled `O_CLOEXEC` semantic mapping on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65403/ --- (Updated Feb. 1, 2018, 3:23 p.m.) Review request for mesos, Akash Gupta, Jie Yu

Re: Review Request 65401: Windows: Enabled `Flags::runtime_directory` for checkpointing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65401/ --- (Updated Feb. 1, 2018, 3:22 p.m.) Review request for mesos, Akash Gupta, Jie Yu

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

> On Feb. 1, 2018, 2:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/main.cpp > > Lines 40-50 (patched) > > > > > > Flying by. Why this logic is not in launch.cpp? Sounds to me it's > > unrelated to, for exa

Re: Review Request 65447: Refactored couple of launch task sanity checks into a single code path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65447/#review196664 --- src/slave/slave.cpp Lines 2064-2065 (original), 2049-2050 (patche

Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65446/#review196663 --- Ship it! Ship It! - Vinod Kone On Feb. 1, 2018, 2:01 a.m., M

Re: Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65445/#review196661 --- src/messages/messages.proto Lines 333 (patched)

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review196662 --- src/slave/containerizer/mesos/main.cpp Lines 40-50 (patched)

Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65369/#review196658 --- PASS: Mesos patch 65369 was successfully built and tested. Review

Re: Review Request 65437: Added documentation for fault domains.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65437/#review196653 --- docs/configuration/master-and-agent.md Lines 99 (patched)

Re: Review Request 65414: Added tests for `Resources.find` on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65414/#review196656 --- Ship it! Ship It! - James Peach On Feb. 1, 2018, 9:50 p.m.,

Re: Review Request 65414: Added tests for `Resources.find` on revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65414/ --- (Updated Feb. 1, 2018, 9:50 p.m.) Review request for mesos, Anish Gupta and Jam

Re: Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65369/ --- (Updated Feb. 1, 2018, 1:24 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review196652 --- PASS: Mesos patch 65465 was successfully built and tested. Review

Re: Review Request 65464: WIP: Introduced `mesos-build`, along with pre-built docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65464/#review196649 --- PASS: Mesos patch 65464 was successfully built and tested. Review

Re: Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/#review196648 --- src/slave/containerizer/mesos/main.cpp Lines 40-50 (patched)

Review Request 65465: Windows: Fixed recovery of Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65465/ --- Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu. Repository: mesos

Review Request 65463: Removed the `mesos-style.py` run from `buildbot.sh`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65463/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Review Request 65464: WIP: Introduced `mesos-build`, along with pre-built docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65464/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated Feb. 1, 2018, 7:09 p.m.) Review request for mesos, Alexander Rukletsov

Review Request 65462: Use the new 'route()' overload from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65462/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Review Request 65461: Provide new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Re: Review Request 65111: Added tests to verify v0 executor is shutdown if no task is delivered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65111/ --- (Updated Feb. 1, 2018, 10:54 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65363/#review196643 --- src/master/validation.cpp Lines 613-615 (patched)

Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65446/#review196640 --- Fix it, then Ship it! src/slave/slave.cpp Lines 8141 (patched)

Re: Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65445/#review196610 --- Fix it, then Ship it! src/slave/slave.hpp Lines 149 (patched)

Re: Review Request 65039: Tested reconciliation when operation is dropped en route to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65039/#review196639 --- Ship it! LGTM! nice comments! - Jie Yu On Jan. 31, 2018, 2:5

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review196638 --- Ship it! Ship It! - Armand Grillet On Jan. 19, 2018, 8:48 p.

Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65439/#review196635 --- PASS: Mesos patch 65439 was successfully built and tested. Review

Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65439/ --- (Updated Feb. 1, 2018, 2:07 p.m.) Review request for mesos, Armand Grillet and

Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65439/#review196631 --- support/post-reviews.py Line 115 (original), 115 (patched)

Re: Review Request 65045: Tested correct operation handling during master failover.

> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 8899 (patched) > > > > > > Is this necessary? Yes, the operation update will result in a `UPDATE_STATE` that will trigger ano

Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict.

> On Jan. 31, 2018, 6:48 p.m., Armand Grillet wrote: > > Can you please add tillt and/or bbannier as reviewers so that they can > > shepherd this patch? Sure, I'm just waiting to see who will be available first :) - Benno --- This is a

Re: Review Request 65045: Tested correct operation handling during master failover.

> On Feb. 1, 2018, 7:56 a.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 8903 (patched) > > > > > > Do we need this, or does framework registration after master failover > > prompt an offer? You're