Re: Review Request 65994: Made the master forward operation status updates to the schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65994/#review199064 --- PASS: Mesos patch 65994 was successfully built and tested.

Re: Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65919/#review199062 --- Fix it, then Ship it! src/tests/master_validation_tests.cpp

Re: Review Request 65918: Made sure no `name` parameter exists in container's Docker info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65918/#review199060 --- Fix it, then Ship it! src/common/validation.cpp Lines 283

Re: Review Request 65919: Added a test `TaskValidationTest.TaskSettingDockerContainerName`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65919/#review199061 --- Ship it! Ship It! - Gilbert Song On March 6, 2018, 12:41

Re: Review Request 65917: Added a test `TaskValidationTest.TaskMissingDockerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65917/#review199059 --- Ship it! Ship It! - Gilbert Song On March 5, 2018, 11:36

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/#review199057 --- PASS: Mesos patch 66034 was successfully built and tested.

Re: Review Request 66030: Fixed perf stat output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66030/#review199055 --- Patch looks great! Reviews applied: [66030] Passed command:

Re: Review Request 65916: Set Docker info for the test `TaskUsesDockerContainerInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65916/#review199054 --- Ship it! Ship It! - Gilbert Song On March 5, 2018, 11:36

Re: Review Request 65915: Validated Docker info exists when container's type is DOCKER.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65915/#review199053 --- Fix it, then Ship it! src/common/validation.cpp Lines 273

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review199052 --- 3rdparty/stout/include/stout/protobuf.hpp Lines 807-810

Re: Review Request 66026: Updated `ProtobufTest.JSON` for parsing JSON::String to bools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66026/#review199051 --- Fix it, then Ship it! 3rdparty/stout/tests/protobuf_tests.cpp

Re: Review Request 66034: Remount several proc filesystem entries as read-only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/ --- (Updated March 13, 2018, 1:29 a.m.) Review request for mesos, Eric Chung,

Review Request 66034: Remount several proc filesystem entries as read-only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66034/ --- Review request for mesos, Eric Chung, Gilbert Song, Ian Downes, Jie Yu, James

Re: Review Request 66030: Fixed perf stat output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66030/#review199050 --- PASS: Mesos patch 66030 was successfully built and tested.

Re: Review Request 66025: Converted `JSON::String` to bool and integers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66025/#review199049 --- 3rdparty/stout/include/stout/protobuf.hpp Lines 454-538

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

> On March 9, 2018, 11:40 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Line 389 (original), 389-397 (patched) > > > > > > Instead of relying on an additional checkpoint

Re: Review Request 66016: Refactored resource allocation logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66016/#review199048 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66016: Refactored resource allocation logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66016/#review199047 --- Ship it! Ship It! - Benjamin Mahler On March 12, 2018,

Re: Review Request 66031: Avoided copying when possible in Option::getOrElse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66031/#review199046 --- Ship it! Ship It! - Michael Park On March 12, 2018, 5:08

Review Request 66031: Avoided copying when possible in Option::getOrElse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66031/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 66030: Fixed perf stat output parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66030/ --- Review request for mesos and James Peach. Bugs: MESOS-8664

Re: Review Request 66016: Refactored resource allocation logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66016/ --- (Updated March 12, 2018, 4:07 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66016: Refactored resource allocation logic.

> On March 12, 2018, 3:29 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1610-1612 (patched) > > > > > > Hm.. as an aside, looks like `Option::getOrElse` could be improved

Re: Review Request 66016: Refactored resource allocation logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66016/#review199042 --- Good cleanup thanks! Just two issues below that I would like to

Re: Review Request 66025: Converted `JSON::String` to bool and integers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66025/#review199040 --- Can we clarify in the commit message that we're doing this to

Re: Review Request 63992: Handled incorrect offer operation IDs in master's ACCEPT handler.

> On March 7, 2018, 7:21 p.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 4136 (original), 4184 (patched) > > > > > > If the operation has an operation ID, we'll always land on this > > `continue`

Review Request 65879: Added a new test for validation of offer operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65879/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/#review199036 --- Ship it! Ship It! - Greg Mann On March 8, 2018, 11:39 p.m.,

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199032 --- Ship it! I'm fine with these changes, but the description can

Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/#review199034 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66013/#review199033 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66010: Windows: Switched to default CRT linkage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66010/#review199031 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66009/#review199030 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:38

Re: Review Request 66007: CMake: Set C++11 as standard automatically.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199029 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:37

Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review199026 --- Patch looks great! Reviews applied: [65350] Passed command:

Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review199023 --- PASS: Mesos patch 65350 was successfully built and tested.

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

> On March 9, 2018, 11:16 p.m., Greg Mann wrote: > > src/common/http.hpp > > Lines 198 (patched) > > > > > > See the comment I left on https://reviews.apache.org/r/65313/ - I > > wonder if `action` really needs to

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/ --- (Updated March 12, 2018, 3:05 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 66022: Based website-related Docker images on ubuntu16.

> On March 12, 2018, 12:51 p.m., Alexander Rukletsov wrote: > > site/Dockerfile > > Lines 12 (patched) > > > > > > You likely want to add `--no-install-recommends` here as well, right? I definitely want to, and now

Re: Review Request 66022: Based website-related Docker images on ubuntu16.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66022/ --- (Updated March 12, 2018, 2:29 p.m.) Review request for mesos, Armand Grillet

Re: Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66000/#review199018 --- Patch looks great! Reviews applied: [66000] Passed command:

Re: Review Request 65906: Updated site's middleman to latest 3.x release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65906/#review199017 --- Ship it! Ship It! - Alexander Rukletsov On March 10, 2018,

Re: Review Request 66022: Based website-related Docker images on ubuntu16.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66022/#review199016 --- Ship it! site/Dockerfile Lines 12 (patched)

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On March 7, 2018, 4:13 a.m., Greg Mann wrote: > > src/master/master.cpp > > Line 7722 (original), 7680-7681 (patched) > > > > > > Perhaps we also want to rescind offers when > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review199014 --- PASS: Mesos patch 66001 was successfully built and tested.

Re: Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66000/#review199012 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66000: Update enforce_container_disk_quota documentation to include disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66000/ --- (Updated March 12, 2018, 8:28 a.m.) Review request for mesos and James Peach.

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

> On March 1, 2018, 12:10 p.m., Benjamin Mahler wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 391-487 (patched) > > > > > > It looks like we can avoid this logic since protobuf's JSON conversion >

Re: Review Request 59987: Added protobuf map support to stout JSON<->protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated March 12, 2018, 3:15 p.m.) Review request for mesos, Anand Mazumdar,