Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.

> On March 21, 2018, 11:06 p.m., Gilbert Song wrote: > > src/slave/flags.cpp > > Lines 251-257 (patched) > > > > > > Should we update `configuration/agent.md`? In those docs we should make it clear what kinds of

Re: Review Request 65987: Allow nested containers in pods to have separate namespaces(Ref: MESOS-8534).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65987/ --- (Updated March 22, 2018, 3 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review199736 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review199726 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review199705 --- src/slave/slave.cpp Line 2202 (original), 2203-2204 (patched)

Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65856/#review199719 --- Fix it, then Ship it! src/slave/flags.cpp Lines 251-257

Re: Review Request 65855: Added the `stall_timeout` parameter to `net::download()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65855/#review199717 --- Fix it, then Ship it! 3rdparty/stout/include/stout/net.hpp

Re: Review Request 65855: Added the `stall_timeout` parameter to `net::download()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65855/#review199716 --- Ship it! Ship It! - Gilbert Song On Feb. 28, 2018, 9:13

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/ --- (Updated March 21, 2018, 2:57 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review199711 --- src/slave/slave.hpp Lines 1141-1143 (patched)

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

> On March 21, 2018, 11:37 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2197-2199 (original), 2250-2252 (patched) > > > > > > Looks like you have an extra "because the framework" here. Also, this > >

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated March 21, 2018, 2:49 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

> On March 21, 2018, 1:55 p.m., Chun-Hung Hsiao wrote: > > src/tests/slave_tests.cpp > > Lines 5137-5138 (patched) > > > > > > Just curious, why do you break the assigment into two lines here but > > not below? ;)

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated March 21, 2018, 2:40 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66119: Added a mock sandbox garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66119/ --- (Updated March 21, 2018, 2:37 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199703 --- Ship it! src/tests/slave_tests.cpp Lines 5137-5138 (patched)

Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66158/ --- (Updated March 21, 2018, 8:25 p.m.) Review request for mesos, Andrew

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199699 --- src/tests/slave_tests.cpp Lines 4698-4703 (original), 4696-4701

Re: Review Request 66158: Libprocess: Made tests `GRPCClientTest.*` cross-platform.

> On March 20, 2018, 4:59 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 67 (patched) > > > > > > nit: Let's make this constructor `explicit`. I think it would also make > >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated March 21, 2018, 7:52 p.m.) Review request for mesos, Alexander

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66156/ --- (Updated March 21, 2018, 7:32 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated March 21, 2018, 11:38 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66120: Updated an agent test to use mock garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66120/ --- (Updated March 21, 2018, 11:37 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199477 --- src/slave/slave.hpp Lines 172-173 (original), 172-173 (patched)

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review199691 --- src/tests/slave_tests.cpp Line 5088 (original), 5088 (patched)

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/#review199684 --- src/tests/slave_tests.cpp Lines 4919-4928 (patched)

Re: Review Request 66119: Added a mock sandbox garbage collector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66119/ --- (Updated March 21, 2018, 11:35 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 66164: Added to a comment in master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66164/#review199675 --- Ship it! I felt I had to comment on wording since I'm giving a

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199674 --- Patch looks great! Reviews applied: [66037] Passed command:

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199672 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/ --- (Updated March 21, 2018, 3:58 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199662 --- Looks great, thanks for making the capability the default!

Re: Review Request 66177: Fixed flakiness in ROOT_DOCKER_SlaveRecoveryTaskContainer test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66177/#review199661 --- Ship it! Ship It! - Alexander Rukletsov On March 20, 2018,

Re: Review Request 65665: Added operation state metrics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65665/#review199657 --- src/resource_provider/storage/provider.cpp Line 493 (original),

Re: Review Request 66162: Changed names related to `DiskProfileAdaptor` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66162/#review199644 --- Ship it! - Benjamin Bannier On March 20, 2018, 11:52 p.m.,

Re: Review Request 66161: Renamed the internal namespace `profile` to `storage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66161/#review199645 --- Ship it! - Benjamin Bannier On March 20, 2018, 11:50 p.m.,

Re: Review Request 66160: Renamed `*disk_profile.?pp` to `*disk_profile_adatpor.?pp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66160/#review199653 --- Ship it! Ship It! - Benjamin Bannier On March 21, 2018,

Re: Review Request 66095: Fixed gRPC compilation in standalone libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66095/#review199652 --- Ship it! Ship It! - Benjamin Bannier On March 16, 2018,

Re: Review Request 66095: Fixed gRPC compilation in standalone libprocess build.

> On March 20, 2018, 4:05 p.m., Benjamin Bannier wrote: > > I think it would make sense to fold this patch into > > https://reviews.apache.org/r/66094/. > > Chun-Hung Hsiao wrote: > Cannot do it because it is in Mesos. Make sense. What this patch effectively does is completing the changes

Re: Review Request 66094: Bumped bundled gRPC to 1.10.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66094/#review199651 --- Ship it! Ship It! - Benjamin Bannier On March 15, 2018,

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review199649 --- src/tests/master_allocator_tests.cpp Line 759 (original), 748

Re: Review Request 66165: Re-fixed many master allocator tests.

> On March 21, 2018, 10:50 a.m., Alexander Rukletsov wrote: > > LGTM assuming some non-trivial changes, like slave flags manipulation in > > `SlaveReregistersFirst`, are the result of a revert. Also please rebase so that the Reviewbot can pick it up. - Alexander

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review199646 --- Ship it! LGTM assuming some non-trivial changes, like slave

Re: Review Request 66156: Compiled `csi.proto` when gRPC is disabled.

> On March 20, 2018, 4:55 p.m., Benjamin Bannier wrote: > > include/csi/spec.hpp > > Lines 23 (patched) > > > > > > Not really related to this particular patch, but referencing this > > somewhat internal define in a