Re: Review Request 66474: Updated minimum supported Linux kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66474/#review200890 --- Ship it! Ship It! - Gilbert Song On April 5, 2018, 5:21 a.m.

Re: Review Request 66457: WIP: Made resource provider API aware of workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/#review200885 --- Bad patch! Reviews applied: [66457, 66418, 66411, 66410, 66409, 6

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/#review200882 --- Patch looks great! Reviews applied: [66538, 66539, 66540, 66541]

Re: Review Request 66457: WIP: Made resource provider API aware of workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/#review200874 --- FAIL: Failed to apply the dependent review: 66398. Failed command

Re: Review Request 66457: WIP: Made resource provider API aware of workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/ --- (Updated April 11, 2018, 2:38 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 66418: Handled failed publish and unpublish CSI calls properly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66418/ --- (Updated April 11, 2018, 2:37 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66411: Made the test CSI plugin compatible to CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66411/ --- (Updated April 11, 2018, 2:36 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66410: Adapted storage local resource provider to use CSI v0.2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66410/ --- (Updated April 11, 2018, 2:34 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- (Updated April 10, 2018, 7:25 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63367/#review200870 --- 3rdparty/stout/include/stout/strings.hpp Lines 390-392 (patched)

Re: Review Request 63367: Added overloads for strings::startsWith and strings::endsWith().

> On Jan. 24, 2018, 5:02 p.m., Michael Park wrote: > > I would prefer a more general, systematic approach to this situation. > > I really don't want to be deal with adding `string` and `const char []` > > overloads everywhere. Ideally, we'd have a `string_view` class that we > > could use instead

Re: Review Request 65334: Added quota limit to the master API protos.

> On March 18, 2018, 8:27 p.m., Meng Zhu wrote: > > include/mesos/master/master.proto > > Lines 206 (patched) > > > > > > Why we are making it a repeated field? What is the usage case? Much like `UpdateWeights`, the

Re: Review Request 66468: Added tests for operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/#review200865 --- Patch looks great! Reviews applied: [66458, 66459, 66460, 66461,

Re: Review Request 65334: Added quota limit to the master API protos.

> On March 18, 2018, 6:27 p.m., Meng Zhu wrote: > > include/mesos/v1/quota/quota.proto > > Lines 46-48 (original), 67-69 (patched) > > > > > > If I understand it correctly, > > > > for guarantee check, we c

Re: Review Request 66541: Added default executor test for agent recovery without metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/#review200862 --- PASS: Mesos patch 66541 was successfully built and tested. Review

Re: Review Request 66044: Refactored resources chopping logic in allocator.

> On April 10, 2018, 10 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1607-1610 (patched) > > > > > > I assume this continues to work as the value scalar goes negative? We >

Re: Review Request 66539: Fixed the agent recovery crash if metadata is missing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66539/#review200859 --- Ship it! Ship It! - Jie Yu On April 10, 2018, 11:41 p.m., Gi

Review Request 66540: Added unit test for recovering nested container without slave state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66540/ --- Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. Bugs

Review Request 66538: Added unit test slave recovery for default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66538/ --- Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. Bugs

Review Request 66541: Added default executor test for agent recovery without metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66541/ --- Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. Bugs

Review Request 66539: Fixed the agent recovery crash if metadata is missing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66539/ --- Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. Bugs

Re: Review Request 66468: Added tests for operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/#review200857 --- PASS: Mesos patch 66468 was successfully built and tested. Review

Re: Review Request 66044: Refactored resources chopping logic in allocator.

> On April 10, 2018, 3 p.m., Benjamin Mahler wrote: > > Looks good! Just thinking we probably should pull the shrink function up > > and unit test it? Feel free to do that in a second patch. Got it. Will put it in the resource headers in a followup patch. > On April 10, 2018, 3 p.m., Benjamin

Re: Review Request 66044: Refactored resources chopping logic in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66044/ --- (Updated April 10, 2018, 3:54 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66044: Refactored resources chopping logic in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66044/#review200846 --- Fix it, then Ship it! Looks good! Just thinking we probably sho

Re: Review Request 66468: Added tests for operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/ --- (Updated April 10, 2018, 2:56 p.m.) Review request for mesos and Greg Mann. C

Re: Review Request 66465: Updated `using` statements in `tests/mesos.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66465/#review200853 --- Ship it! Ship It! - Greg Mann On April 5, 2018, 12:48 a.m.,

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66467/#review200852 --- Ship it! Ship It! - Greg Mann On April 5, 2018, 12:50 a.m.,

Re: Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66466/#review200849 --- Ship it! Ship It! - Greg Mann On April 5, 2018, 12:49 a.m.,

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66468: Added tests for operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/#review200845 --- Patch looks great! Reviews applied: [66458, 66459, 66460, 66461,

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 8:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 10, 2018, 1:45 p.m., Benjamin Mahler wrote: > > include/mesos/v1/scheduler.hpp > > Lines 102-114 (patched) > > > > > > Hm.. why does this return an `Option`? > > > > If this is mesos Response rath

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200842 --- include/mesos/v1/scheduler.hpp Lines 102-114 (patched)

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/#review200841 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66468: Added tests for operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/#review200839 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66532/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8748 h

Review Request 66531: Added new authorization for `UpdateVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Bugs: MESOS-8748 h

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/ --- (Updated April 10, 2018, 12:04 p.m.) Review request for mesos, Akash Gupta, Eri

Re: Review Request 66462: Added new operation states to be used for status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66462/#review200834 --- Fix it, then Ship it! include/mesos/mesos.proto Lines 2314 (pa

Re: Review Request 66468: Added tests for operation status reconciliation.

> On April 9, 2018, 5:08 p.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 364-365 (patched) > > > > > > Is there a reason not to do this with a `for` loop? > > Gaston Kleiman wrote:

Re: Review Request 66468: Added tests for operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66468/ --- (Updated April 10, 2018, 11:45 a.m.) Review request for mesos and Greg Mann.

Re: Review Request 66489: Cleaned up internal evolve functions.

> On April 10, 2018, 11:39 a.m., Greg Mann wrote: > > src/internal/evolve.hpp > > Line 152 (original), 152-153 (patched) > > > > > > Can we get rid of the `mesos::` here as well? Nope, if we get rid of `mesos::` her

Re: Review Request 66489: Cleaned up internal evolve functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66489/#review200833 --- Fix it, then Ship it! src/internal/evolve.hpp Line 152 (origin

Re: Review Request 66460: Added a `call()` method to the v1 scheduler library.

> On April 6, 2018, 9:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > > > > > Since we don't guarantee backwards compat for this library, can we just > > upda

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/#review200831 --- Ship it! Ship It! - Greg Mann On April 7, 2018, 12:16 a.m.,

Re: Review Request 66511: Updated tests due to change of containerizer's `destroy()` return type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66511/#review200830 --- src/tests/containerizer.cpp Lines 534-535 (original), 535-537 (pa

Re: Review Request 66510: Unified return type of `wait` and `destroy` containerizer methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66510/#review200828 --- src/slave/containerizer/composing.cpp Line 376 (original), 378 (p

Re: Review Request 66527: Avoided copy in accessing resource provider subscription field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66527/#review200826 --- PASS: Mesos patch 66527 was successfully built and tested. All th

Re: Review Request 66528: Added logging of failed resource provider registry updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66528/#review200824 --- PASS: Mesos patch 66528 was successfully built and tested. Review

Re: Review Request 66311: Implement recovery of resource provider manager.

> On April 10, 2018, 3:05 p.m., Jan Schlicht wrote: > > Thank you for your comments. I have some issues updating the patch in reviewboard at this time, will retry later. Please see my responses below. > On April 10, 2018, 3:05 p.m., Jan Schlicht wrote: > > src/resource_provider/manager.cpp >

Re: Review Request 66528: Added logging of failed resource provider registry updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66528/ --- (Updated April 10, 2018, 5:05 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

> On April 6, 2018, 2:02 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 104-113 (patched) > > > > > > Does this class have to be nested? How about making it >

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/ --- (Updated April 10, 2018, 2:39 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 63366: Add jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated April 10, 2018, 2:38 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 66528: Added logging of failed resource provider registry updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66528/#review200819 --- Fix it, then Ship it! src/resource_provider/registrar.cpp Line

Re: Review Request 66527: Avoided copy in accessing resource provider subscription field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66527/#review200818 --- Ship it! Ship It! - Jan Schlicht On April 10, 2018, 2:56 p.m

Re: Review Request 66508: Made sure test agent has reached stable state before starting test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66508/#review200817 --- Ship it! Ship It! - Jan Schlicht On April 9, 2018, 4:07 p.m.

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/#review200815 --- Patch looks great! Reviews applied: [66493] Passed command: expo

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200814 --- PASS: Mesos patch 66311 was successfully built and tested. Review

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/#review200734 --- src/resource_provider/manager.cpp Lines 65 (patched)

Review Request 66527: Avoided copy in accessing resource provider subscription field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66527/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Review Request 66528: Added logging of failed resource provider registry updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66528/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 66309: Externalize creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 66308: Delayed construction of the agent's resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- (Updated April 10, 2018, 2:07 p.m.) Review request for mesos, Jie Yu and Jan Sc

Re: Review Request 66309: Externalize creation of resource provider manager backing storage.

> On March 28, 2018, 3:30 p.m., Jan Schlicht wrote: > > src/resource_provider/registrar.hpp > > Lines 68-69 (original), 70-71 (patched) > > > > > > I don't like the semantics of this: > > A `state::Storage` doesn'

Review Request 66526: Renamed resource provider `AgentRegistrar` to `GenericRegistrar`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66526/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jan Schlicht. Bugs: M

Re: Review Request 66415: Changed SLEEP_COMMAND to use ping instead of powershell Start-Sleep on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66415/#review200801 --- PASS: Mesos patch 66415 was successfully built and tested. Review

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/#review200798 --- PASS: Mesos patch 66493 was successfully built and tested. Review