Re: Review Request 66820: Added framework metrics 'subscribed' and helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66820/ --- (Updated April 26, 2018, 11:54 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202050 --- Patch looks great! Reviews applied: [66420, 66421, 66422, 66423,

Re: Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66840/#review202049 --- Ship it! Ship It! - Gilbert Song On April 26, 2018, 6:35 p.m

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202048 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.

Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66835/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.

Review Request 66834: Windows: Specialized `flags::parse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph Wu.

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/ --- (Updated April 26, 2018, 9:21 p.m.) Review request for mesos, Akash Gupta, John

Re: Review Request 66578: Windows: Ported more unit tests from `os_tests.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66578/ --- (Updated April 26, 2018, 9:20 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/ --- (Updated April 26, 2018, 9:17 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66811: Added `libacl` as a dependency of stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66811/#review202046 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 26, 2018,

Re: Review Request 66811: Added `libacl` as a dependency of stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66811/ --- (Updated April 27, 2018, 9:35 a.m.) Review request for mesos, Gilbert Song, Gre

Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66840/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Re: Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66832/#review202043 --- Patch looks great! Reviews applied: [66828, 66830, 66831, 66832]

Re: Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66832/#review202037 --- PASS: Mesos patch 66832 was successfully built and tested. Review

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/#review202036 --- Patch looks great! Reviews applied: [65505] Passed command: expo

Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66831/ --- Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach,

Review Request 66828: Introduced a push-based gauge metric.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66828/ --- Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James Peach,

Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66832/ --- Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod Kon

Review Request 66830: Added a test for PushGauge.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66830/ --- Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod Kon

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review202032 --- src/master/master.cpp Line 4565 (original), 4563 (patched)

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review202030 --- Patch looks great! Reviews applied: [8, 9, 66670, 66671,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/#review202029 --- Ship it! Ship It! - Chun-Hung Hsiao On April 26, 2018, 12:39

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/#review202026 --- PASS: Mesos patch 66817 was successfully built and tested. Review

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/#review202022 --- PASS: Mesos patch 65505 was successfully built and tested. Review

Re: Review Request 66531: Added new authorization for `ResizeVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66531/#review201978 --- Fix it, then Ship it! src/authorizer/local/authorizer.cpp Line

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/#review202017 --- Patch looks great! Reviews applied: [66815] Passed command: expo

Re: Review Request 66749: Added more logging to agent recovery path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66749/#review202016 --- Ship it! Ship It! - Greg Mann On April 23, 2018, 10:30 p.m.,

Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66799/#review202015 --- Ship it! Ship It! - Greg Mann On April 25, 2018, 4:46 p.m.,

Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66817/ --- Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/ --- (Updated April 26, 2018, 5 p.m.) Review request for mesos, Jie Yu, Joseph Wu, a

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/#review202013 --- PASS: Mesos patch 66815 was successfully built and tested. Review

Re: Review Request 66814: Added a test `FsAclTest.ManipulateAcl`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66814/#review202012 --- PASS: Mesos patch 66814 was successfully built and tested. Review

Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66815/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8797 https://issues.

Review Request 66814: Added a test `FsAclTest.ManipulateAcl`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66814/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Review Request 66813: Added `setfacl()` and `getfacl()` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66813/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Review Request 66812: Added `libacl` as a dependency of Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66812/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Review Request 66811: Added `libacl` as a dependency of stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66811/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu. Bug

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review202003 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 66311: Set up recovery code paths of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- (Updated April 26, 2018, 2:39 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66310: Passed on registrar when constructing resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- (Updated April 26, 2018, 2:39 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review201999 --- Patch looks great! Reviews applied: [66644] Passed command: expo

Re: Review Request 63371: Added unit test for new MemoryProfiler class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63371/#review201998 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review201997 --- I'll fix the outstanding issues, make minor adjustments, align acc

Re: Review Request 63372: Added documentation for memory profiling.

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote: > > docs/memory-profiling.md > > Lines 192 (patched) > > > > > > Let's have an inline link in form []() for consistency. > > Benno Evers wrote: > The p

Review Request 66405: Doc improvements (wip).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66405/ --- Review request for mesos. Repository: mesos Description --- Doc improvem

Re: Review Request 63371: Added unit test for new MemoryProfiler class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63371/ --- (Updated April 26, 2018, 9:59 a.m.) Review request for mesos and Alexander Rukl

Re: Review Request 63372: Added documentation for memory profiling.

> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote: > > docs/memory-profiling.md > > Lines 122-124 (patched) > > > > > > Is `dot` tool required as well? > > Benno Evers wrote: > Wasn't that what you foun

Re: Review Request 66799: Fixed flakyness in 'MasterAPITest.MasterFailover'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66799/#review201988 --- Patch looks great! Reviews applied: [66799] Passed command: expo

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66644/#review201987 --- PASS: Mesos patch 66644 was successfully built and tested. Review