Review Request 66984: WIP: exhaustively allocate declined resources.

2018-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66984/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod

Review Request 66983: Added an option to show if filtering is due to framework decline.

2018-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66983/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod

Review Request 66982: Added a `decline` flag in `recoverResources` in the allocator.

2018-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66982/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod

Review Request 66981: Added a new flag to the allocator.

2018-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66981/ --- Review request for mesos, Benjamin Mahler, Kapil Arya, Till Toenshoff, and Vinod

Re: Review Request 66978: Disabled debug mode for libevent.

2018-05-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66978/#review202535 --- PASS: Mesos patch 66978 was successfully built and tested. Review

Re: Review Request 66978: Disabled debug mode for libevent.

2018-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66978/#review202534 --- Patch looks great! Reviews applied: [66977, 66978] Passed comman

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66230/#review202533 --- Can we simplify these tests and remove the executors? Also, over

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review202529 --- src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp Lines 688

Re: Review Request 66228: Added Call for updating framework info.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/#review202532 --- include/mesos/scheduler/scheduler.proto Lines 479 (patched)

Re: Review Request 66228: Added Call for updating framework info.

2018-05-06 Thread Benjamin Mahler
> On May 7, 2018, 2:41 a.m., Benjamin Mahler wrote: > > Can you add some description to this change? - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/#review202528 ---

Re: Review Request 66977: Re-enable epoll support for libevent.

2018-05-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66977/#review202530 --- PASS: Mesos patch 66977 was successfully built and tested. Review

Re: Review Request 66228: Added Call for updating framework info.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66228/#review202528 --- include/mesos/scheduler/scheduler.proto Lines 477-478 (patched) <

Re: Review Request 66872: Updated FrameworkInfo comparator.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66872/#review202527 --- Per discussion, let's just check all the fields using the existing

Review Request 66978: Disabled debug mode for libevent.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66978/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Bugs: MESOS-8885 h

Review Request 66977: Re-enable epoll support for libevent.

2018-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66977/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Bugs: MESOS-8881 h

Re: Review Request 66975: Add documentation for the xfs-kill-containers flag.

2018-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66975/#review202526 --- Patch looks great! Reviews applied: [66975] Passed command: expo

Re: Review Request 66975: Add documentation for the xfs-kill-containers flag.

2018-05-06 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66975/#review202525 --- PASS: Mesos patch 66975 was successfully built and tested. Review

Review Request 66975: Add documentation for the xfs_kill_containers flag.

2018-05-06 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66975/ --- Review request for mesos, Greg Mann and James Peach. Bugs: MESOS-6575 https

Re: Review Request 66975: Add documentation for the xfs_kill_containers flag.

2018-05-06 Thread Harold Dost
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66975/ --- (Updated May 6, 2018, 3:03 p.m.) Review request for mesos, Greg Mann and James