Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

2018-08-10 Thread Andrew Schwartzmeyer
> On Aug. 10, 2018, 7:41 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos binaries failed to build. > > > > Reviews applied: `['67931', '67930', '67984', '67932']` > > > > Failed command: `cmake.exe --build . --config Release -- /maxcpucount` > > > > All the build artifacts available at:

Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review207103 --- FAIL: Mesos binaries failed to build. Reviews applied: `['67931',

Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/#review207101 --- PASS: Mesos patch 68304 was successfully built and tested. Review

Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68303/#review207099 --- PASS: Mesos patch 68303 was successfully built and tested. Review

Review Request 68304: Fixed a bug in the agent authentication retry logic.

2018-08-10 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68304/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Bugs: MESOS-9147

Re: Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68303/#review207098 --- Ship it! Tested with `libssl-dev` uninstalled; repro'ed without

Re: Review Request 68301: WIP: Tests with `default:id`. Not for merging.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/#review207095 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 68303: Fixed gRPC compilation for non-SSL build.

2018-08-10 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68303/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: MESO

Re: Review Request 68054: Added networking statistics to cni isolator.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207092 --- PASS: Mesos patch 68054 was successfully built and tested. Review

Review Request 68301: WIP: Tests with `default:id`. Not for merging.

2018-08-10 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. Repos

Re: Review Request 68300: Added `gpus` to failure message.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68300/#review207089 --- PASS: Mesos patch 68300 was successfully built and tested. Review

Re: Review Request 68054: Added networking statistics to cni isolator.

2018-08-10 Thread Sergey Urbanovich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/ --- (Updated Aug. 10, 2018, 7:08 p.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 68299: Documented new `--cgroups_destroy_timeout` agent option.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68299/#review207085 --- FAIL: Failed to apply the dependent review: 68088. Failed command

Re: Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68297/#review207084 --- PASS: Mesos patch 68297 was successfully built and tested. Review

Re: Review Request 68300: Added `gpus` to failure message.

2018-08-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68300/#review207083 --- Ship it! Ship It! - Gilbert Song On Aug. 10, 2018, 11:11 a.m

Review Request 68296: WIP: Add 'handler' field to batched state requests.

2018-08-10 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68296/ --- Review request for mesos, Alexander Rukletsov and Benjamin Mahler. Repository:

Review Request 68300: Added `gpus` to failure message.

2018-08-10 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68300/ --- Review request for mesos, Gilbert Song and Jason Lai. Repository: mesos Descr

Review Request 68299: Documented new `--cgroups_destroy_timeout` agent option.

2018-08-10 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68299/ --- Review request for mesos, Gilbert Song and Jason Lai. Repository: mesos Descr

Re: Review Request 68088: Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag.

2018-08-10 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/ --- (Updated Aug. 10, 2018, 10:36 a.m.) Review request for mesos, Gilbert Song, Jas

Review Request 68297: Windows: Fixed a bug when `executorId` contains a `:`.

2018-08-10 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68297/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. Bugs:

Re: Review Request 68054: Added networking statistics to cni isolator.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207079 --- PASS: Mesos patch 68054 was successfully built and tested. Review

Re: Review Request 68054: Added networking statistics to cni isolator.

2018-08-10 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68054/#review207077 --- PASS: Mesos patch 68054 was successfully built and tested. Review