Re: Review Request 68637: Avoided common-case extra copying of Resources in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68637/#review208388 --- src/master/master.cpp Line 9379 (original), 9378 (patched)

Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68646/#review208394 --- PASS: Mesos patch 68646 was successfully built and tested. Review

Re: Review Request 68639: Renamed `Resources::resources` to `noMutationWithoutExclusiveOwnership`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/#review208393 --- PASS: Mesos patch 68639 was successfully built and tested. Review

Review Request 68645: Updated IO switchboard to use subprocess's `whitelist_fds` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68645/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9152 ht

Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9152 ht

Review Request 68642: Added `lsof()` into stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9152 ht

Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68646/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9152 ht

Review Request 68643: Updated `MesosContainerizerLaunch` to call `os::lsof()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68643/ --- Review request for mesos, Gilbert Song and James Peach. Bugs: MESOS-9152 ht

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208391 --- FAIL: Failed to apply the dependent review: 68640. Failed command

Re: Review Request 68637: Avoided common-case extra copying of Resources in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68637/#review208390 --- PASS: Mesos patch 68637 was successfully built and tested. Review

Re: Review Request 68636: Reserved vector capacities within Master::offer.

> On Sept. 6, 2018, 12:41 a.m., Meng Zhu wrote: > > src/master/master.cpp > > Lines 9249 (patched) > > > > > > can you put the type here instead of `auto`? Unfortunately templated types don't work inside `foreach(|

Re: Review Request 68636: Reserved vector capacities within Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68636/#review208387 --- Ship it! src/master/master.cpp Lines 9249 (patched)

Review Request 68640: Added version check and bundling of libevent to autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. B

Review Request 68641: Added version check and bundling of libevent within libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. B

Re: Review Request 68635: Avoided triple-lookup of the framework in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68635/#review208386 --- Ship it! Ship It! - Meng Zhu On Sept. 5, 2018, 3:15 p.m., Be

Review Request 68639: Renamed `Resources::resources` to `noMutationWithoutExclusiveOwnership`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68639/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Gastón Kleiman.

Re: Review Request 68404: Updated XFS recovery tests with persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68404/#review208384 --- PASS: Mesos patch 68404 was successfully built and tested. Review

Re: Review Request 68634: Avoided double-lookup in Master::getFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68634/#review208383 --- Ship it! Ship It! - Meng Zhu On Sept. 5, 2018, 3:15 p.m., Be

Review Request 68634: Avoided double-lookup in Master::getFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68634/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos Desc

Review Request 68636: Reserved vector capacities within Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68636/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos Desc

Review Request 68637: Avoided common-case extra copying of Resources in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68637/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos Desc

Review Request 68635: Avoided triple-lookup of the framework in Master::offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68635/ --- Review request for mesos, Gastón Kleiman and Meng Zhu. Repository: mesos Desc

Re: Review Request 68400: Exposed an XFS helper to find the block device for a given path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68400/ --- (Updated Sept. 5, 2018, 9:59 p.m.) Review request for mesos, Chun-Hung Hsiao, I

Re: Review Request 68398: Added `fs::used` helper API to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68398/ --- (Updated Sept. 5, 2018, 9:58 p.m.) Review request for mesos, Chun-Hung Hsiao, I

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 5, 2018, 2:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 5, 2018, 2:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65112: Added documentation about standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65112/#review208380 --- docs/standalone-containers.md Lines 140-142 (patched)

Re: Review Request 68426: Refactored some cgroups helpers to do verify from callers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68426/#review207647 --- For posterity, numbers with --enabled-optimize: ``` Before Fix: P

Re: Review Request 68555: Made checker library retry to remove the previous check container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68555/#review208373 --- Ship it! Ship It! - Gilbert Song On Aug. 29, 2018, 12:22 a.m

Re: Review Request 68495: Made command check always waits before removing the nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68495/#review208372 --- Ship it! Ship It! - Gilbert Song On Sept. 3, 2018, 6:53 p.m.

Re: Review Request 68553: Set 'Connection: close' in the master's streaming API responses.

> On Sept. 5, 2018, 3:11 a.m., Gastón Kleiman wrote: > > We should do the same in the executor API handler. Yeah, originally I did that in this patch, but it ended up being more complicated than I anticipated. In any case, I commented in MESOS-9189 that I would leave the ticket open (although,

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 4, 2018, 2:36 a.m., Benjamin Bannier wrote: > > Have you benchmarked against a dedicated copy-on-write abstraction? I > > understand that the current implementation which only copies when needed > > might be more performant, but it also appears to carry a huge mental > > overhead to

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

> On Sept. 3, 2018, 9:59 p.m., Benjamin Mahler wrote: > > Thanks! Can you also include some commentary on the rest of the allocation > > benchmarks as well as the overhead within the Resources micro-benchmarks? Posted the updated patches. Will summarize and post more comprehensive results soon

Re: Review Request 68490: Optimized `class Resources` with copy-on-write.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68490/ --- (Updated Sept. 5, 2018, 12:17 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65168/#review208366 --- PASS: Mesos patch 65168 was successfully built and tested. Review

Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65168/ --- (Updated Sept. 5, 2018, 4:34 p.m.) Review request for mesos and Alexander Rukle

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/#review208355 --- PASS: Mesos patch 68568 was successfully built and tested. Review

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68568/ --- (Updated Sept. 5, 2018, 12:18 p.m.) Review request for mesos and Alexander Rukl

Re: Review Request 68567: Restructured /roles code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68567/ --- (Updated Sept. 5, 2018, 12:14 p.m.) Review request for mesos and Alexander Rukl

Re: Review Request 68627: Brought site dependencies up to date.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68627/#review208344 --- Ship it! Ship It! - Till Toenshoff On Sept. 5, 2018, 8:53 a.

Re: Review Request 68627: Brought site dependencies up to date.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68627/#review208343 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 5, 2018, 8:

Review Request 68627: Brought site dependencies up to date.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68627/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti